Description of problem: jarbundler is a dependency for freemind. Version-Release number of selected component (if applicable): 2.1.0 Description of jarbundler: How many times has this happened to you? You've written a little Java utility, or maybe even a more complex application, and you want to create Mac OS X application bundle for easy distribution. You'd like to be able to do it automatically from your build process, but you're forced to go run the Apple Jar Bundler and tweak all the settings manually every time you build. Well no more! JarBundler is a feature-rich Ant task which will create a Mac OS X application bundle from a list of Jar files and a main class name. You can add an Icon resource, set various Mac OS X native look-and-feel bells and whistles, and maintain your application bundles as part of your normal build and release cycle. It is free software licensed under the GNU General Public License. Additional info: SpecURL: http://dl.dropbox.com/u/3917796/jarbundler.spec RPMURL: http://dl.dropbox.com/u/3917796/jarbundler-2.1.0-1.fc13.src.rpm
Fix component.
Some quick comments: * ant plugin should Require: ant * %doc is empty but it should be %doc LICENSE.TXT * take a look at http://pkgs.fedoraproject.org/gitweb/?p=ant-contrib.git;a=blob;f=ant-contrib.spec;h=341edf1e9cdc7c30cf94d8acc56e74816a86bc27;hb=21625d44ef49edf5f7c23b8bcaea7ac5dd010591 for the way to integrate properly into ant by using ant.d When this is fixed I'll do full review.
Also you have to call ant jar javadoc and package the javadoc folder instead of dox.
Spec URL: http://dl.dropbox.com/u/3917796/jarbundler.spec SRPM URL: http://dl.dropbox.com/u/3917796/jarbundler-2.1.0-2.fc13.src.rpm I tried to fix everything you mentioned but I am not quite sure what you mean with "call [...] jar javadoc and package the javadoc folder instead of dox." because there is no javadoc folder in the sources or I am not able to identify one. Hope this second one is better than the first one.
http://hannes.fedorapeople.org/
I assume you want me to review: Spec URL: http://hannes.fedorapeople.org/jarbundler.spec SRPM URL: http://hannes.fedorapeople.org/jarbundler-2.1.0-4.fc13.src.rpm Correct?
Review: FIXIT: rpmlint must be run on every package. The output should be posted in the review. Output: jarbundler.spec:39: W: non-standard-group Development Documentation Just make it Documentation jarbundler.spec:98: W: macro-in-%changelog %doc Macros have to be escaped in order to not be expanded. It should be %%doc in the changelog. /jarbundler.spec:71: W: mixed-use-of-spaces-and-tabs (spaces: line 71, tab: line 1) Not mandatory but it's good to follow one convention in the spec. jarbundler.src: W: name-repeated-in-summary C JarBundler If you want you can change that somehow. jarbundler-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Javanese jarbundler-javadoc.noarch: W: non-conffile-in-etc /etc/ant.d/jarbundler False positives. jarbundler.noarch: W: incoherent-version-in-changelog 2.1.0-3 ['2.1.0-4.fc13', '2.1.0-4'] Your last changelog is 2.1.0-3 while your package nvr is 2.1.0-4. OK: The package must be named according to the Package Naming Guidelines . OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK: The package must meet the Packaging Guidelines . OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . OK: The License field in the package spec file must match the actual license. OK: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK: The spec file must be written in American English. OK: The spec file for the package MUST be legible. OK: The sources used to build the package must match the upstream source, as provided in the spec URL. OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK: All build dependencies must be listed in BuildRequire OK: Packages must NOT bundle copies of system libraries. OK: A package must own all directories that it creates. OK: A Fedora package must not list a file more than once in the spec file's %files listings. OK: Permissions on files must be set properly. FIXIT: Each package must consistently use macros. You are using both %{buildroot} and $RPM_BUILD_ROOT. Please use one of them consistently. OK: The package must contain code, or permissable content. OK: Large documentation files must go in a -doc subpackage. OK: If a package includes something as %doc, it must not affect the runtime of the application. OK: Packages must not own files or directories already owned by other packages. OK: All filenames in rpm packages must be valid UTF-8. Other things to fix: * %{_sysconfdir}/ant.d/jarbundler should be in %files not in %files javadoc * it would be good to format a bit, e.g. put empty lines between changelog entries and etc. Once this minor issues are fixed the package is good.
Spec URL: http://hannes.fedorapeople.org/jarbundler.spec SRPM URL: http://hannes.fedorapeople.org/jarbundler-2.1.0-5.fc13.src.rpm rpmlint jarbundler.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. Hopefully I corrected all issues. Let me know if there are any other things. Greetings...
Thanks, This packag is APPROVED.
New Package SCM Request ======================= Package Name: jarbundler Short Description: A feature-rich Ant task which will create a Mac OS X application bundle Owners: hannes Branches: f13 f14 InitialCC:
Git done (by process-git-requests).
build in rawhide: http://koji.fedoraproject.org/koji/packageinfo?packageID=10854