From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.9) Gecko/20020401 Description of problem: Our gnumeric is applied l10n patch for Japanese Excel files. this patch was useful when our gnome-print was applied VFlib2 patch, but gnumeric which was applied this patch doesn't work now correctly. Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1.runs gnumeric 2.open Japanese Excel file 3. Actual Results: most Japanese Excel file use the MS fonts like MS Gothic and MS Mincho. but we have no these fonts. so that text is broken. Expected Results: use Japanese fonts which we have instead of MS fonts. Additional info: Sometimes we get those files. but we can't show it correctly until now. if our gnumeric can show it, we will get a benefit.
Created attachment 52345 [details] please apply this patch instead of current patch.
Created attachment 52346 [details] Sample Excel file
Please do NOT apply that patch it is completely inappropriate at that level. gnumeric/plugins/excel/ms-excel-read.c:get_substitute_font is that place to do that sort of mapping in 1.0 and that code has temporarilly moved to src/style.c:get_substitute_font in 1.1 However before 1.2 we'll rely on pango/XftConfig
Tagoh can you redo the patch as Jody described? I don't want to put in patches that upstream considers wrong.
Sure. I'll remake this patch. Thanks Jody.
Created attachment 53048 [details] fix a patch.
Jody here's another one
That looks much better. I'll add it to 1.0.6, and forward port it to 1.1 for now.
Hmm, as you wrote in source, this patch is also ad-hoc. I don't like a particular font name is hardcoded. for example, gnome-print supports Type1's alias name, but it doesn't support TTF's alias name, do it? Gnumeric now get some font info from gnome-print. so if gnome-print can do that, I think this problem will be fixed. However Gnumeric may get a lot of font names, but changing a font name by each users is important, I think.
I applied the patch.
Hmm, please don't apply gnumeric-0.67-excel95-ja.patch. we no longer need it. that patch bothers the new patch.
What remains to be done for this in Rawhide?
NEEDINFO, I don't know what to do with this bug. Is there a patch in the RPM that should be removed?
Yes, it's gnumeric-0.67-excel95-ja.patch. we should applied gnumeric-1.0.5-exceljpfonts.patch in order to replace it. old patch forces to change the font name in the excel plugin. so new patch can't work correctly. Removing gnumeric-0.67-excel95-ja.patch will re-fix this problem.
fixed in 1.0.9-1