Description of problem:
If SELinux is disabled, when slip.util.files.overwrite_safely is called with the default preserve_context=True, it fails because it cannot read the "security.selinux" xattr of the destination file. This makes it impossible to save the configuration in system-config-date.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
from slip.util.files import overwrite_safely
Traceback (most recent call last):
File "<stdin>", line 2, in <module>
File "/usr/lib/python2.6/site-packages/slip/util/files.py", line 179, in overwrite_safely
ret, ctx = selinux.getfilecon(path)
OSError: [Errno 61] No data available
The file is successfully written.
I seem to have misunderstood the possible return values of selinux.is_selinux_enabled():
Author: Nils Philippsen <firstname.lastname@example.org>
Date: Tue Aug 31 15:43:30 2010 +0200
fix overwrite_safely() if SELinux is disabled (#627788)
diff --git a/slip/util/files.py b/slip/util/files.py
index b248d17..1b2887d 100644
@@ -165,7 +165,7 @@ def overwrite_safely(path, content, preserve_mode=True, preserve_context=True):
exists = os.path.exists(path)
- if preserve_context and selinux.is_selinux_enabled() < 0:
+ if preserve_context and selinux.is_selinux_enabled() <= 0:
preserve_context = False
According to your comment on the Fedora update page:
mattmccutchen - 2010-08-27 00:44:12
I'm unable to test bug 615819 because bug 627788 prevents system-config-date from saving the configuration at all on my SELinux-disabled system. I tried downgrading to python-slip-0.2.11-1.fc13 and the same problem occurs, so it's not a regression; I'm not sure what changed since I initially filed bug 615819.
It may even be that something changed in libselinux/-python (but that doesn't really matter now).
python-slip-0.2.13-1.fc14 has been submitted as an update for Fedora 14.
python-slip-0.2.13-1.fc13 has been submitted as an update for Fedora 13.
python-slip-0.2.13-1.fc12 has been submitted as an update for Fedora 12.
python-slip-0.2.13-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
su -c 'yum --enablerepo=updates-testing update python-slip'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/python-slip-0.2.13-1.fc13
python-slip-0.2.13-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
python-slip-0.2.13-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
python-slip-0.2.13-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.