Spec URL: http://hannes.fedorapeople.org/jibx.spec SRPM URL: http://hannes.fedorapeople.org/jibx-1.2.2-1.fc13.src.rpm Description: JiBX is a framework for binding XML data to Java objects. It lets you work with data from XML documents using your own class structures.
I'll do the review
Worked a bit on it the spec url is still the same. SRPM URL: http://hannes.fedorapeople.org/jibx-1.2.2-2.fc13.src.rpm Fixed all rpmlint errors and used %{buildroot} to be consistent.
Few notes first: * you should run rpmlint on your spec files/SRPM/RPMs * Fedora guidelines are strict about bundling dependencies. And jibx archive has quite a few of them. Run: $ find -name '*.class' -exec rm -f '{}' \; $ find -name '*.jar' -exec rm -f '{}' \; this will cause your current build to fail because of missing BRs. I verified it can be built with Fedora packages, if you need help figuring out what BRs to add let me know * after doing previous you will have to do something like this for eclipse dependencies: plugin_file=`ls %{_libdir}/eclipse/dropins/jdt/plugins/org.eclipse.jdt.core_*jar` ln -s "$plugin_file" lib/org.eclipse.jdt.core.jar * package should be BuildArch:noarch * Are you sure about package Requires? Is and really necessary for package to work? I am guessing not. Similarly other libraries are probably not needed beside java. It's better to start with fewer Requires, even missing some because we'll find out. But it's hard to discover unneeded dependencies that will just make user's system bloated over time * You use sed in one place and perl in other to do the same thing, it's best to just use sed if it can do the job * build/docs/src should be removed prior to installing documentation, those are just files used to build it AFAIK If you need help sorting out those problems find me on IRC and we can do it step-by-step
One more important thing...this package is not public domain, it's BSD/ASL 1.1 licensed
Spec URL: http://hannes.fedorapeople.org/jibx.spec SRPM URL: http://hannes.fedorapeople.org/jibx-1.2.2-3.fc13.src.rpm I fixed most issues but I guess you already know that.
Ok fixed the rest: Spec URL: http://hannes.fedorapeople.org/jibx.spec SRPM URL: http://hannes.fedorapeople.org/jibx-1.2.2-4.fc13.src.rpm
jibx.noarch: W: invalid-license BSD/ASL 1.1 jibx.noarch: W: no-documentation jibx.noarch: W: class-path-in-manifest /usr/share/java/jibx/extras-1.2.2.jar jibx.noarch: W: class-path-in-manifest /usr/share/java/jibx/bind-1.2.2.jar jibx.noarch: W: class-path-in-manifest /usr/share/java/jibx/run-1.2.2.jar jibx-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Javanese jibx-javadoc.noarch: W: invalid-license BSD/ASL 1.1 jibx.src: W: invalid-license BSD/ASL 1.1 3 packages and 0 specfiles checked; 0 errors, 8 warnings. The license string should be "BSD and ASL 1.1" Class-path-in-manifest is there because of: <attribute name="Class-Path" ... lines in build/build.xml. These need to be patched out. This in turn will unfortunately make tests fails. We can discuss how to fix that on IRC again. Other: * This is not needed: > export OPT_JAR_LIST="`%{__cat} %{_sysconfdir}/ant.d/junit`" * You still have sed in the %build section (stax-api) * it is customary to leave blank lines between changelog versions and sections (your 2 file sections are merged) * Your Requires are still too big. Leave it at just java and jpackage-utils for now. * You should run for cycle in %install section for "schema" and "tools" subdirectory I know it sound like a lot of work (again), but you've done good job so far considering how much work this needs :-)
Ok I fixed nearly everything except the missing classpath in the build.xml. Spec URL: http://hannes.fedorapeople.org/jibx.spec SRPM URL: http://hannes.fedorapeople.org/jibx-1.2.2-5.fc13.src.rpm
Sorry, I forgot that I changed the folder structure of this webspace. Spec URL: http://hannes.fedorapeople.org/jibx/jibx.spec SRPM URL: http://hannes.fedorapeople.org/jibx/jibx-1.2.2-5.fc13.src.rpm
Unless I am missing something, jibx doesn't build now. That is due to the fact that after you removed Class-Path from manifests some tests don't know where to find libraries. This can be fixed by patching build.xml and adding few libraries to build-classpath for tests.
I made a patch so that those tests are able to find the jar-files and uploaded it again. I hope the patch is ok as it is my first one. At least it compiles flawlessly... Spec URL: http://hannes.fedorapeople.org/jibx/jibx.spec SRPM URL: http://hannes.fedorapeople.org/jibx/jibx-1.2.2-6.fc13.src.rpm
Sorry it took a while. Package is perfect now. Good work, hopefully it wasn't too painful :-) APPROVED
New Package SCM Request ======================= Package Name: jibx Short Description: Framework for binding XML data to Java objects Owners: hannes Branches: f13 f14 InitialCC:
Git done (by process-git-requests).
build in rawhide: http://koji.fedoraproject.org/koji/packageinfo?packageID=10920