Bug 627957 - condor_configure_pool doesn't ask for parameter value of included feature
Summary: condor_configure_pool doesn't ask for parameter value of included feature
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise MRG
Classification: Red Hat
Component: wallaby
Version: 1.3
Hardware: All
OS: Linux
medium
medium
Target Milestone: 2.0
: ---
Assignee: Robert Rati
QA Contact: Lubos Trilety
URL:
Whiteboard:
Depends On:
Blocks: 693778
TreeView+ depends on / blocked
 
Reported: 2010-08-27 13:38 UTC by Martin Kudlej
Modified: 2012-03-01 11:15 UTC (History)
7 users (show)

Fixed In Version: condor-wallaby-client-4.0-1
Doc Type: Bug Fix
Doc Text:
C: Using condor_configure_pool to add a feature that included a feature with a must_change parameter that doesn't have a value set. C: The condor_configure_pool tool would not prompt for a value for the must_change parameter F: The condor_configure_pool tool uses a new api call to better detect must_change params R: The condor_configure_pool tool will prompt for a value for the must_change parameter Release Note Entry: Previously, when condor_configure_pool was used to add a a feature containing a must_change parameter without a value, the condor_configure_pool did not prompt the user to supply the missing value. The condor_configure_pool now uses a new API call to detect must_change parameters and prompts the user in case of a missing must_change parameter.
Clone Of:
Environment:
Last Closed: 2011-06-23 15:39:35 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2011:0889 0 normal SHIPPED_LIVE Red Hat Enterprise MRG Grid 2.0 Release 2011-06-23 15:35:53 UTC

Description Martin Kudlej 2010-08-27 13:38:51 UTC
Description of problem:
condor_configure_pool --default-group -l
Group "Internal Default Group":
Group ID: 1
Name: Internal Default Group
Features (priority: name):
  0: NodeAccess
  1: Master
Parameters:
  ALLOW_WRITE = *
  CONDOR_HOST = 127.0.0.1
  ALLOW_READ = *
# condor_configure_pool --default-group -a -f ExecuteNodeDedicatedPreemption

Apply these changes [Y/n] ? 
Configuration applied

Create a named snapshot of this configuration [y/N] ? 

Activate the changes [y/N] ? Y
The configuration is not valid
Node: xxx
Unset necessary parameters:
  DEDICATEDSCHEDULER

Configuration not activated

ExecuteNodeDedicatedPreemption includes DedicatedResource and DedicatedResource has empty and required parameter DEDICATEDSCHEDULER.
But condor_configure_pool doesn't ask for value of DEDICATEDSCHEDULER.

Version-Release number of selected component (if applicable):
condor-wallaby-tools-3.4-1
wallaby-0.9.4-1
condor-wallaby-base-db-1.3-2

How reproducible:
100%

  
Actual results:
condor_configure_pool doesn't ask for parameter value of included feature

Expected results:
condor_configure_pool will ask for parameter value of included feature

Comment 4 Robert Rati 2011-02-24 14:44:25 UTC
ccp will now prompt for parameters from included features.

Fixed on master.

Comment 5 Robert Rati 2011-03-15 17:28:56 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
C: Using condor_configure_pool to add a feature that included a feature with a must_change parameter that doesn't have a value set.
C: The condor_configure_pool tool would not prompt for a value for the must_change parameter
F: The condor_configure_pool tool uses a new api call to better detect must_change params
R: The condor_configure_pool tool will prompt for a value for the must_change parameter

Comment 7 Lubos Trilety 2011-05-04 13:44:53 UTC
Successfully reproduces on rhel5 x86_64 with condor-wallaby-tools-3.9-3

# condor_configure_pool --default-group -a -f ExecuteNodeDedicatedPreemption

Apply these changes [Y/n] ? 
Configuration applied

Create a named snapshot of this configuration [y/N] ? 

Activate the changes [y/N] ? y
Activating configuration.  This may take a while, please be patient
The configuration is not valid
Node: hostname
Unset necessary parameters:
  DEDICATEDSCHEDULER

Configuration not activated

Comment 8 Lubos Trilety 2011-05-04 13:46:43 UTC
Tested with:
condor-wallaby-tools-4.0-6

Tested on:
RHEL5 i386,x86_64  - passed
RHEL6 i386,x86_64  - passed


# condor_configure_pool --default-group -a -f ExecuteNodeDedicatedPreemption

Apply these changes [Y/n] ? 
The following parameters need to be set for this configuration to be valid.
DEDICATEDSCHEDULER
Set these parameters now ? [y/N] 
Electing not to set these parameters now
WARNING: This configuration may not be able to be activated
...


>>> VERIFIED

Comment 9 Misha H. Ali 2011-05-30 06:06:54 UTC
    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1,4 +1,8 @@
 C: Using condor_configure_pool to add a feature that included a feature with a must_change parameter that doesn't have a value set.
 C: The condor_configure_pool tool would not prompt for a value for the must_change parameter
 F: The condor_configure_pool tool uses a new api call to better detect must_change params
-R: The condor_configure_pool tool will prompt for a value for the must_change parameter+R: The condor_configure_pool tool will prompt for a value for the must_change parameter
+
+Release Note Entry:
+
+Previously, when condor_configure_pool was used to add a a feature containing a must_change parameter without a value, the condor_configure_pool did not prompt the user to supply the missing value. The condor_configure_pool now uses a new API call to detect must_change parameters and prompts the user in case of a missing must_change parameter.

Comment 10 Misha H. Ali 2011-06-06 03:24:14 UTC
Technical note can be viewed in the release notes for 2.0 at the documentation stage here:

http://documentation-stage.bne.redhat.com/docs/en-US/Red_Hat_Enterprise_MRG/2.0/html-single/MRG_Release_Notes/index.html#tabl-MRG_Release_Notes-GRID_Update_Notes-RHM_Known_Issues

Comment 11 errata-xmlrpc 2011-06-23 15:39:35 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHEA-2011-0889.html


Note You need to log in before you can comment on or make changes to this bug.