Bug 627960 - condor_configuration_pool removes parameter which is required by another feature
Summary: condor_configuration_pool removes parameter which is required by another feature
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise MRG
Classification: Red Hat
Component: wallaby
Version: beta
Hardware: All
OS: Linux
medium
medium
Target Milestone: 1.3
: ---
Assignee: Robert Rati
QA Contact: MRG Quality Engineering
URL:
Whiteboard:
Depends On: 635979
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-08-27 13:51 UTC by Martin Kudlej
Modified: 2010-10-20 11:29 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-10-20 11:29:04 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Martin Kudlej 2010-08-27 13:51:31 UTC
Description of problem:
# condor_configure_pool --default-group -l
Group "Internal Default Group":
Group ID: 1
Name: Internal Default Group
Features (priority: name):
  0: NodeAccess
  1: Master
Parameters:
  ALLOW_WRITE = *
  CONDOR_HOST = 127.0.0.1
  ALLOW_READ = *

# condor_configure_pool --default-group -a -f HACentralManager
...

# condor_configure_pool --default-group -d -f HACentralManager

Apply these changes [Y/n] ?
Configuration applied

Create a named snapshot of this configuration [y/N] ?

Activate the changes [y/N] ? Y
The configuration is not valid
Node: xxx
Unset necessary parameters:
  CONDOR_HOST

Configuration not activated

CONDOR_HOST is part of Master and also HACentralManager.
If HACentralManager is removed, it removes also CONDOR_HOST and configuration is not anymore valid because CONDOR_HOST is required also by Master.

Version-Release number of selected component (if applicable):
condor-wallaby-tools-3.4-1
wallaby-0.9.4-1
condor-wallaby-base-db-1.3-2


How reproducible:
100%

  
Actual results:
condor_configuration_pool removes parameter which is required by another feature

Expected results:
condor_configuration_pool will not remove parameters which are required by another features

Comment 1 Robert Rati 2010-08-27 22:01:16 UTC
Issue was with detecting which must_change params should be cared about during a remove operation.

Fixed in:
condor-wallaby-tools-3.5-2

Comment 2 Martin Kudlej 2010-10-01 10:23:48 UTC
Tested with shared parameters 
ALLOW_ADMINISTRATOR: HACentralManager, Master
CONDOR_HOST: HACentralManager, Master
COLLECTOR_NAME: Collector, Master
ALLOW_NEGOTIATOR: HACentralManager, Negotiator
ALLOW_NEGOTIATOR_SCHEDD: BaseScheduler, HACentralManager
COLLECTOR_HOST: Collector, HACentralManager
JOB_HOOKS_PORT: JobHooks, LowLatency
SPOOL: JobQueueLocation, Scheduler
STARTD_JOB_EXPRS: ExecuteNode, ExecuteNodeDedicatedPreemption
KILL: DedicatedResource, ExecuteNode
PREEMPT: DedicatedResource, ExecuteNode
START: DedicatedResource, ExecuteNode
SUSPEND: DedicatedResource, ExecuteNode
STARTD_ATTRS: DedicatedResource, ExecuteNode
WANT_SUSPEND: DedicatedResource, ExecuteNode
WANT_VACATE: DedicatedResource, ExecuteNode
CONTINUE: DedicatedResource, ExecuteNode

on RHEL 5.5 x86_64/i386 with 
python-condorutils-1.4-5.el5
condor-wallaby-tools-3.6-5.el5
condor-wallaby-base-db-1.4-5.el5
condor-debuginfo-7.4.4-0.16.el5
condor-7.4.4-0.16.el5
condor-wallaby-client-3.6-5.el5
wallaby-0.9.18-2.el5

and it works. -->VERIFIED


Note You need to log in before you can comment on or make changes to this bug.