Bug 628482 - Review Request: python-zope-exceptions - Zope Exceptions
Summary: Review Request: python-zope-exceptions - Zope Exceptions
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Chen Lei
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-08-30 07:45 UTC by Robin Lee
Modified: 2010-09-01 05:45 UTC (History)
3 users (show)

Fixed In Version: python-zope-interface-3.6.1-3.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-09-01 05:45:01 UTC
Type: ---
Embargoed:
supercyper1: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Robin Lee 2010-08-30 07:45:31 UTC
Spec URL: http://cheeselee.fedorapeople.org/python-zope-exceptions.spec
SRPM URL: http://cheeselee.fedorapeople.org/python-zope-exceptions-3.6.1-1.fc13.src.rpm
Description:
This package contains exception interfaces and implementations which are so
general purpose that they don't belong in Zope application-specific packages.

$ rpmlint ./python-zope-exceptions.spec 
./python-zope-exceptions.spec: W: no-buildroot-tag
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

$ rpmlint ./python-zope-exceptions-3.6.1-1.fc13.src.rpm 
python-zope-exceptions.src: W: no-buildroot-tag
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint ./python-zope-exceptions-3.6.1-1.fc13.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 1 Chen Lei 2010-08-30 08:44:47 UTC
It seems this package don't actually depend on python-setuptools. 

Try:
find src -name "*.py" -exec grep setuptools {} \;

I also suggest to remove several lines which are only needed for F12 since F12 will be EOL after 3 months.

%if ! (0%{?fedora} > 12 || 0%{?rhel} > 5)
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")}
%endif

%install
rm -rf $RPM_BUILD_ROOT

%clean
rm -rf $RPM_BUILD_ROOT

Comment 2 Robin Lee 2010-08-30 12:58:52 UTC
3.6.1-2
SRPM URL:
http://cheeselee.fedorapeople.org/python-zope-exceptions-3.6.1-2.fc13.src.rpm

Changes:
- Remove %clean section
- Remove python-setuptools from requirements
- Remove definitions of Python-related macros


$ rpmlint ./python-zope-exceptions.spec 
./python-zope-exceptions.spec: W: no-cleaning-of-buildroot %install
./python-zope-exceptions.spec: W: no-cleaning-of-buildroot %clean
./python-zope-exceptions.spec: W: no-buildroot-tag
./python-zope-exceptions.spec: W: no-%clean-section
0 packages and 1 specfiles checked; 0 errors, 4 warnings.

$ rpmlint ./python-zope-exceptions-3.6.1-2.fc13.src.rpm 
python-zope-exceptions.src: W: no-cleaning-of-buildroot %install
python-zope-exceptions.src: W: no-cleaning-of-buildroot %clean
python-zope-exceptions.src: W: no-buildroot-tag
python-zope-exceptions.src: W: no-%clean-section
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

$ rpmlint ./python-zope-exceptions-3.6.1-2.fc13.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 3 Chen Lei 2010-08-30 13:44:49 UTC
md5sum zope.exceptions-3.6.1.zip
b735a62e1ef16e746764b4938a4d7926


This package is approved!

Comment 4 Robin Lee 2010-08-30 14:31:34 UTC
New Package SCM Request
=======================
Package Name: python-zope-exceptions
Short Description: Zope Exceptions
Owners: cheeselee
Branches: f13 f14
InitialCC:

Comment 5 Kevin Fenzi 2010-08-30 17:40:54 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2010-08-31 03:13:22 UTC
python-zope-interface-3.6.1-3.fc14,python-zope-testing-3.10.0-2.fc14,python-zope-exceptions-3.6.1-4.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/python-zope-interface-3.6.1-3.fc14,python-zope-testing-3.10.0-2.fc14,python-zope-exceptions-3.6.1-4.fc14

Comment 7 Fedora Update System 2010-09-01 05:44:52 UTC
python-zope-interface-3.6.1-3.fc14, python-zope-testing-3.10.0-2.fc14, python-zope-exceptions-3.6.1-4.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.