Spec URL: http://www.flyn.org/SRPMS/Mars.spec SRPM URL: http://www.flyn.org/SRPMS/Mars-4.0-1.fc14.src.rpm Description: MARS is a lightweight interactive development environment (IDE) for programming in MIPS assembly language, intended for educational-level use with Patterson and Hennessy's Computer Organization and Design
Builds but fails to install; looks like there's a typo: Error: Package: Mars-4.0-1.fc15.x86_64 (/Mars-4.0-1.fc15.x86_64) Requires: jpackage-util
Spec URL: http://www.flyn.org/SRPMS/Mars.spec SRPM URL: http://www.flyn.org/SRPMS/Mars-4.0-2.fc14.src.rpm Description: MARS is a lightweight interactive development environment (IDE) for programming in MIPS assembly language, intended for educational-level use with Patterson and Hennessy's Computer Organization and Design Fix jpackage-utils typo.
Quick look at the spec: * New version is available * Source0: should be normal URL, most probably: http://courses.missouristate.edu/KenVollmar/MARS/MARS_4_0_1_Oct2010/Mars_4_0_1.jar * clean section/buildroot definition and rm -rf in the beginning of %install is not needed anymore (unless you plan to do EPEL-5 build) * You should remove classpath from manifest before including it in output jar * instead of: install -Dpm 755 %{_sourcedir}/Mars $RPM_BUILD_ROOT/%{_bindir}/Mars do: install -Dpm 755 %{SOURCE1} $RPM_BUILD_ROOT/%{_bindir}/Mars
Oh, and %files should include %doc MARSlicense.txt
Spec URL: http://www.flyn.org/SRPMS/Mars.spec SRPM URL: http://www.flyn.org/SRPMS/Mars-4.0.1-1.fc14.src.rpm - New upstream version - Remove clean section - Use SOURCE1 to install - Add MARSlicense.txt - Remove classpath definition from MANIFEST.MF
Issues: * Version 4.1 is out. * As this is a gui application we need desktop file istalled as per http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files * setup not quiet - please add -q after the %setup call * mixed-use-of-spaces-and-tabs - please choose one and stick to it * package is pure java so it should be noarch this will prevent the empty debuginfo package problem too * wrong-file-end-of-line-encoding /usr/share/doc/Mars-4.0.1/MARSlicense.txt * class-class-path-in-manifest /usr/share/java/Mars.jarpath-in-manifest /usr/share/java/Mars.jar Sorry that this review is taking so long but we will get it in eventually.
Btw, you're sponsored correct?
He is: [17:49] <tibbs|h> fasinfo mikep [17:49] <zodbot> User: mikep, Name: None, email: mike, Creation: 2005-04-28, IRC Nick: , Timezone: None, Locale: None, Extension: 5100136, GPG key ID: None, Status: active [17:49] <zodbot> Approved Groups: cla_done fedorabugs packager cla_fedora (not that the privacy setting makes it all that easy to find).
Spec URL: http://www.flyn.org/SRPMS/Mars.spec SRPM URL: http://www.flyn.org/SRPMS/Mars-4.1-1.fc14.src.rpm - New upstream version - Replace tab with spaces - Make setup quiet - Add .desktop description - Use noarch
Quite fast response - I'll do the review :).
Hmm, this is stil using 4.0.1 sources not 4.1.
Spec URL: http://www.flyn.org/SRPMS/Mars.spec SRPM URL: http://www.flyn.org/SRPMS/Mars-4.1-2.fc14.src.rpm - Build 4.1 source
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [!] Rpmlint output: Mars.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/Mars-4.1/MARSlicense.txt Please fix. Mars.noarch: W: no-manual-page-for-binary Mars Not a problem. Mars.noarch: W: class-path-in-manifest /usr/share/java/Mars.jar Please fix. [x] Package is named according to the Package Naming Guidelines[1]. [x] Spec file name must match the base package name, in the format %{name}.spec. [x] Package meets the Packaging Guidelines[2]. [x] Package successfully compiles and builds into binary rpms. [!] Buildroot definition is not present Please remove it [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4]. [x] License field in the package spec file matches the actual license. License type: MIT [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [-] All independent sub-packages have license of their own [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5]. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore) [x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing) [x] Package contains code, or permissable content. [x] Fully versioned dependency in subpackages, if present. [x] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. [-] Javadoc documentation files are generated and included in -javadoc subpackage [-] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks) [x] Packages have proper BuildRequires/Requires on jpackage-utils [-] Javadoc subpackages have Require: jpackage-utils [-] Package uses %global not %define [-] If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...) [x] If source tarball includes bundled jar/class files these need to be removed prior to building [x] All filenames in rpm packages must be valid UTF-8. [x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details) [-] If package contains pom.xml files install it (including depmaps) even when building with ant [-] pom files has correct add_to_maven_depmap call which resolves to the pom file (use "JPP." and "JPP-" correctly) === Other suggestions === [-] If possible use upstream build method (maven/ant/javac) [x] Avoid having BuildRequires on exact NVR unless necessary [x] Package has BuildArch: noarch (if possible) [x] Latest version is packaged. [x] Reviewer should test that the package builds in mock. === Issues === 1.: W: wrong-file-end-of-line-encoding /usr/share/doc/Mars-4.1/MARSlicense.txt 2. W: class-path-in-manifest /usr/share/java/Mars.jar 3. Remvoe buildroot 4. It is up to you because this package doesn't really needs a javadoc subpackage but it's common practice to have a javadoc subpackage for every java package. I would not block the release on this but it would be good if it's there.
Ping, are you still working on it?
Yes. Can someone advise how to address issue (1) and (2) in comment #13? I am interested to see if there is a recommended technique.
Sure, (1) - See http://fedoraproject.org/wiki/Common_Rpmlint_issues#wrong-file-end-of-line-encoding (2) - you have the following line: jar cmf mainclass.txt Mars.jar PseudoOps.txt Config.properties Syscall.properties Settings.properties MARSlicense.txt mainclass.txt CreateMarsJar.bat Mars.java Mars.class docs help images mars When you pass the cmf switch the next parameter is the file used for MANIFEST.MF(i.e. mainclass.txt). Changing it to META-INF/MANIFEST.MF(i.e. the file you created) will fix the problem.
Spec URL: http://www.flyn.org/SRPMS/Mars.spec SRPM URL: http://www.flyn.org/SRPMS/Mars-4.1-3.fc14.src.rpm Address 1, 2 and 3 from comment #13.
Thanks, This package is APPROVED.
Remove FE-JAVASIG block, there is nothing more the SIG can do.
New Package SCM Request ======================= Package Name: Mars Short Description: An interactive development environment for programming in MIPS assembly language Owners: mikep Branches: f14 f15 InitialCC:
Git done (by process-git-requests).