Bug 629020 - "deliver" uses dotlocking despite Fedora patch
Summary: "deliver" uses dotlocking despite Fedora patch
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: dovecot
Version: 13
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Michal Hlavinka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-08-31 17:26 UTC by Jordan Russell
Modified: 2010-11-08 22:46 UTC (History)
1 user (show)

Fixed In Version: dovecot-1.2.15-2.fc12
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-11-08 22:44:28 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Jordan Russell 2010-08-31 17:26:17 UTC
Description of problem:
Fedora patches master-settings.c to disable dotlocking on mboxes by default:

-       MEMBER(mbox_write_locks) "dotlock fcntl",
+       MEMBER(mbox_write_locks) "fcntl",

The patch, however, does not have an effect on the "deliver" program. It still attempts to use dotlocking by default, which results in errors if the user doesn't have write access to /var/mail. AFAICT, this is because "deliver" uses its own config parsing code which does not make use of master-settings.c.

To correct this, I believe src/lib-storage/index/mbox/mbox-lock.c also needs to be patched as follows:

-#define DEFAULT_WRITE_LOCK_METHODS "dotlock fcntl"
+#define DEFAULT_WRITE_LOCK_METHODS "fcntl"


Version-Release number of selected component (if applicable):
dovecot-1.2.13-1.fc13.i686

Steps to Reproduce:
1. Configure your MTA to use dovecot's "deliver" as the local delivery agent.
2. Send mail to a local user.
  
Actual results:
/var/log/maillog:
dovecot: deliver(username): file_dotlock_create(/var/mail/username) failed: Permission denied (euid=1234(username) egid=1234(username) missing +w perm: /var/mail) (set mail_privileged_group=mail)

Expected results:
It shouldn't be using dotlocking.

Comment 1 Michal Hlavinka 2010-10-25 15:29:30 UTC
Ooop, this slipped out of my todo list, sorry it took so long :(
Thanks for reporting this. Should be fixed in next dovecot update

Comment 2 Fedora Update System 2010-10-25 15:48:55 UTC
dovecot-1.2.15-2.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/dovecot-1.2.15-2.fc13

Comment 3 Fedora Update System 2010-10-25 15:49:01 UTC
dovecot-1.2.15-2.fc12 has been submitted as an update for Fedora 12.
https://admin.fedoraproject.org/updates/dovecot-1.2.15-2.fc12

Comment 4 Fedora Update System 2010-10-27 22:40:54 UTC
dovecot-1.2.15-2.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update dovecot'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/dovecot-1.2.15-2.fc12

Comment 5 Fedora Update System 2010-11-08 22:44:23 UTC
dovecot-1.2.15-2.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 6 Fedora Update System 2010-11-08 22:46:45 UTC
dovecot-1.2.15-2.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.