SPEC: http://pbrobinson.fedorapeople.org/meego-panel-myzone.spec SRPM: http://pbrobinson.fedorapeople.org/meego-panel-myzone-0.2.5-1.fc14.src.rpm Description: The MeeGo panel for MyZone. MyZone allows you to see that status of friends on social networks, chekck what you have on in your calendar, and more. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2440128 Original review: https://bugzilla.redhat.com/show_bug.cgi?id=518447
I'll review it
FTBFS on F-14 - is this package designed only for F-15? http://koji.fedoraproject.org/koji/taskinfo?taskID=2490065 Koji build for F-15: http://koji.fedoraproject.org/koji/taskinfo?taskID=2490068 REVIEW: Legend: + = PASSED, - = FAILED, 0 = Not Applicable + rpmlint not silent but its messages can be safely ignored in this case: Sulaco ~/rpmbuild/SPECS: rpmlint ~/Desktop/meego-panel-myzone-* meego-panel-myzone.x86_64: W: spelling-error %description -l en_US chekck -> check, Chekhov, Cheka meego-panel-myzone.x86_64: W: self-obsoletion moblin-panel-myzone < 0.2.6 obsoletes moblin-panel-myzone = 0.2.5-1.fc15 meego-panel-myzone.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/meego-panel-myzone.desktop meego-panel-myzone.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/meego-panel-myzone.schemas meego-panel-myzone-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 5 warnings. Sulaco ~/rpmbuild/SPECS: + The package is named according to the Package Naming Guidelines . + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines . + The package is licensed with a Fedora approved license and meets the Licensing Guidelines . - The License field in the package spec file must match the actual license! Proper license tag is LGPLv2+ + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. +/- The package successfully compiles and builds into binary rpms on at least one primary architecture but only in Rawhide. + All build dependencies are listed in BuildRequires. + The spec file handles locales properly. + The package calls ldconfig in %post and %postun. + The package does NOT bundle copies of system libraries. 0 The package is not designed to be relocatable. The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files + Anything, the package includes as %doc, does not affect the runtime of the application. + Header files are packaged in a -devel package. 0 No static libraries + The library file that end in .so (without suffix) packaged in a -devel package. + The devel package requires the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} + The package does NOT contain any .la libtool archives. +/- The package includes a %{name}.desktop file, and that file should properly installed with desktop-file-install in the %install section but instead it is placed into %{_sysconfdir}/xdg/autostart/meego-panel-myzone.desktop %{_datadir}/mutter-meego/panels/meego-panel-myzone.desktop I don't know too much about Meego - is it intentional? Also there is one more *.desktop file: /usr/share/applications/myzone.desktop This one should be validated in the %install section using desktop-file-validate ( https://fedoraproject.org/wiki/Packaging/Guidelines#desktop ) + Packages does not own files or directories already owned by other packages. + All filenames in rpm packages are valid UTF-8. So, please: * Fix license tag * Explain whether this package is designed only for Rawhide or not * Add validation for desktop file(s) (at least for one, stored in /usr/share/applications )
> So, please: > > * Fix license tag Fixed. They seem to change this constantly! > * Explain whether this package is designed only for Rawhide or not Currently it will only build on rawhide as MeeGo 1.0 is currently in F-14. To build it requires newer dependencies that will need to be tagged and built. Its possible I might update F-14 to MeeGo 1.1 but at the moment F-14 is targeting MeeGo 1.0. > * Add validation for desktop file(s) (at least for one, stored in > /usr/share/applications ) Done. Seems to work currently but with some minor errors. SPEC: as above SRPM: http://pbrobinson.fedorapeople.org/meego-panel-myzone-0.2.5-2.fc14.src.rpm
Ok, good - this package is APPROVED.
Thanks! New Package GIT Request ======================= Package Name: meego-panel-myzone Short Description: MeeGo Panel for display of current social information Owners: pbrobinson Branches: F-14 InitialCC:
Git done (by process-git-requests).
Built and headed to rawhide