Spec URL: http://github.com/remicollet/remirepo/raw/master/mysql-workbench/mysql-workbench.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/mysql-workbench-5.2.27-1.remi.src.rpm Description: MySQL Workbench provides Database administrators and developers an integrated tools environment for: * Database Design and Modeling * SQL Development (replacing MySQL Query Browser) * Database Administration (replacing MySQL Administrator) All bundled and available as shared libs have been removed. Exception for scintilla/silvercity which are patched version or for which upstream doesn't provides shared lib and doesn't care about ABI stability have been discussed on devel ML.
*** Bug 521152 has been marked as a duplicate of this bug. ***
If needed, mysql-connector-c++ package are available : https://admin.fedoraproject.org/updates/mysql-connector-c++-1.1.0-0.2.bzr888.fc13 https://admin.fedoraproject.org/updates/mysql-connector-c++-1.1.0-0.2.bzr888.fc14
I try to build it for rawhide on Koji. It failed. Koji Result: http://koji.fedoraproject.org/koji/taskinfo?taskID=2468891 I build mysql-workbench on f13 x86_64. I use rpmlint to test RPM. It shows several warnings: [fedora@fedora-desktop ~]$ rpmlint /home/fedora/rpmbuild/RPMS/x86_64/mysql-workbench-5.2.27-1.fc13.x86_64.rpm mysql-workbench.x86_64: W: devel-file-in-non-devel-package /usr/lib64/mysql-workbench/libwbscintilla.so mysql-workbench.x86_64: W: devel-file-in-non-devel-package /usr/lib64/mysql-workbench/libmforms.so mysql-workbench.x86_64: W: devel-file-in-non-devel-package /usr/lib64/mysql-workbench/libmdcanvas.so mysql-workbench.x86_64: W: devel-file-in-non-devel-package /usr/lib64/mysql-workbench/libvsqlitepp.so mysql-workbench.x86_64: W: devel-file-in-non-devel-package /usr/lib64/mysql-workbench/libsqlide.so mysql-workbench.x86_64: W: devel-file-in-non-devel-package /usr/lib64/mysql-workbench/liblinux_utilities.so mysql-workbench.x86_64: W: devel-file-in-non-devel-package /usr/lib64/mysql-workbench/libmdcanvasgtk.so mysql-workbench.x86_64: W: devel-file-in-non-devel-package /usr/lib64/mysql-workbench/libcdbc.so mysql-workbench.x86_64: W: devel-file-in-non-devel-package /usr/lib64/mysql-workbench/libgrt.so mysql-workbench.x86_64: W: devel-file-in-non-devel-package /usr/lib64/mysql-workbench/libsqlparser.so mysql-workbench.x86_64: W: devel-file-in-non-devel-package /usr/lib64/mysql-workbench/libwbbase.so mysql-workbench.x86_64: W: devel-file-in-non-devel-package /usr/lib64/mysql-workbench/libwbpublic.so mysql-workbench.x86_64: W: no-manual-page-for-binary mysql-workbench-bin mysql-workbench.x86_64: W: no-manual-page-for-binary mysql-workbench 1 packages and 0 specfiles checked; 0 errors, 14 warnings. [fedora@fedora-desktop ~]$ You should add them into the package if mysql-workbench has manuals. If it has not, you can ignore these warnings. The other warning, I do not know whether these libraries should be moved to devel package. Are they for writing mysql-workbench plugin? Or Does mysql-workbench rely on these libraries?
Koji build for Fedora 13 succeeded. http://koji.fedoraproject.org/koji/taskinfo?taskID=2469421
> no-manual-page-for.. No man in provided by upstream. > devel-file-in-non-devel-package This library are dlopen by workbench. No -devel are needed. For now, plugins are only python / lua script. No API provided. I will look at rawhide build issue ASAP.
(In reply to comment #5) > > no-manual-page-for.. > No man in provided by upstream. > > > devel-file-in-non-devel-package > This library are dlopen by workbench. > No -devel are needed. For now, plugins are only python / lua script. No API > provided. > So I feels this report looks quite strange. I do not trust all the things of rpmlint in this report. > I will look at rawhide build issue ASAP. Waiting for your good news.
F-14/rawhide build issue is fixed: http://github.com/remicollet/remirepo/commit/85aa564c7f4f02f09fec299926e3d99132ff1e30 http://github.com/remicollet/remirepo/commit/0c0a5a2b0e8b54a414bcc89ff5f6e23d78982473 Koji scratch build (dist-f14) http://koji.fedoraproject.org/koji/taskinfo?taskID=2475015 Spec URL: http://github.com/remicollet/remirepo/raw/master/mysql-workbench/mysql-workbench.spec New SRPM: http://rpms.famillecollet.com/SRPMS/mysql-workbench-5.2.27-2.remi.src.rpm This bug is, of course, reported upstream http://lists.mysql.com/gui-tools/2202
Anyone except me approve CJK bug in Linux platform? I found it, but I can not make sure it. Maybe the bundled library sinctilla cause the problem.
I found there are some bundled libraries that still exist in the source code, such as tinyxml and vsqlite++. Should we remove them? Tinyxml stays at Fedora repository. But vsqlite++ does not. Or are they used for Windows build or Mac build? And MySQL Workbench 5.2.28 has released. We should update it.
I'm already on 5.2.28: This new version requires a new mysql-connector snapshot Here are the build F14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2479663 F13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2479744 Here is the change : http://github.com/remicollet/remirepo/commit/c032bcb07bd10a31fad9bb0282b02d59ceaed5a8 http://github.com/remicollet/remirepo/commit/ee81d71acd77e600d79eec1704e07fd133262bc4 Spec URL: http://github.com/remicollet/remirepo/raw/master/mysql-workbench/mysql-workbench.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/mysql-workbench-5.2.28-1.remi.src.rpm I'm also wating for upstream about python issue http://lists.mysql.com/gui-tools/2204
(In reply to comment #8) > Anyone except me approve CJK bug in Linux platform? > > I found it, but I can not make sure it. Maybe the bundled library sinctilla > cause the problem. CJK ? do you mean http://en.wikipedia.org/wiki/CJK I think such a bug souldn't block a review, but should be, at least, reported upstream. (In reply to comment #9) > tinyxml and vsqlite++. :( it seems I have miss that ones...
(In reply to comment #11) > (In reply to comment #8) > > Anyone except me approve CJK bug in Linux platform? > > > > I found it, but I can not make sure it. Maybe the bundled library sinctilla > > cause the problem. > > CJK ? do you mean http://en.wikipedia.org/wiki/CJK > > I think such a bug souldn't block a review, but should be, at least, reported > upstream. Yes,I mean CJK is Chinese, Japanese and Korean fonts. I will report upstream soon. > > (In reply to comment #9) > > tinyxml and vsqlite++. > > :( it seems I have miss that ones... I also find out library/canvas directory. We need to check whether it is a bundled library. If vsqlite++ is needed, we have to open a new review request for it.
One little step : use system tinyxml http://github.com/remicollet/remirepo/commit/35b801ad8ebd897ffbcfe78787d002ea9de0c9df
(In reply to comment #13) > One little step : use system tinyxml > > http://github.com/remicollet/remirepo/commit/35b801ad8ebd897ffbcfe78787d002ea9de0c9df I have tested your new spec. I successfully built it on my local Fedora 13. But on koji it failed because the latest mysql-connector-c++ does not push to the repository. http://koji.fedoraproject.org/koji/taskinfo?taskID=2488868 Should vsplite++ be separated from mysql-workbench? The project looks dead. The latest update was on Octorber, 2006.
New mysql-connector-c++ is only available in rawhide (will require a buildroot exception, which doesn't seems a good practice for a review) Yes, I think vsqlite++ should not be separated (I have try to work on it) - upstream dead - no shared lib build provided (and the sources looks awful, merges with the sqlite-3.3.4 sources for 0.2, use a bundled and obsolete scons version for 0.3) I really don't want to maintain such a package and prefer we consider "MySQL" as the upstream for this lib and let them fix it if needed.
OK. Waiting that bodhi pushes the latest mysql-connector-c++ to repository. I think I can approve the request.
Some minor issues: It'll be better to use a mirror URL(e.g. ftp://sunsite.informatik.rwth-aachen.de/pub/mirror/www.mysql.com/Downloads/MySQLGUITools/mysql-workbench-gpl-5.2.28-src.tar.gz) instead of incomplete Source URL, so that we can use spectool to down and verify source file. I also suggest to use vitual provides: libGL-devel instead of mesa-libGL-devel. See rpm -q --whatprovides libGL-devel Is BuildRequires: uuid-devel really needed for mysql-workbench? It seems BR: libuuid-devel is enough for mysql-workbench. BuildRequires: lua-devel can be removed from spec, BuildRequires: lua-devel >= 5.1 is enough. Requires(post): desktop-file-utilsRequires(postun): desktop-file-utils is only need for EPEL 4. See https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database
BuildRequires: libglade2-devel is also useless. FYI, mysql-connector-c++ 1.1 GA is already released. Can we use formal release instead of bzr snapshot now?
Created attachment 449933 [details] mysql-workbench.spec I edited the spec file. I will test it on Koji soon. Now It is too slow to upload SRPM to koji in my campus network.
Created attachment 449934 [details] A new spec for MySQL Workbench Sorry, forget to remove one of libglade2-devel. I upload a new one.
(In reply to comment #18) > FYI, mysql-connector-c++ 1.1 GA is already released. Can we use formal release > instead of bzr snapshot now? No... :( The bzr895 is a post 1.1.0 version snapshot, with a new fonction used by MW which is not available in official 1.1.0. Yes this is a packager nightmare...
> It'll be better to use a mirror URL yes, why not. > desktop-file-utilsRequires Removed as I don't plan to build this for EL-4 ;) > Is BuildRequires: uuid-devel really needed for mysql-workbench? It seems BR: libuuid-devel is enough for mysql-workbench. Only required for fedora < 12 (before the libuuid split) > BuildRequires: lua-devel can be removed from spec yes > libglade2-devel yes http://github.com/remicollet/remirepo/commit/eeaab108850261e3c45025653517a9182601d684 Rawhide repo seems broken... :( http://koji.fedoraproject.org/koji/taskinfo?taskID=2492109 (nothing with MW, just a perl broken dep.)
(In reply to comment #22) > > Is BuildRequires: uuid-devel really needed for mysql-workbench? It seems BR: > libuuid-devel is enough for mysql-workbench. > Only required for fedora < 12 (before the libuuid split) But F-11 branch on Koji has been turned off for a long time. I think uuid-devel can be removed.
(In reply to comment #23) > But F-11 branch on Koji has been turned off for a long time. I think uuid-devel > can be removed. Yes, but i prefer to keep conditional stuff to be able to rebuild it for f11, even if this is not for official repository.
OK. I can not find out you do not push mysql-connector-c++-1.1.0-bzr895 to bodhi for F-13 and F-14. Could you push it now? We can not test to build mysql-workbench on koji. Is rawhide buildroot fixed? I am waiting a new correct build on koji. If we build mysql-workbench on koji, I think I can approve it.
Ticket open for buildroot exception https://fedorahosted.org/rel-eng/ticket/4146 Koji scratch build in rawhide (just launch, can't wait for the result) http://koji.fedoraproject.org/koji/taskinfo?taskID=2500945
OK, All the things has done. I approve it.
Thanks for the review. New Package SCM Request ======================= Package Name: mysql-workbench Short Description: A MySQL visual database modeling, administration and querying tool Owners: remi Branches: f13 f14 el6 InitialCC:
Git done (by process-git-requests).
mysql-workbench-5.2.28-3.fc14,mysql-connector-c++-1.1.0-0.3.bzr895.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/mysql-workbench-5.2.28-3.fc14,mysql-connector-c++-1.1.0-0.3.bzr895.fc14
mysql-workbench-5.2.28-3.fc13,mysql-connector-c++-1.1.0-0.3.bzr895.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/mysql-workbench-5.2.28-3.fc13,mysql-connector-c++-1.1.0-0.3.bzr895.fc13
mysql-workbench-5.2.28-3.fc14, mysql-connector-c++-1.1.0-0.3.bzr895.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update mysql-workbench mysql-connector-c++'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/mysql-workbench-5.2.28-3.fc14,mysql-connector-c++-1.1.0-0.3.bzr895.fc14
mysql-workbench-5.2.29-1.fc13, mysql-connector-c++-1.1.0-0.3.bzr895.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
mysql-workbench-5.2.29-1.fc14, mysql-connector-c++-1.1.0-0.4.bzr895.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.