Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
For bugs related to Red Hat Enterprise Linux 5 product line. The current stable release is 5.10. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 629634

Summary: add pr_*(), netdev_*(), netif_*() printk helper macros
Product: Red Hat Enterprise Linux 5 Reporter: Michal Schmidt <mschmidt>
Component: kernelAssignee: Michal Schmidt <mschmidt>
Status: CLOSED ERRATA QA Contact: Network QE <network-qe>
Severity: medium Docs Contact:
Priority: low    
Version: 5.6CC: dtian, kzhang
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-01-13 21:14:43 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
proposed patches (4, in mbox)
none
additional iw_cxgb3 fix none

Description Michal Schmidt 2010-09-02 14:47:26 UTC
We should add pr_*(), netdev_*(), netif_*() to common kernel headers to simplify driver backports and to avoid code duplication.

At least vxge, sfc, bnx2x drivers will use them.

drivers/edac includes a private copy of pr_*() which can be removed. 3 more drivers have their own pr_err().

Comment 1 RHEL Program Management 2010-09-02 14:59:50 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 2 Michal Schmidt 2010-09-02 15:00:38 UTC
Created attachment 442647 [details]
proposed patches (4, in mbox)

Comment 3 Michal Schmidt 2010-09-02 15:58:05 UTC
Created attachment 442658 [details]
additional iw_cxgb3 fix

Comment 10 Jarod Wilson 2010-09-10 21:41:16 UTC
in kernel-2.6.18-219.el5
You can download this test kernel from http://people.redhat.com/jwilson/el5

Detailed testing feedback is always welcomed.

Comment 14 Dayong Tian 2010-12-06 03:06:28 UTC
Since we just added/corrected log(debug) usages of NIC drivers, I just did code review with kernel 2.6.18-235.el5.
Those patches were included and applied in kernel 2.6.18-235.el5:

[root@intel-s3e8132-01 SPECS]# grep 629634 kernel-2.6.spec
- [misc] netdevice: add printk helpers for net drivers (Michal Schmidt) [629634]
- [misc] drivers: remove private definitions of pr_* macros (Michal Schmidt) [629634]
- [misc] kernel: add pr_* family of printk helper macros (Michal Schmidt) [629634]
- [infiniband] iw_cxgb3: always define states[] (Michal Schmidt) [629634]
- [net] ifb: fix syntax error in pr_debug usage (Michal Schmidt) [629634]

[root@intel-s3e8132-01 SPECS]# grep -i "Patch25597" kernel-2.6.spec
Patch25597: linux-2.6-misc-netdevice-add-printk-helpers-for-net-drivers.patch
%patch25597 -p1

[root@intel-s3e8132-01 SPECS]# grep -i "Patch25596" kernel-2.6.spec
Patch25596: linux-2.6-misc-drivers-remove-private-definitions-of-pr_-macros.patch
%patch25596 -p1

[root@intel-s3e8132-01 SPECS]# grep -i "Patch25595" kernel-2.6.spec
Patch25595: linux-2.6-misc-kernel-add-pr_-family-of-printk-helper-macros.patch
%patch25595 -p1

[root@intel-s3e8132-01 SPECS]# grep -i "Patch25594" kernel-2.6.spec
Patch25594: linux-2.6-infiniband-iw_cxgb3-always-define-states.patch
%patch25594 -p1

[root@intel-s3e8132-01 SPECS]# grep -i "Patch25593" kernel-2.6.spec
Patch25593: linux-2.6-net-ifb-fix-syntax-error-in-pr_debug-usage.patch
%patch25593 -p1

Comment 16 errata-xmlrpc 2011-01-13 21:14:43 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0017.html