Bug 629873 - Review Request: gnome-video-effects - Collection of GStreamer video effects
Summary: Review Request: gnome-video-effects - Collection of GStreamer video effects
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Matthias Clasen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-09-03 07:30 UTC by Yanko Kaneti
Modified: 2010-10-05 16:34 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-10-05 16:34:28 UTC
Type: ---
Embargoed:
mclasen: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Yanko Kaneti 2010-09-03 07:30:46 UTC
Spec URL: http://declera.com/~yaneti/gnome-video-effects/gnome-video-effects.spec
SRPM URL: http://declera.com/~yaneti/gnome-video-effects/gnome-video-effects-0.1.0-1.fc15.src.rpm
Description: A collection of GStreamer effects to be used in different GNOME Modules.

gnome-video-effects.noarch: W: devel-file-in-non-devel-package /usr/share/pkgconfig/gnome-video-effects.pc
gnome-video-effects.src: W: no-cleaning-of-buildroot %install
gnome-video-effects.src: W: no-cleaning-of-buildroot %clean
gnome-video-effects.src: W: no-buildroot-tag
gnome-video-effects.src: W: no-%clean-section
2 packages and 0 specfiles checked; 0 errors, 5 warnings.

Comment 1 Yanko Kaneti 2010-09-03 07:33:18 UTC
mclasen needed this adding cc

Comment 2 Matthias Clasen 2010-09-26 00:13:29 UTC
builds fine in mock.

rpmlint output:
 rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm
gnome-video-effects.noarch: W: devel-file-in-non-devel-package /usr/share/pkgconfig/gnome-video-effects.pc
gnome-video-effects.src: W: no-cleaning-of-buildroot %install
gnome-video-effects.src: W: no-cleaning-of-buildroot %clean
gnome-video-effects.src: W: no-buildroot-tag
gnome-video-effects.src: W: no-%clean-section
2 packages and 0 specfiles checked; 0 errors, 5 warnings.

All these are bugs in rpmlint

Comment 3 Matthias Clasen 2010-09-26 00:31:32 UTC
package name: ok
spec file name: ok
packaging guidelines: ok, clearly better to have the pc file in the main package here
license: ok
license file: ok
license field: ok
spec file language: ok
spec file readability: excellent
upstream sources: ok
buildable: ok
ExcludeArch: ok
BuildRequires: ok
locale handling: ok
ldconfig: ok
system libraries: ok
relocatable: ok
duplicate files: ok
file permissions: ok
macro use: ok
content: permissible
large docs: ok
%doc content: ok
headers: ok
static libs: ok
shared libs: ok
devel deps: ok
libtool archives: ok
gui apps: ok
directory ownership: ok
utf8 filenames: ok

One thing I wonder about: do we need any dependencies for the gstreamer plugins that are referred to in the effects ? Eg
PipelineDescription=frei0r-filter-sobel
in sobel.effect

Or do apps like cheese handle the absence of filters nicely (ie hide the effect unless all required plugins are present) ?

Anyway, the package is fine, 

APPROVED.

Comment 4 Yanko Kaneti 2010-09-26 08:40:20 UTC
New Package SCM Request
=======================
Package Name: gnome-video-effects
Short Description: Collection of GStreamer video effects
Owners: yaneti
Branches: f13 f14
InitialCC:

Comment 5 Kevin Fenzi 2010-09-26 18:49:59 UTC
Git done (by process-git-requests).

Comment 6 Yanko Kaneti 2010-09-27 07:03:17 UTC
Thanks.
Builds done. Updates submitted.

Comment 7 Yanko Kaneti 2010-10-05 16:34:28 UTC
Landed in dist-f14 , will land in F13 updates soon. Closing.


Note You need to log in before you can comment on or make changes to this bug.