Spec URL: http://declera.com/~yaneti/gnome-video-effects/gnome-video-effects.spec SRPM URL: http://declera.com/~yaneti/gnome-video-effects/gnome-video-effects-0.1.0-1.fc15.src.rpm Description: A collection of GStreamer effects to be used in different GNOME Modules. gnome-video-effects.noarch: W: devel-file-in-non-devel-package /usr/share/pkgconfig/gnome-video-effects.pc gnome-video-effects.src: W: no-cleaning-of-buildroot %install gnome-video-effects.src: W: no-cleaning-of-buildroot %clean gnome-video-effects.src: W: no-buildroot-tag gnome-video-effects.src: W: no-%clean-section 2 packages and 0 specfiles checked; 0 errors, 5 warnings.
mclasen needed this adding cc
builds fine in mock. rpmlint output: rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm gnome-video-effects.noarch: W: devel-file-in-non-devel-package /usr/share/pkgconfig/gnome-video-effects.pc gnome-video-effects.src: W: no-cleaning-of-buildroot %install gnome-video-effects.src: W: no-cleaning-of-buildroot %clean gnome-video-effects.src: W: no-buildroot-tag gnome-video-effects.src: W: no-%clean-section 2 packages and 0 specfiles checked; 0 errors, 5 warnings. All these are bugs in rpmlint
package name: ok spec file name: ok packaging guidelines: ok, clearly better to have the pc file in the main package here license: ok license file: ok license field: ok spec file language: ok spec file readability: excellent upstream sources: ok buildable: ok ExcludeArch: ok BuildRequires: ok locale handling: ok ldconfig: ok system libraries: ok relocatable: ok duplicate files: ok file permissions: ok macro use: ok content: permissible large docs: ok %doc content: ok headers: ok static libs: ok shared libs: ok devel deps: ok libtool archives: ok gui apps: ok directory ownership: ok utf8 filenames: ok One thing I wonder about: do we need any dependencies for the gstreamer plugins that are referred to in the effects ? Eg PipelineDescription=frei0r-filter-sobel in sobel.effect Or do apps like cheese handle the absence of filters nicely (ie hide the effect unless all required plugins are present) ? Anyway, the package is fine, APPROVED.
New Package SCM Request ======================= Package Name: gnome-video-effects Short Description: Collection of GStreamer video effects Owners: yaneti Branches: f13 f14 InitialCC:
Git done (by process-git-requests).
Thanks. Builds done. Updates submitted.
Landed in dist-f14 , will land in F13 updates soon. Closing.