Spec URL: http://benboeckel.net/packaging/ghc-MemoTrie/ghc-MemoTrie.spec SRPM URL: http://benboeckel.net/packaging/ghc-MemoTrie/ghc-MemoTrie-0.4.7-1.fc14.src.rpm Description: MemoTrie provides a basis for memoized functions over some domains, using tries. % lintmock fedora-14-x86_64-bb ghc-MemoTrie.src: W: spelling-error Summary(en_US) Trie -> Trier, Teri, Tree ghc-MemoTrie.src: W: spelling-error %description -l en_US memoized -> memorized, memorialized, memorize ghc-MemoTrie.src: W: strange-permission ghc-MemoTrie.spec 0640L ghc-MemoTrie.src: W: strange-permission MemoTrie-0.4.7.tar.gz 0640L ghc-MemoTrie.x86_64: W: spelling-error Summary(en_US) Trie -> Trier, Teri, Tree ghc-MemoTrie.x86_64: W: spelling-error %description -l en_US memoized -> memorized, memorialized, memorize ghc-MemoTrie.x86_64: W: no-documentation ghc-MemoTrie-devel.x86_64: W: spelling-error Summary(en_US) Trie -> Trier, Teri, Tree ghc-MemoTrie-devel.x86_64: W: spelling-error %description -l en_US memoized -> memorized, memorialized, memorize ghc-MemoTrie-prof.x86_64: E: devel-dependency ghc-MemoTrie-devel ghc-MemoTrie-prof.x86_64: W: spelling-error %description -l en_US memoized -> memorized, memorialized, memorize ghc-MemoTrie-prof.x86_64: W: no-documentation ghc-MemoTrie-prof.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ghc-6.12.3/MemoTrie-0.4.7/libHSMemoTrie-0.4.7_p.a 4 packages and 0 specfiles checked; 1 errors, 12 warnings.
Latest version is 0.4.9 btw.
Spec URL: http://benboeckel.net/packaging/ghc-MemoTrie/ghc-MemoTrie.spec SRPM URL: http://benboeckel.net/packaging/ghc-MemoTrie/ghc-MemoTrie-0.4.9-1.fc14.src.rpm % lintmock fedora-14-x86_64-bb ghc-MemoTrie.src: W: spelling-error Summary(en_US) Trie -> Trier, Teri, Tree ghc-MemoTrie.src: W: spelling-error %description -l en_US memoized -> memorized, memorialized, memorize ghc-MemoTrie.src: W: strange-permission MemoTrie-0.4.9.tar.gz 0640L ghc-MemoTrie.src: W: strange-permission ghc-MemoTrie.spec 0640L ghc-MemoTrie.x86_64: W: spelling-error Summary(en_US) Trie -> Trier, Teri, Tree ghc-MemoTrie.x86_64: W: spelling-error %description -l en_US memoized -> memorized, memorialized, memorize ghc-MemoTrie-devel.x86_64: W: spelling-error Summary(en_US) Trie -> Trier, Teri, Tree ghc-MemoTrie-devel.x86_64: W: spelling-error %description -l en_US memoized -> memorized, memorialized, memorize ghc-MemoTrie-prof.x86_64: E: devel-dependency ghc-MemoTrie-devel ghc-MemoTrie-prof.x86_64: W: spelling-error %description -l en_US memoized -> memorized, memorialized, memorize ghc-MemoTrie-prof.x86_64: W: no-documentation ghc-MemoTrie-prof.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ghc-6.12.3/MemoTrie-0.4.9/libHSMemoTrie-0.4.9_p.a 4 packages and 0 specfiles checked; 1 errors, 11 warnings.
[+]MUST: rpmlint must be run on every package. The output should be posted in the review. rpmlint -i ghc-MemoTrie-*.rpm ../ghc-MemoTrie.spec ghc-MemoTrie.src: W: spelling-error Summary(en_US) Trie -> Trier, Teri, Tree The value of this tag appears to be misspelled. Please double-check. ghc-MemoTrie.src: W: spelling-error %description -l en_US memoized -> memorized, memorialized, memorize The value of this tag appears to be misspelled. Please double-check. ghc-MemoTrie.src: W: strange-permission MemoTrie-0.4.9.tar.gz 0640L A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. ghc-MemoTrie.src: W: strange-permission ghc-MemoTrie.spec 0640L A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. ghc-MemoTrie.x86_64: W: spelling-error Summary(en_US) Trie -> Trier, Teri, Tree The value of this tag appears to be misspelled. Please double-check. ghc-MemoTrie.x86_64: W: spelling-error %description -l en_US memoized -> memorized, memorialized, memorize The value of this tag appears to be misspelled. Please double-check. ghc-MemoTrie-devel.x86_64: W: spelling-error Summary(en_US) Trie -> Trier, Teri, Tree The value of this tag appears to be misspelled. Please double-check. ghc-MemoTrie-devel.x86_64: W: spelling-error %description -l en_US memoized -> memorized, memorialized, memorize The value of this tag appears to be misspelled. Please double-check. ghc-MemoTrie-prof.x86_64: E: devel-dependency ghc-MemoTrie-devel Your package has a dependency on a devel package but it's not a devel package itself. ghc-MemoTrie-prof.x86_64: W: spelling-error %description -l en_US memoized -> memorized, memorialized, memorize The value of this tag appears to be misspelled. Please double-check. ghc-MemoTrie-prof.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. ghc-MemoTrie-prof.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ghc-6.12.3/MemoTrie-0.4.9/libHSMemoTrie-0.4.9_p.a A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. 4 packages and 1 specfiles checked; 1 errors, 11 warnings. [+]MUST: The package must be named according to the Package Naming Guidelines. [+]MUST: The spec file name must match the base package %{name}, in the format %{name}.spec [+]MUST: The package must meet the Packaging Guidelines. Naming-Yes Version-release - Matches License - OK , BSD 3 clause. COPYING file contains the license text. No prebuilt external bits - OK Spec legibity - OK Package template - OK Arch support - OK Libexecdir - OK rpmlint - yes changelogs - OK Source url tag - OK, validated. Buildroot is ignored - present anyway. OK. %clean is ignored - present anyway. OK Build Requires list - OK Summary and description - OK API documentation - OK, present in devel package [+]MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. Licensed with BSD 3 clause license. License text present in COPYING file. [+]MUST: The License field in the package spec file must match the actual license. [+]MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. License text is present in COPYING file. [+]MUST: The spec file must be written in American English. [+]MUST: The spec file for the package MUST be legible. [+]MUST: The sources used to build the package must match the upstream source,as provided in the spec URL. Reviewers should use md5sum for this task. md5sum MemoTrie-0.4.9.tar.gz cade4513b4dfbbe9b484292664561b71 MemoTrie-0.4.9.tar.gz md5sum ghc-MemoTrie-0.4.9-1.fc14.src/MemoTrie-0.4.9.tar.gz cade4513b4dfbbe9b484292664561b71 ghc-MemoTrie-0.4.9-1.fc14.src/MemoTrie-0.4.9.tar.gz [+]MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. Yes built on x86_64. http://koji.fedoraproject.org/koji/taskinfo?taskID=2748612 [+]MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. [+]MUST: All build dependencies must be listed in BuildRequires. [NA]MUST: The spec file MUST handle locales properly using the %find_lang macro [NA]MUST: Packages stores shared library files must call ldconfig in %post and %postun. [+]MUST: Packages must NOT bundle copies of system libraries. checked with rpmquery --list [NA]MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review. [+]MUST: A package must own all directories that it creates. checked with rpmquery --whatprovides [+]MUST: A Fedora package must not list a file more than once in the spec file's %files listings. [+]MUST: Permissions on files must be set properly. checked with ls -lR [+]MUST: Each package must consistently use macros. Yes, uses package template provided by macros.ghc [+]MUST: The package must contain code, or permissible content. [+]MUST: Large documentation files must go in a -doc subpackage. API documentation in devel package [+]MUST: If a package includes something as %doc, it must not affect the runtime of the application. checked with ls -lR [+]MUST: Header files must be in a -devel package. [NA]MUST: Static libraries must be in a -static package. [NA]MUST: If a package contains library files with a suffix (e.g.libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [+]MUST: devel packages must require the base package using a fully versioned dependency: Requires: {name} = %{version}-%{release} rpm -e ghc-MemoTrie error: Failed dependencies: ghc-MemoTrie = 0.4.9-1.fc14 is needed by (installed) ghc-MemoTrie-devel-0.4.9-1.fc14.x86_64 rpm -e ghc-MemoTrie-devel error: Failed dependencies: ghc-MemoTrie-devel = 0.4.9-1.fc14 is needed by (installed) ghc-MemoTrie-prof-0.4.9-1.fc14.x86_64 [NA]MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [NA]MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section [+]MUST: Packages must not own files or directories already owned by other packages. checked with rpmquery --list [+]MUST: All filenames in rpm packages must be valid UTF-8. Should items [+]SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [+]SHOULD: The reviewer should test that the package functions as described. Installed the packages. Installs fine. Imported Data.MemoTrie module from ghci. Works fine. [+]SHOULD: If scriptlets are used, those scriptlets must be sane. cabal2spec-diff is OK. APPROVED.
I mixed up assigned to and QA contact fields. Resetting QA contact to default.
New Package CVS Request ======================= Package Name: ghc-MemoTrie Short Description: Trie-based memo functions Owners: mathstuf Branches: F-13 F-14
Git done (by process-git-requests).
Rawhide build at http://koji.fedoraproject.org/koji/buildinfo?buildID=228277
This package is not available in Fedora 15 yet.
Hi Ben, Can you submit updates of ghc-MemoTrie for F15,F14 and F13?
Building for F15 now, will submit when it finishes.
ghc-MemoTrie-0.4.9-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/ghc-MemoTrie-0.4.9-1.fc14
ghc-MemoTrie-0.4.9-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/ghc-MemoTrie-0.4.9-2.fc15
ghc-MemoTrie-0.4.9-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/ghc-MemoTrie-0.4.9-1.fc13
ghc-MemoTrie-0.4.9-2.fc15 has been pushed to the Fedora 15 stable repository.
ghc-MemoTrie-0.4.9-1.fc14 has been pushed to the Fedora 14 stable repository.
ghc-MemoTrie-0.4.9-1.fc13 has been pushed to the Fedora 13 stable repository.