Bug 631674 - [abrt] ufraw-0.17-1.fc14: _lf_detect_cpu_features: Process /usr/bin/ufraw was killed by signal 11 (SIGSEGV)
Summary: [abrt] ufraw-0.17-1.fc14: _lf_detect_cpu_features: Process /usr/bin/ufraw was...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: lensfun
Version: 14
Hardware: i686
OS: Linux
low
medium
Target Milestone: ---
Assignee: Nils Philippsen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: abrt_hash:cbfef7a07a520455c6fd67acfaa...
: 634350 637499 640178 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-09-08 06:51 UTC by Gareth
Modified: 2010-10-06 17:35 UTC (History)
9 users (show)

Fixed In Version: lensfun-0.2.5-3.fc14
Clone Of:
: 633257 (view as bug list)
Environment:
Last Closed: 2010-10-01 12:23:58 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: backtrace (35.65 KB, text/plain)
2010-09-08 06:51 UTC, Gareth
no flags Details
backported cpuid fixes (3.90 KB, patch)
2010-09-17 09:17 UTC, Nils Philippsen
no flags Details | Diff

Description Gareth 2010-09-08 06:51:15 UTC
abrt version: 1.1.13
architecture: i686
Attached file: backtrace
cmdline: ufraw
comment: can supply an image if it would help (18mb in size)
component: ufraw
crash_function: _lf_detect_cpu_features
executable: /usr/bin/ufraw
kernel: 2.6.35.4-12.fc14.i686
package: ufraw-0.17-1.fc14
rating: 4
reason: Process /usr/bin/ufraw was killed by signal 11 (SIGSEGV)
release: Fedora release 14 (Laughlin)
time: 1283928439
uid: 500

How to reproduce
-----
1. cd to directory containing images (have not tested from different dir)
2. started ufraw as unpriveledged user from command line (gnome-terminal)
3. selected single RAW image (taken with canon 7d)
4. selected open-> crash

Comment 1 Gareth 2010-09-08 06:51:18 UTC
Created an attachment (id=445888)
File: backtrace

Comment 2 Nils Philippsen 2010-09-13 12:33:50 UTC
Can you reproduce this error reliably? I'm asking because the the attached backtrace generated by abrt is surely broken, this code line ...:

	                    cpuflags |= LF_CPU_FLAG_MMX;

... shouldn't be able to cause a segmentation violation.

Comment 3 Gareth 2010-09-13 14:04:06 UTC
It happens whenever I try to open any .cr2 from the 7d.

Line of concern is identical:
Program terminated with signal 11, Segmentation fault.
#0  _lf_detect_cpu_features () at libs/lensfun/cpuid.cpp:73
73	                    cpuflags |= LF_CPU_FLAG_MMX;


I have tried to ensure that the system is hardware-stable to ensure that /any/ bugs/crashes on the platform are software based not hardware related. Hardware has been fine for a year with f11, and have re-run memtest to try and get some confidence in the memory etc.

(probably a certainty given the symptoms, but the ufraw-gimp is stating that the plugin returned 0 on attempting to load the image).

I have downloaded the 0.18 source and compiled it, the report states the same (identical crash)
Program terminated with signal 11, Segmentation fault.
#0  _lf_detect_cpu_features () at libs/lensfun/cpuid.cpp:73
73	                    cpuflags |= LF_CPU_FLAG_MMX;

Comment 4 Nils Philippsen 2010-09-14 09:48:31 UTC
Gareth, please attach one raw file with which you can reproduce the bug to this report. I still think that there's a problem with the backtrace, as cpuflags is an unsigned int (guint) and LF_CPU_FLAG_MMX is an enum, i.e. an integer as well.

Changing the component to lensfun since the crash happens in this library.

Comment 5 Martin Fahrendorf 2010-09-15 19:47:43 UTC
Hallo

I can confirm this bug as well. It is a lensfun problem. If you start ufraw with --lensfun=none ufraw does not crash. Showfoto from digikam crashes as well on using the lensfun lib.

I don't think that the problem is the line 73 itself, but more a corrupt stack which is triggered as soon as the first variable is used. I have changed the source and added a blind assign some lines above and the crash happens in the added assign. Most likely some of the asm statements are buggy at some CPUs (mine is a Pentium 4). I added the statement direct above the 'if (ax)' line, so right under the asm statement.

Martin

Comment 6 Nils Philippsen 2010-09-16 15:46:16 UTC
*** Bug 634350 has been marked as a duplicate of this bug. ***

Comment 7 Martin Fahrendorf 2010-09-16 17:10:02 UTC
Hallo again

with current svn version of this file from lensfun it works for me. I have just tested this with self compiled ufraw.

Martin

Comment 8 Nils Philippsen 2010-09-17 09:17:59 UTC
Created attachment 447954 [details]
backported cpuid fixes

Comment 9 Nils Philippsen 2010-09-17 09:20:13 UTC
Rex, I've attached the cpuid fixes from upstream as a patch. I can't confirm that they work, probably because I'm on x86_64, not i686. Let me know if you want me to build the package and issue an update.

Comment 10 Rex Dieter 2010-09-17 11:36:53 UTC
you've got my blessing to proceed (else I'll do it myself soonish, maybe today... but more likely this weekend).

Comment 11 Nils Philippsen 2010-09-20 08:32:14 UTC
Building lensfun-0.2.5-3.fc14 for dist-f14-updates-candidate

Comment 12 Fedora Update System 2010-09-20 08:53:40 UTC
lensfun-0.2.5-3.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/lensfun-0.2.5-3.fc14

Comment 13 Nils Philippsen 2010-09-20 16:30:05 UTC
Gareth, Martin, please download the above testing update, check whether that fixes your issue and comment accordingly on the update page. Thanks.

Comment 14 Nils Philippsen 2010-09-20 16:41:14 UTC
Uhh, forgot about the F-13 build, here we go:

Comment 15 Fedora Update System 2010-09-20 16:42:23 UTC
lensfun-0.2.5-3.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/lensfun-0.2.5-3.fc13

Comment 16 Fedora Update System 2010-09-20 18:43:43 UTC
lensfun-0.2.5-3.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update lensfun'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/lensfun-0.2.5-3.fc14

Comment 17 Martin Fahrendorf 2010-09-21 16:20:26 UTC
Hallo

At least lensfun stuff is working again, but ufraw crashes now if I try to rotate a picture counter clockwise. Error message is:

** ERROR **: preview_draw_area(): x+width:622 out of range x+width <= 619
aborting...

I think this is a ufraw problem. I have posted this on the ufraw mailing list three days ago, but got no answer. With lensfun diabled (--lensfun=none) I don't get this error, so it is somewhat bound to lensfun.

Comment 18 Nils Philippsen 2010-09-21 17:26:41 UTC
(In reply to comment #17)
> Hallo
> 
> At least lensfun stuff is working again, but ufraw crashes now if I try to
> rotate a picture counter clockwise. Error message is:
> 
> ** ERROR **: preview_draw_area(): x+width:622 out of range x+width <= 619
> aborting...
> 
> I think this is a ufraw problem. I have posted this on the ufraw mailing list
> three days ago, but got no answer. With lensfun diabled (--lensfun=none) I
> don't get this error, so it is somewhat bound to lensfun.

Would you please open a separate ticket for this? Thanks.

Comment 19 Martin Fahrendorf 2010-09-22 18:45:22 UTC
OK

After many tests with two other computers I can say that my previous mentioned problem in Comment #17 was due to problems in my ufrawrc file. From my various tests it seems to be messed up. I removed it and ufraw runs fine again.

From my point of view the bug in the lensfun lib is fixed.

Comment 20 Nils Philippsen 2010-09-23 09:07:24 UTC
(In reply to comment #19)
> After many tests with two other computers I can say that my previous mentioned
> problem in Comment #17 was due to problems in my ufrawrc file. From my various
> tests it seems to be messed up. I removed it and ufraw runs fine again.

It still shouldn't crash (or create a messed up rc file). Do you happen to still have a copy of that file?

> From my point of view the bug in the lensfun lib is fixed.

It would be great if you added a comment/karma to the update then. Thanks!

Comment 21 Martin Fahrendorf 2010-09-23 19:25:29 UTC
Just in case someone is interested: the crash has nothing to do with a messed up rc file. if either overExposure or underExposure is set to blink my ufraw crashes _after_ next restart if I try to rotate a croped picture counter clockwise. If none of this is set, all is working as it should.

So this is something for a separate ticket.

Comment 22 hrsvan 2010-09-23 20:32:17 UTC
Package: ufraw-0.17-1.fc13
Architecture: i686
OS Release: Fedora release 13 (Goddard)


How to reproduce
-----
1.try to open a canon *.cr2 file with UFRAW
2.
3.

Comment 23 Paweł Łyżwa 2010-09-25 07:56:26 UTC
Package: ufraw-0.17-1.fc13
Architecture: i686
OS Release: Fedora release 13 (Goddard)


How to reproduce
-----
1. try to open any .nef file


Comment
-----
/proc/cpuinfo: 
processor	: 0
vendor_id	: GenuineIntel
cpu family	: 6
model		: 13
model name	: Intel(R) Celeron(R) M processor         1.50GHz
stepping	: 8
cpu MHz		: 1500.000
cache size	: 1024 KB
fdiv_bug	: no
hlt_bug		: no
f00f_bug	: no
coma_bug	: no
fpu		: yes
fpu_exception	: yes
cpuid level	: 2
wp		: yes
flags		: fpu vme de pse tsc msr pae mce cx8 apic mtrr pge mca cmov clflush dts acpi mmx fxsr sse sse2 ss tm pbe up bts
bogomips	: 2999.71
clflush size	: 64
cache_alignment	: 64
address sizes	: 32 bits physical, 32 bits virtual
power management:

Comment 24 Clement Dominik 2010-09-26 08:18:22 UTC
Package: ufraw-0.17-1.fc13
Architecture: i686
OS Release: Fedora release 13 (Goddard)


How to reproduce
-----
1. Nach eingabe des Objektiv Typ
2.
3.

Comment 25 Vesa Halttunen 2010-09-27 20:39:37 UTC
Package: ufraw-0.17-1.fc13
Architecture: i686
OS Release: Fedora release 13 (Goddard)


How to reproduce
-----
1. Run ufraw and give it a NEF file created with a Nikon D70s as an argument.


Comment
-----
This is a regression. The same files used to open just fine earlier. No idea which version introduced the crash.

Comment 26 Gareth 2010-09-30 18:17:48 UTC
Sorry for the delay, I have been out of the country. I can confirm that the current version, uploaded to the fedora-14-testing and updated as:

yum -y --enablerepo=updates-testing update lensfun

Updated:
  lensfun.i686 0:0.2.5-3.fc14                                                                                                                                               
Dependency Updated:
  lensfun-devel.i686 0:0.2.5-3.fc14  

has fixed the problem on my machine, when tested against a couple of images.

Command:
ufraw ~/b/_mg_0027.cr2

Expected and obtained result: 
UFRAW starts, and loads image


Using the rotate option does not cause any errors on my system.

Do you still want me to upload a RAW file for testing purposes?

Comment 27 Nils Philippsen 2010-10-01 08:57:46 UTC
(In reply to comment #26)
> Do you still want me to upload a RAW file for testing purposes?

No, I don't think that's necessary anymore.

Comment 28 Fedora Update System 2010-10-01 12:23:53 UTC
lensfun-0.2.5-3.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 29 Rex Dieter 2010-10-05 00:02:50 UTC
*** Bug 637499 has been marked as a duplicate of this bug. ***

Comment 30 Gianluca Sforna 2010-10-05 07:01:12 UTC
*** Bug 640178 has been marked as a duplicate of this bug. ***

Comment 31 Fedora Update System 2010-10-05 09:22:59 UTC
lensfun-0.2.5-3.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 32 Toshi 2010-10-05 15:55:21 UTC
I followed the advice I was given for this bug by using 

yum --enablerepo=updates update lensfun

and 

yum -y --enablerepo=updates update lensfun

My system tells me there are no packages marked for update.  Am I doing something incorrectly?

Toshi

Comment 33 Nils Philippsen 2010-10-05 17:39:12 UTC
(In reply to comment #32)
> My system tells me there are no packages marked for update.  Am I doing
> something incorrectly?

Your mirror might not have picked up the new package. You can download the packages directly from koji (see comment #12 (F-14), comment #16 (F-13), then "Builds") and install them with "yum localupdate <downloaded package files>".

Comment 34 Toshi 2010-10-06 17:35:23 UTC
Thank you.  I was able to download the package and install it. It seems to be working just fine now.  I appreciate the assistance.


Note You need to log in before you can comment on or make changes to this bug.