Bug 632369 - PATCH: neon plugin: make seek to eof "char" work
Summary: PATCH: neon plugin: make seek to eof "char" work
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: audacious-plugins
Version: 14
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Michael Schwendt
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-09-09 18:58 UTC by Hans de Goede
Modified: 2010-09-25 05:33 UTC (History)
2 users (show)

Fixed In Version: audacious-plugins-2.4.0-2.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-09-25 05:33:51 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
PATCH: neon plugin: make seek to eof "char" work (897 bytes, patch)
2010-09-09 18:58 UTC, Hans de Goede
no flags Details | Diff

Description Hans de Goede 2010-09-09 18:58:34 UTC
Created attachment 446347 [details]
PATCH: neon plugin: make seek to eof "char" work

Hi,

Today I started using audacious to play music from jamendo with my account configured to access music as m3u playlist with .ogg (vorbis) files in there.

This has resulted in me writing the following patch:
audacious-plugins-2.4.0-neon-seek_end.patch

The vorbis plugin makes fseek(f, 0, SEEK_END) calls
this is quite a normal thing to do to determine
filesize, but the neon transport plugin cannot
handle this as this comes down to seeking to the
fictional eof character, triggering the
    if (newpos >= content_length)
check in the neon transport plugin fseek code. This
patch catches this special case and handles it
properly.

Without this patch all the jamendo ogg files when
streamed over http end up with an unknown duration
and are unseekable, this patch fixes both.

Thanks & Regards,

Hans

Comment 1 Michael Schwendt 2010-09-13 16:31:05 UTC
Patch appears to be correct.

Comment 2 Fedora Update System 2010-09-14 20:54:31 UTC
audacious-plugins-2.4.0-2.fc14,audacious-2.4.0-3.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/audacious-plugins-2.4.0-2.fc14,audacious-2.4.0-3.fc14

Comment 3 Fedora Update System 2010-09-15 06:52:46 UTC
audacious-plugins-2.4.0-2.fc14, audacious-2.4.0-3.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update audacious-plugins audacious'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/audacious-plugins-2.4.0-2.fc14,audacious-2.4.0-3.fc14

Comment 4 Fedora Update System 2010-09-25 05:33:38 UTC
audacious-plugins-2.4.0-2.fc14, audacious-2.4.0-3.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.