Bug 632399 - Misleading message from fs/nfs/file.c:do_vfs_lock()
Summary: Misleading message from fs/nfs/file.c:do_vfs_lock()
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel
Version: 5.5
Hardware: All
OS: Linux
high
high
Target Milestone: rc
: ---
Assignee: Jeff Layton
QA Contact: Petr Beňas
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-09-09 20:21 UTC by Fabio Olive Leite
Modified: 2018-11-14 18:55 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-07-21 10:08:51 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Simple patch to remove the message (897 bytes, patch)
2010-09-09 20:21 UTC, Fabio Olive Leite
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2011:1065 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 5.7 kernel security and bug fix update 2011-07-21 09:21:37 UTC

Description Fabio Olive Leite 2010-09-09 20:21:35 UTC
Created attachment 446368 [details]
Simple patch to remove the message

Description of problem:

When an NFS volume is mounted with -onolock, any interrupted blocked locking call generates this message:

kernel: do_vfs_lock: VFS is out of sync with lock manager!

The message is incorrect, since the lock manager will not be used on mounts with -onolock, and is both annoying and scary on the logs.

It was recently fixed upstream: http://marc.info/?t=128383914000003&r=1&w=2

Version-Release number of selected component (if applicable):

kernel-2.6.18-164.2.1.el5 on the test box where it was reproduced, but pretty much any RHEL-5 kernel is affected.

How reproducible:

Always.

Steps to Reproduce:
1. mount -onolock server:/volume /mnt
2. flock /mnt/file bash [ locks the file and spawns a new shell ]
3. flock -w 1 /mnt/file bash [ repeat ad nauseam, each gets a printk ]

The "flock -w 1" is a case where it alarms out of the flock call. One can also run it without a timeout and ^C out of it, and it also gets a printk.

Actual results:

Incorrect message is displayed on the console and sent to the logs.

Expected results:

No incorrect messages.

Comment 4 Eric Sammons 2010-09-26 19:01:11 UTC
=== In Red Hat Customer Portal Case 00320163 ===
--- Comment by Sammons, Eric on 9/26/2010 3:00 PM ---

Customer has also expressed concerns of a possible DoS scenario here and would like to request this released as Errata.

Comment 6 Jeff Layton 2010-10-05 11:51:52 UTC
I've incorporated this patch into my test kernels here:

    http://people.redhat.com/jlayton/

...if you have a non-critical place to test them, please do so and report the results.

Comment 8 RHEL Program Management 2011-02-01 16:57:33 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 11 Jarod Wilson 2011-02-21 20:56:27 UTC
in kernel-2.6.18-245.el5
You can download this test kernel (or newer) from http://people.redhat.com/jwilson/el5

Detailed testing feedback is always welcomed.

Comment 14 Petr Beňas 2011-02-22 10:05:20 UTC
Reproduced in 2.6.18-244.el5 and verified in 2.6.18-245.el5.

Comment 16 errata-xmlrpc 2011-07-21 10:08:51 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-1065.html


Note You need to log in before you can comment on or make changes to this bug.