Spec URL: http://adsllc.fedorapeople.org/rpmbuild/SPECS/xinput_calibrator.spec SRPM URL: http://adsllc.fedorapeople.org/rpmbuild/SRPMS/xinput_calibrator-0.7.0-1.fc13.src.rpm Description: xinput_calibrator is a program for calibrating your touchscreen, when using the X Window System. It currently features: - a minimalist and intuitive GUI - works for any standard Xorg touchscreen driver (uses XInput) - can output the calibration in xorg.conf, FDI and udev format - can dynamically recalibrate the evdev driver - and more
RPMLINT $ rpmlint SPECS/xinput_calibrator.spec RPMS/x86_64/xinput_calibrator-*0.7* SRPMS/xinput_calibrator-0.7.0-1.fc13.src.rpm xinput_calibrator.x86_64: W: spelling-error %description -l en_US xinput -> input, x input, Xingu xinput_calibrator.x86_64: W: spelling-error %description -l en_US xorg -> xor, org, borg xinput_calibrator.x86_64: W: spelling-error %description -l en_US udev -> udder, Udine, Aude xinput_calibrator.x86_64: W: spelling-error %description -l en_US evdev -> evade, evident, evidence xinput_calibrator-debuginfo.x86_64: W: spelling-error Summary(en_US) xinput -> input, x input, Xingu xinput_calibrator-debuginfo.x86_64: W: spelling-error %description -l en_US xinput -> input, x input, Xingu xinput_calibrator.src: W: spelling-error %description -l en_US xinput -> input, x input, Xingu xinput_calibrator.src: W: spelling-error %description -l en_US xorg -> xor, org, borg xinput_calibrator.src: W: spelling-error %description -l en_US udev -> udder, Udine, Aude xinput_calibrator.src: W: spelling-error %description -l en_US evdev -> evade, evident, evidence 3 packages and 1 specfiles checked; 0 errors, 10 warnings. Warnings discussion: The spell-checker is being overzealous with proper names; everything is fine. KOJI http://koji.fedoraproject.org/koji/taskinfo?taskID=2461650
Some thoughts: - Why do you need the %global usage (first 4 lines)? - Why "%configure --prefix=%{_prefix} --libdir=%{_libdir}" rather "%configure"?
Robert: The %global statements are used to make it so that information is specified once instead of scattered throughout the file. It also makes maintainability easier since you can confidently change the information without worrying about subtle side effects. See also: https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define The prefix and libdir are specified so that the files are installed to /usr/bin and /usr/lib* instead of /usr/local/bin and /usr/local/lib*. Packages install their files into /usr, hand-compiled programs install their files into /usr/local. See also the '/usr/local' section of: http://tldp.org/LDP/Linux-Filesystem-Hierarchy/html/usr.html
Fedora dislikes the usage of %global for %{name}, %{version}, %{release} and other basic things, because "Name: xinput_calibrator" brings the same result as "%global name xinput_calibrator", so please correct this accordingly. There is no need to set %{_prefix} for yourself, because did you ever have a look to what %configure expands? And there is also no need for the parameters you added, because of this: $ rpm --eval '%configure' CFLAGS="${CFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic}" ; export CFLAGS ; CXXFLAGS="${CXXFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic}" ; export CXXFLAGS ; FFLAGS="${FFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -I/usr/lib64/gfortran/modules}" ; export FFLAGS ; ./configure --build=x86_64-unknown-linux-gnu --host=x86_64-unknown-linux-gnu \ --program-prefix= \ --disable-dependency-tracking \ --prefix=/usr \ --exec-prefix=/usr \ --bindir=/usr/bin \ --sbindir=/usr/sbin \ --sysconfdir=/etc \ --datadir=/usr/share \ --includedir=/usr/include \ --libdir=/usr/lib64 \ --libexecdir=/usr/libexec \ --localstatedir=/var \ --sharedstatedir=/var/lib \ --mandir=/usr/share/man \ --infodir=/usr/share/info % If the expansion does not fit for you, your build system is misconfigured or not set up as it should be.
With the supplied .spec file, xinput_calibrator version 0.7.5 compiles and installs flawlessly on F15 (i686).
Possible, but technical excellence and keeping the rules is also important. I don't see any fixed/reworked spec file so far...
Of course ; I was only providing a pointer that the package is still current.
(In reply to comment #7) > Of course ; I was only providing a pointer that the package is still current. Providing a pointer, that Robert is right and there should be a new one with changes. Will there be new one?
Still no updated package? I will close this soon if there's no response.