Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 633018

Summary: [RFE] Support multiple --addtag and --deltag arguments within a single command
Product: Red Hat Enterprise Linux 6 Reporter: Saggi Mizrahi <smizrahi>
Component: lvm2Assignee: Alasdair Kergon <agk>
Status: CLOSED ERRATA QA Contact: Corey Marthaler <cmarthal>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 6.0CC: abaron, agk, bazulay, bmarzins, coughlan, cpelland, dwysocha, heinzm, iheim, jbrassow, joe.thornber, mbroz, plyons, prajnoha, prockai
Target Milestone: rcKeywords: FutureFeature, ZStream
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: lvm2-2.02.82-1.el6 Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-19 14:26:36 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 583429, 652662    

Description Saggi Mizrahi 2010-09-12 13:35:51 UTC
Description of problem:

We would like to be able to add and\or remove multiple tags in one lvchange command.
These changes should also be atomic.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 2 Heinz Mauelshagen 2010-09-15 13:28:07 UTC
For the record:

this involves being able to create and change *many* tags, hence growing the MDA size significantly (eg. ~100MB per MDA), hence we need respective scalabiliy and test coverage in order to ensure decent MDA update performance.

Comment 3 Ayal Baron 2010-09-15 20:33:42 UTC
(In reply to comment #2)
> For the record:
> 
> this involves being able to create and change *many* tags, hence growing the
> MDA size significantly (eg. ~100MB per MDA), hence we need respective
> scalabiliy and test coverage in order to ensure decent MDA update performance.

In general, what about allowing to compress the MD area containing all the LVs info?  Seeing as it is all text it would compress significantly, making required IO much smaller.  (This mechanism could kick in only if MD crosses certain size).  This could improve performance.

Comment 5 Ayal Baron 2010-11-08 17:29:30 UTC
This is now blocking our dev for coming release as running dozens of commands per update takes its toll and slows down our testing suites considerably.

(In reply to comment #2)
> For the record:
> 
> this involves being able to create and change *many* tags, hence growing the
> MDA size significantly (eg. ~100MB per MDA), hence we need respective
> scalabiliy and test coverage in order to ensure decent MDA update performance.

Actually what is required here does not involve growing MDA size significantly at all.  What is required is to be able to change less than 100 tags simultaneously and we do not need to store more than a few MB of MD.

Comment 6 Alasdair Kergon 2010-11-11 17:51:21 UTC
Support for multiple --addtag or --deltag cmdline options added upstream for 2.02.77.

Comment 12 Corey Marthaler 2011-03-01 21:45:45 UTC
Fix verified in the latest rpms.

2.6.32-114.0.1.el6.x86_64

lvm2-2.02.83-2.el6    BUILT: Tue Feb  8 10:10:57 CST 2011
lvm2-libs-2.02.83-2.el6    BUILT: Tue Feb  8 10:10:57 CST 2011
lvm2-cluster-2.02.83-2.el6    BUILT: Tue Feb  8 10:10:57 CST 2011
udev-147-2.33.el6    BUILT: Wed Feb  9 09:56:24 CST 2011
device-mapper-1.02.62-2.el6    BUILT: Tue Feb  8 10:10:57 CST 2011
device-mapper-libs-1.02.62-2.el6    BUILT: Tue Feb  8 10:10:57 CST 2011
device-mapper-event-1.02.62-2.el6    BUILT: Tue Feb  8 10:10:57 CST 2011
device-mapper-event-libs-1.02.62-2.el6    BUILT: Tue Feb  8 10:10:57 CST 2011
cmirror-2.02.83-2.el6    BUILT: Tue Feb  8 10:10:57 CST 2011



[root@grant-03 ~]# vgcreate grant /dev/sdb1 /dev/sdc1
  Clustered volume group "grant" successfully created

[root@grant-03 ~]# vgs -a -o +vg_tags
  VG         #PV #LV #SN Attr   VSize   VFree   VG Tags
  grant        2   0   0 wz--nc 476.80g 476.80g

[root@grant-03 ~]# vgchange --addtag T9 --addtag T10 --addtag T11 --addtag T12 grant
  Volume group "grant" successfully changed

[root@grant-03 ~]# vgs -a -o +vg_tags
  VG         #PV #LV #SN Attr   VSize   VFree   VG Tags
  grant        2   0   0 wz--nc 476.80g 476.80g T9,T10,T11,T12

[root@grant-03 ~]# vgchange --deltag T9 --deltag T10 --addtag T13 --addtag T14 grant
  Volume group "grant" successfully changed

[root@grant-03 ~]# vgs -a -o +vg_tags
  VG         #PV #LV #SN Attr   VSize   VFree   VG Tags
  grant        2   0   0 wz--nc 476.80g 476.80g T11,T12,T13,T14

Comment 13 errata-xmlrpc 2011-05-19 14:26:36 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0772.html