Bug 633085 - Review Request: mediawiki116 - Mediawiki package for EPEL
Summary: Review Request: mediawiki116 - Mediawiki package for EPEL
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Mark Chappell
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 533795
TreeView+ depends on / blocked
 
Reported: 2010-09-12 19:22 UTC by Stephen John Smoogen
Modified: 2013-01-10 23:30 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-01-10 23:30:05 UTC
Type: ---
Embargoed:
tremble: fedora-review+


Attachments (Terms of Use)

Description Stephen John Smoogen 2010-09-12 19:22:06 UTC
Spec URL: http://smooge.fedorapeople.org/mediawiki/mediawiki116.spec
SRPM URL:
http://smooge.fedorapeople.org/mediawiki/rhel-5-i386/mediawiki116-1.16.0-5.el5.src.rpm

Description: 
MediaWiki is the software used for Wikipedia and the other Wikimedia
Foundation websites. Compared to other wikis, it has an excellent
range of features and support for high-traffic websites using multiple
servers

This bundles the 1.16.x version of mediawiki for replacement for
RHEL-4/5/6 usage. This version does not contain patches that current
Fedora mediawiki contains due to their conflict with upstreams patch
sets.

Comment 2 Mark Chappell 2010-10-12 20:13:01 UTC
rpmlint:
[mchappel@mchappel rpmbuild]$ rpmlint mediawiki116-1.16.0-5.el5.x86_64.rpm 
mediawiki116.x86_64: W: spelling-error %description -l en_US Wikimedia -> Wikipedia, Wiki media, Wiki-media
mediawiki116.x86_64: W: executable-stack /usr/bin/texvc116
mediawiki116.x86_64: W: hidden-file-or-dir /usr/share/mediawiki116/maintenance/tests/.svnignore
mediawiki116.x86_64: W: dangling-symlink /var/www/mediawiki116/StartProfiler.php /usr/share/mediawiki116/StartProfiler.php


Same issues as with 115...

Non-critical but worth doing before the first push:
* tetex-latex should probably be tex(latex)
* tetex-dvips should probably be tex(dvips)

Should get fixed first:

* mediawiki115.x86_64: W: executable-stack /usr/bin/texvc115
You can probably use "execstack -c" to clear this, not sure how to double check that texvc115 doesn't get broken though (don't generally use mediawiki)

* mediawiki116.x86_64: W: hidden-file-or-dir /usr/share/mediawiki116/maintenance/tests/.svnignore
Shouldn't be there :)

* mediawiki116.x86_64: W: dangling-symlink /var/www/mediawiki116/StartProfiler.php /usr/share/mediawiki116/StartProfiler.php

Comment 3 Mark Chappell 2010-10-13 18:59:11 UTC
 - = N/A
 / = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [/] Package is named according to the Package Naming Guidelines.
 [/] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [/] Package meets the Packaging Guidelines including the Language specific
items
 [/] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested: http://koji.fedoraproject.org/koji/taskinfo?taskID=...
 [!] Rpmlint output: (See below)
 [/] Package is not relocatable.
 [/] Buildroot is correct  ( Not needed if >= EL6 and >= F13 )
     Buildroot: %{_tmppath}/%{name}-%{version}-%{release}-root
 [/] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [/] License field in the package spec file matches the actual license.
     License type: GPLv2+
 [/] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [-] With any Subpackage installed the license must also be installed (this may
belong to another subpackage)
 [/] Spec file is legible and written in American English.
 [/] Sources used to build the package matches the upstream source, as provided
in the spec URL.

0a2177b5eb4be2b5a585ab28070fec13  MWRound1/mediawiki-1.16.0.tar.gz
0a2177b5eb4be2b5a585ab28070fec13  SOURCES/mediawiki-1.16.0.tar.gz

 [/] Package is not known to require ExcludeArch
 [/] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [/] Package must own all directories that it creates.
 [/] Package requires other packages for directories it uses.
 [/] Package does not contain duplicates in %files.
 [/] Permissions on files are set properly.
 [/] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT. ( Not
needed if >= EL6 and >= F13 )
 [/] Package consistently uses macros.
 [/] Package contains code, or permissible content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [/] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -static subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [/] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [/] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [/] Latest version is packaged.
 [/] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [/] Reviewer should test that the package builds in mock.
 [/] Package should compile and build into binary rpms on all supported
architectures.
     Tested on: fedora-5E-epel-testing-candidate
 [-] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [/] File based requires are sane.
 [-] %check is present and the tests pass

Scratch built -6 through koji...

[mchappel@mchappel rpmbuild]$ rpmlint mediawiki116-1.16.0-6.el5.*
mediawiki116.src: W: spelling-error %description -l en_US Wikimedia -> Wikipedia, Wiki media, Wiki-media
mediawiki116.x86_64: W: spelling-error %description -l en_US Wikimedia -> Wikipedia, Wiki media, Wiki-media
mediawiki116.x86_64: W: hidden-file-or-dir /usr/share/mediawiki116/maintenance/tests/.svnignore
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

=== COMMENTS ===

Looks good, .svnignore is still about, but otherwise seems good but this doesn't feel like a blocker.

APPROVED

Comment 4 Jason Tibbitts 2010-11-07 15:44:36 UTC
Please re-raise the fedora-cvs flag when you provide an SCM request for us to
process.

Comment 5 Stephen John Smoogen 2010-11-12 03:09:42 UTC
New Package SCM Request
=======================
Package Name: mediawiki116
Short Description: A wiki engine
Owners: smooge
Branches: el4 el5 el6
InitialCC:

Comment 6 Kevin Fenzi 2010-11-12 15:40:03 UTC
Git done (by process-git-requests).

Comment 7 Stephen John Smoogen 2010-11-13 01:53:45 UTC
Package Change Request
======================
Package Name: mediawiki116
New Branches: rawhide
Owners: smooge

Comment 8 Jason Tibbitts 2010-11-13 16:51:18 UTC
There is no reason to request a devel branch.

Comment 9 François Cami 2013-01-10 23:30:05 UTC
Built and shipped. Closing.


Note You need to log in before you can comment on or make changes to this bug.