Spec URL: http://stahnma.fedorapeople.org/reviews/rubygem-fakeweb.spec SRPM URL: http://stahnma.fedorapeople.org/reviews/rubygem-fakeweb-1.3.0-1.fc15.src.rpm Description: FakeWeb is a helper for faking web requests in Ruby. It works at a global level, without modifying code or writing extensive stubs.
Would you try to remove vendorized modules included in test/ directory?
Sure. I was going to ask on list how we handle things in vendor. Is there something in the package guidelines already for that?
Well, as shown in "general" packaging guidelines: https://fedoraproject.org/wiki/Packaging/Guidelines#Bundling_of_multiple_projects we should seperate bundled other softwares from sources. Also see bug 470696 : Currently rubygem-passenger ships bundled boost and unless we remove this rubygem-passenger cannot be in Fedora. Now I am listing rubygem based rpms on Fedora which ships vendorlized external gem, will post on ruby-sig.
Well, passenger ships a C lib, which may be different, but in general shoving it in vendor or use bundler are not solutions I like. For this revisions I have added BuildRequires(check): rubygem(right_http_connection) and patched out the two tests that require samuel. I may try to package up samuel eventually, but I have a LOT of packages I am already working on. New SRPM: http://stahnma.fedorapeople.org/reviews/rubygem-fakeweb-1.3.0-2.fc15.src.rpm
Sorry, I have not checked your last srpm yet, however I will surely review this.
Now for 1.3.0-2: * (Build)Requires - Writing >= 0.9.5 for rubygem(mocha) dependency is not needed because rubygem-mocha on currently supported Fedora/EPEL branches all satisfies this dependency: https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires - "R: rubygem(mocha)" is not needed because this is for add_development_dependency in installed gemspec file and is not needed on runtime. * %_geminstdir/*gemspec - Would you check if this is really needed? (Note that gemspec file is also installed under %gemdir/specifications/)
Removed the BR versioning. Remove mocha as a runtime require. Removed gemspec. http://stahnma.fedorapeople.org/reviews/rubygem-fakeweb-1.3.0-3.fc15.src.rpm
Okay. ----------------------------------------------------------- This package (rubygem-fakeweb) is APPROVED by mtasaka -----------------------------------------------------------
New Package SCM Request ======================= Package Name: rubygem-fakeweb Short Description: A tool for faking responses to HTTP Owners: stahnma Branches: F13 F14 EL5 EL6 InitialCC:
Git done (by process-git-requests).
rubygem-fakeweb-1.3.0-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-fakeweb-1.3.0-3.fc14
rubygem-fakeweb-1.3.0-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-fakeweb-1.3.0-3.fc13
rubygem-fakeweb-1.3.0-3.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-fakeweb'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-fakeweb-1.3.0-3.fc14
rubygem-fakeweb-1.3.0-3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
rubygem-fakeweb-1.3.0-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.