Red Hat Bugzilla – Bug 633919
Adding log rotation to /var/log/brcm-iscsi.log
Last modified: 2011-10-09 17:59:11 EDT
Original bug is targeting 6.1 only, so for RHEL 5.6 based RHEV-H we're going to add logrotate entry for /var/log/brcm-iscsi.log in the image directly. +++ This bug was initially created as a clone of Bug #602959 +++ The uIP, brcm_iscsiuio, daemon doesn't rotation it's own log file usually found at /var/log/brcm-iscsi.log. If left unchecked this file can grow unbounded and unchecked especially if high debug output is enabled and the machine is left on for a long time.
Created attachment 498067 [details] Patch Added brcm-iscsi.log to list of logs to be rotated. Currently set to be same options as ovirt.log.
Created attachment 499343 [details] Follow-up patch See bug 703995 comment 5 for details Patch fixes ovirt log rotation
Technical note added. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: Prior to this update, "/var/log/brcm-iscsi.log" file was not log-rotated by default. With this update, log rotation of the "/var/log/brcm-iscsi.log" file is enabled to prevent it from growing indefinitely. Additionally, a previously existing bug was discovered that prevented the "/var/log/ovirt.log" file from being rotated. This update fixes this issue, and log rotatation for the "/var/log/ovirt.log" file works as expected.
Verified on rhev-hypervisor-5.7-20110622.0.el5, brcm-iscsi.log is rotated and compressed while it got big: # ll brcm* -rw-r--r-- 1 root root 0 Jun 24 04:00 brcm-iscsi.log -rw-r--r-- 1 root root 561495 Jun 24 04:00 brcm-iscsi.log.1.gz it's configured in /etc/logrotate.d/ovirt-node: # cat /etc/logrotate.d/ovirt-node /var/log/ovirt*.log /var/log/mcelog /var/log/brcm-iscsi.log { rotate 3 compress missingok size 1M create }
ovirt.log is also rotated when it got big: # cd /var/log [root@localhost log]# ll ovirt* -rw-r--r-- 1 root root 1126 Jun 24 05:11 ovirt.log -rw-r--r-- 1 root root 18450 Jun 24 2011 ovirt.log-tmp -rw-r--r-- 1 root root 34558 Jun 24 05:10 ovirt.log.1.gz
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2011-1090.html
It seems to me the log rotation of brcm-iscsi.log should have been fixed in iscsi-initiator-utils instead of in ovirt-node. I have a customer on plain RHEL 5 libvirt/kvm which does not use ovirt-node so I opened a separate bug on RHEL. https://bugzilla.redhat.com/show_bug.cgi?id=729355
(In reply to comment #8) > It seems to me the log rotation of brcm-iscsi.log should have been fixed in > iscsi-initiator-utils instead of in ovirt-node. Agreed, but as comment 0 says, original bug 602959 was targeted to be fixed in 6.x only so we fixed where we could.
I thought we had a bz for iscsi-initiator-utils in rhel 5 too. I will try to find it.
(In reply to comment #10) > I thought we had a bz for iscsi-initiator-utils in rhel 5 too. I will try to > find it. I searched before I opened the one above.. didn't see anything but maybe there is one.