Bug 634235 - Ufraw wants to crop newly loaded image into aspect ratio of previous image
Summary: Ufraw wants to crop newly loaded image into aspect ratio of previous image
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: ufraw
Version: 14
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Nils Philippsen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-09-15 15:33 UTC by Steevithak
Modified: 2011-08-23 20:37 UTC (History)
1 user (show)

Fixed In Version: ufraw-0.18-3.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-08-23 04:31:55 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Steevithak 2010-09-15 15:33:28 UTC
Description of problem:

Just upgraded via yum to the new version of ufraw. The new version has a problem adjusting to successive images that have different aspect ratios. It appears to be remembering the aspect ratio of the previous image and trying to apply it to the new one. 

For example, if you load a landscape aspect ratio image followed by a portrait aspect ratio image, ufraw doesn't display the portrait mode image correctly; it displays with landscape aspect ratio crop markings on as if it thinks you want to crop off the top and bottom. The only way to fix it is to manually go the "crop and rotate" tab on every new shot you load and hit the "reset crop region" button. 


Version-Release number of selected component (if applicable):
ufraw-0.17-1.fc13.x86_64

How reproducible:
always

Steps to Reproduce:
1. load a landscape aspect ratio image
2. save image
3. load a portrait aspect ratio image
  
Actual results:

the portrait aspect ratio image is displayed with a small, landscape mode crop box covering the center and the rest of the image is greyed out

Expected results:

the portrait aspect ratio image should be displayed normally with no crop markings

Additional info:

this worked fine on ufraw-0.16 and all previous versions

the only work-around I've discovered so far it to go to the crop and "rotate tab" and click the reset "crop region button". This will need to be done on every image loaded unless the new image is coincidentally of the exact same aspect ratio as the previous one.

Comment 1 Bug Zapper 2011-05-31 13:25:50 UTC
This message is a reminder that Fedora 13 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 13.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '13'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 13's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 13 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 2 Nils Philippsen 2011-06-01 09:39:21 UTC
I still see this issue with ufraw-0.18 on F-15. Changing version to keep this open.

Comment 3 Nils Philippsen 2011-06-01 10:01:30 UTC
This is the first commit in which I see problems with crop markings:

commit 0748998828b2f8a15e28e6e19d53c66d97608355
Author: udifuchs <udifuchs>
Date:   Sun Feb 21 10:03:55 2010 +0000

    Initial implimentation if lensfun with UFObjects.
    Lensfun model parameters are being saved to ID files, but not to .ufrawrc.
    These parameters will be also read from ID files, unless the ID file
    is used for --conf.
    UFRaw now applies lensfun automatically. Use --lensfun=none to disable.

 Makefile.am       |    4 +-
 uf_gtk.cc         |   69 ++++++---
 uf_gtk.h          |    1 +
 ufobject.cc       |  288 ++++++++++++++++++++++++++++++++++----
 ufobject.h        |   82 +++++++++--
 ufraw-batch.c     |   15 +--
 ufraw.c           |   15 +--
 ufraw.h           |   15 ++-
 ufraw_conf.c      |  114 ++++++++++++---
 ufraw_lens_ui.c   |  400 +++++++++++++++--------------------------------------
 ufraw_lensfun.cc  |  335 ++++++++++++++++++++++++++++++++++++++++++++
 ufraw_preview.c   |   32 +++--
 ufraw_settings.cc |   46 +++++--
 ufraw_ufraw.c     |   90 +++---------
 ufraw_ui.h        |    9 +-
 15 files changed, 1005 insertions(+), 510 deletions(-)

Note that here the aspect ratio of the crop markings is correct, they are just too small for the image.

Comment 4 Nils Philippsen 2011-06-01 10:07:37 UTC
This is the first commit in which I see crop markings with the wrong aspect ratio (portrait instead of landscape in my tests):

commit e132d5a799351dd0429cdddabfa2a19d3f2b0173
Author: udifuchs <udifuchs>
Date:   Fri Feb 26 07:01:04 2010 +0000

    Add ufFocalLength, ufAperture, ufDistance UFObjects.

 Doxyfile          |    4 +-
 uf_gtk.cc         |   49 ++++++++--
 uf_gtk.h          |    1 +
 ufobject.cc       |   37 +++++---
 ufobject.h        |    7 ++
 ufraw.h           |    6 +
 ufraw_lens_ui.c   |  198 ++++++---------------------------------
 ufraw_lensfun.cc  |  270 ++++++++++++++++++++++++++++++++++++++++++-----------
 ufraw_preview.c   |    6 +-
 ufraw_settings.cc |    9 +--
 ufraw_ufraw.c     |    1 -
 ufraw_ui.h        |   10 --
 12 files changed, 329 insertions(+), 269 deletions(-)

Comment 5 Nils Philippsen 2011-06-01 11:16:38 UTC
Submitted upstream at https://sourceforge.net/tracker/?func=detail&aid=3310116&group_id=127649&atid=709086

Comment 6 Nils Philippsen 2011-08-12 10:24:40 UTC
This is fixed in CVS upstream and I'm building patched packages right now.

Comment 7 Fedora Update System 2011-08-12 10:52:26 UTC
ufraw-0.18-3.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/ufraw-0.18-3.fc14

Comment 8 Fedora Update System 2011-08-12 10:52:31 UTC
ufraw-0.18-3.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/ufraw-0.18-3.fc16

Comment 9 Fedora Update System 2011-08-12 10:53:15 UTC
ufraw-0.18-3.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/ufraw-0.18-3.fc15

Comment 10 Fedora Update System 2011-08-13 02:26:18 UTC
Package ufraw-0.18-3.fc14:
* should fix your issue,
* was pushed to the Fedora 14 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing ufraw-0.18-3.fc14'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/ufraw-0.18-3.fc14
then log in and leave karma (feedback).

Comment 11 Fedora Update System 2011-08-23 04:31:49 UTC
ufraw-0.18-3.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2011-08-23 04:32:10 UTC
ufraw-0.18-3.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2011-08-23 20:37:15 UTC
ufraw-0.18-3.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.