Spec URL: http://ke4qqq.fedorapeople.org/spew.spec SRPM URL: http://ke4qqq.fedorapeople.org/spew-1.0.8-1.fc13.src.rpm Description: Spew is used to measure I/O performance of character devices, block devices, and regular files. It can also be used to generate high I/O loads to stress systems while verifying data integrity.
Looks good, some small comments: - list bins more explicit (like the mans) - list man like this: %{_mandir}/man1/gorge.1* - Group: Applications/Internet seems a bit strange? - remove leading space in second line in %description - nice if you could provide a scratch build
Thanks for taking a look! The scratch build uncovered a few BR problems. I fixed the remaining items Spec URL: http://ke4qqq.fedorapeople.org/spew.spec SRPM URL: http://ke4qqq.fedorapeople.org/spew-1.0.8-2.fc13.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2470085
Here are some more (minor) notes: - You can drop "Requires: ncurses" as none of the ncurses command-line tools seem to be used. The package containing the ncurses libraries (ncurses-libs) is added automatically as a dependency. - drop file INSTALL from %doc (it's not of much use in a binary package) - add a blank line between the %changlog revisions to increase legibility
- Dropped ncurses as a requires - dropped install from doc - added blank line between changelog entries Spec URL: http://ke4qqq.fedorapeople.org/spew.spec SRPM URL: http://ke4qqq.fedorapeople.org/spew-1.0.8-3.fc13.src.rpm
OK, the package looks fine now. I'm going to do the formal review.
Here's the formal review. Since I couldn't find any further issues, the package is ready now. $ rpmlint /var/lib/mock/fedora-13-x86_64/result/*.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. - GPLv2 according to source file headers [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum spew-1.0.8.tgz* 02058dd1814caa8c67b8405668e845b2 spew-1.0.8.tgz 02058dd1814caa8c67b8405668e845b2 spew-1.0.8.tgz.1 [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [.] MUST: If the package does not successfully compile, build or work ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: The spec file MUST handle locales properly. [.] MUST: Packages storing shared library files must call ldconfig in %post and %postun. [+] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: .so files (without suffix) must go in a -devel package. [.] MUST: devel packages must require the base package. [+] MUST: Packages must NOT contain any .la libtool archives. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) ... [+] SHOULD: The reviewer should test that the package builds in mock. [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. [+] SHOULD: The reviewer should test that the package functions as described. - seems to work properly [.] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Subpackages other than devel should require the base package. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin ... [+] SHOULD: your package should contain man pages for binaries/scripts. ---------------- Package APPROVED ----------------
Martin: Thanks for the review!! New Package SCM Request ======================= Package Name: spew Short Description: I/O performance measurement and load generation tool Owners: ke4qqq Branches: f12 f13 f14 el5 el6 InitialCC:
Git done (by process-git-requests).
spew-1.0.8-3.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/spew-1.0.8-3.fc12
spew-1.0.8-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/spew-1.0.8-3.fc14
spew-1.0.8-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/spew-1.0.8-3.fc13
spew-1.0.8-3.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update spew'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/spew-1.0.8-3.fc14
spew-1.0.8-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
spew-1.0.8-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
spew-1.0.8-3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.