Bug 634835

Created attachment 447916 [details]
Screenshot 2

Created attachment 447917 [details]
Screenshot 3

Hi,
I will go through all screenshots one by one.
Screenshot 3:
I checked both versions of system-config-kdump (upstream and downstream), looks like screenshot does not reflect latest translation done on 2010-07-23. 
PO file does not contain — entities.

https://translate.fedoraproject.org/projects/p/system-config-kdump/c/rhel6/view/po/ru.po

Yulia

(In reply to comment #4)
> Hi,
> I will go through all screenshots one by one.
> Screenshot 3:
> I checked both versions of system-config-kdump (upstream and downstream), looks
> like screenshot does not reflect latest translation done on 2010-07-23. 
> PO file does not contain — entities.
> 
> https://translate.fedoraproject.org/projects/p/system-config-kdump/c/rhel6/view/po/ru.po
> 
> Yulia

That was very quick. Thanks Yulia. Assigning the bug to you, once you figure out the fixes to upstream and downstream both, I will reassign the bug to the owner of the component.

Thanks!
Ankit

Screenshot 3:
Sorry about the confusion.
I have located the — in kexec-tools, upstream file was fine and I fixed the entity in the file downstream and committed changes.

Screenshots 1 and 2:

If I am not mistaken, those entries come from "rhn-client-tools".
I am not sure what is wrong with those two since English text also contains tags <b>.

Original English paragraph (screenshot 2):
---
You won't be able to receive software updates, including security updates, 
for this system.\n
\n
You may access the RHN registration tool by running <b>RHN Registration</b> 
in the <b>System > Administration</b> menu.\n
You may access the software update tool by running <b>Software Update</b> in 
the <b>System > Administration</b> menu.
---

I am not sure why they show in localized program. 
Should I just completely get rid of tags in translation or is there another way to fix it?

Thanks,
Yulia

thanks, it has following version (helpful for verify)
rhn-client-tools-1.0.0-38.el6.noarch

(In reply to comment #7)
> Screenshots 1 and 2:
> 
> If I am not mistaken, those entries come from "rhn-client-tools".
> I am not sure what is wrong with those two since English text also contains
> tags <b>.
> 
> Original English paragraph (screenshot 2):
> ---
> You won't be able to receive software updates, including security updates, 
> for this system.\n
> \n
> You may access the RHN registration tool by running <b>RHN Registration</b> 
> in the <b>System > Administration</b> menu.\n
> You may access the software update tool by running <b>Software Update</b> in 
> the <b>System > Administration</b> menu.
> ---
> 
> I am not sure why they show in localized program. 
> Should I just completely get rid of tags in translation or is there another way
> to fix it?
> 
> Thanks,
> Yulia

Hi Yulia,

I did check the translation file under downstream repo and the one actually available under the package available from rhel6, found a significant difference because the translations submitted to rhn-client-tools on 10th of August 2010 as a patch and accepted and built, while the translation file downstream updated last on 17th August 2010. That means your latest changes are not yet in the package. I need to make another patch grabbing your latest translations and get this bug fixed.

However, I do want you to cross-check the translations for the messages shown in the screenshots 1 & 2, because I found less '\n's in translations (msgstrs) while it's more in english (msgids).

Thanks!
Ankit

Hi Ankit,

I checked file again, I added couple of line breaks and slightly improved translation on these screens. That still does not explain why tags <b> render visible but if there is anything I can do to help, please let me know.

Also a question: Would you know where translation of "Software Updates" system menu item comes from? As in "System > Administration > Software Updates". I just wanted to double check it but not sure where to look.

Thank you,
Yulia

(In reply to comment #10)
> Hi Ankit,
> 
> I checked file again, I added couple of line breaks and slightly improved
> translation on these screens. That still does not explain why tags <b> render
> visible but if there is anything I can do to help, please let me know.

Please add some missing tags <b>.

> 
> Also a question: Would you know where translation of "Software Updates" system
> menu item comes from? As in "System > Administration > Software Updates". I
> just wanted to double check it but not sure where to look.

That comes from gnome-packagekit module.

> 
> Thank you,
> Yulia

Thanks!
Ankit

It's done, I believe having exactly the same number of tags in the same order fixed it.

I will provide a patch based on the corrections submitted by Yulia.

Btw, Alam can you please file a new bug for the screenshot 3 issue, that's against kexec-tools. This bug can remain there to fix issues mentioned in screenshot 1 & 2 against rhn-client-tools.

Thanks!
Ankit

Setting devel_ack (with fix depending on Ankit providing the patch).

I would provide fix for translations. Reassigning bug back to the owner of the component.

Thanks!
Ankit

Created attachment 465228 [details]
A patch to fix Russian (ru) translation issue for rhn-client-tools

Applying this patch should fix Russian (ru) translation issue for rhn-client-tools. Please make a new build applying this patch and help me get this bug fixed.

Thanks!
Ankit

It was caused by presence of — in translated string.

This strings is not present in upstream Spacewalk code.

Commiting only to satellite.git as commit c74a7f397bf3596a021f750230be9e2474045a80

There is still — in Kdump screen. The rest (bolds) was corrected.

(In reply to comment #20)
> There is still — in Kdump screen. The rest (bolds) was corrected.

Dear Martin,

An issue with — in Kdump screen, which is basically shown in attachment 447917 [details] (Screenshot 3 in attachments) is not an rhn-client-tools issue but kexec-tools issue. So, as I requested in comment #14, please file a new bug against kexec-tools in order to get it fixed.

Also please give this bug a 'green' to go ahead, as it's fixed I can see in the latest build.

Thanks!
Ankit Patel

I have created separate bug on Kdump - bug 679310. Closing this one as verified.

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0565.html