Created attachment 447968 [details] memcpy changed to memmove Description of problem: Occasionally when running svn over https, OPTION getting fails due to corrupted buffers, what we see in the logs are: 1.2.3.4 - user [17/Sep/2010:12:08:11 +0200] \ "ction-set/></D:options>OPTIONS /svn/path HTTP/1.1" 501 360 instead of: 1.2.3.4 - user [17/Sep/2010:12:08:11 +0200] \ "OPTIONS /svn/path HTTP/1.1" 200 199 Version-Release number of selected component (if applicable): 2.2.16-1.fc13 How reproducible: In approximately 10-20% of the checkout attempts Steps to Reproduce: 1. Configure a svn repository and try to checkout via https Actual results: Spurious: svn: Server sent unexpected return value (501 Method Not Implemented) in response to OPTIONS request for 'https://some.server/svn/path' Expected results: Clean checkouts always... Additional info: Others are bitten by this problem, and patch seems to have been lost somwhere i n the apache project. http://serverfault.com/questions/150976/problems-serving-svn-over-https-on-ubuntu-10-04 Attached patch is taken from the code in http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/ssl/ssl_engine_io.c?view=log&pathrev=683280
Thanks for the report. We put this patch in F14 already; curious it is coming up now, perhaps some toolchain change.
Could you try this build: https://koji.fedoraproject.org/koji/buildinfo?buildID=195746
Nope, (somewhat ironic given the subject at hand :-) ) What is in http://bugzilla.redhat.com/show_bug.cgi?id=634905 works like a charm though. BTW. Curious mind wants to know what the extra stuff in the httpd-2.2.16-pr45444.patch does. Will you push the patch upstream (if not already done)? Thanks!
Nope, (somewhat ironic given the subject at hand :-) ) What is in https://koji.fedoraproject.org/koji/buildinfo?buildID=195746 works like a charm though. BTW. Curious mind wants to know what the extra stuff in the httpd-2.2.16-pr45444.patch does. Will you push the patch upstream (if not already done)? Thanks!
It's hard to get links right :-( Nope, (somewhat ironic given the subject at hand :-) ) What is in http://koji.fedoraproject.org/koji/buildinfo?buildID=195746 works like a charm though. BTW. Curious mind wants to know what the extra stuff in the httpd-2.2.16-pr45444.patch does. Will you push the patch upstream (if not already done)? Thanks!
Uh. Does the build work, or not? The catch contains both the fix for the bug and a minor optimisation of the code; yes, these are both commits I made upstream a while back. http://svn.apache.org/viewvc?rev=683280&view=rev http://svn.apache.org/viewvc?rev=683283&view=rev
Yes, it works like a charm, I'm just lousy at cut and paste (and proofreading as well), sorry for all the wasted bandwidth/diskspace.
No problem. Thanks for verifying the fix.
httpd-2.2.17-1.fc13.1 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/httpd-2.2.17-1.fc13.1
httpd-2.2.17-1.fc13.1 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update httpd'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/httpd-2.2.17-1.fc13.1
Could you try the 2.2.17 build also? This has not been widely tested; testing instructions above.
httpd-2.2.17-1.fc13.1 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.