Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
For bugs related to Red Hat Enterprise Linux 5 product line. The current stable release is 5.10. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 635027

Summary: [RHEL5.6] Verify that driver version strings for updated network drivers
Product: Red Hat Enterprise Linux 5 Reporter: Andy Gospodarek <agospoda>
Component: kernelAssignee: Andy Gospodarek <agospoda>
Status: CLOSED ERRATA QA Contact: chen yuwen <yuchen>
Severity: medium Docs Contact:
Priority: low    
Version: 5.6CC: hjia, jolsa, lwang, peterm, sgruszka, yuchen
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-01-13 21:19:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
rhel5.6-driver-version-string-updates.patch none

Description Andy Gospodarek 2010-09-17 15:59:28 UTC 
Occasionally the upstream driver maintainers do not update the driver version string between what we shipped on the last y-stream update and now.

I'm going to verify that the strings changed between RHEL5.5 and RHEL5.6 or make sure to change them if code was changed and the string was not.  The plan will be to add "-N" to all drivers where 'N' will begin as '1' and increment when patches are added via z-stream.

Example for igb for RHEL5.6:

diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c
index fbfebf0..57c2db9 100644
--- a/drivers/net/igb/igb_main.c
+++ b/drivers/net/igb/igb_main.c
@@ -48,7 +48,7 @@
 #include <linux/pcieport_if.h>
 #include "igb.h"

-#define DRV_VERSION "2.1.0-k2"
+#define DRV_VERSION "2.1.0-k2-1"
 char igb_driver_name[] = "igb";
 char igb_driver_version[] = DRV_VERSION;
 static const char igb_driver_string[] =
Comment 1 RHEL Program Management 2010-09-17 16:20:02 UTC 
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.
Comment 2 Andy Gospodarek 2010-10-13 14:53:46 UTC 
Adding Stanislaw since he does the wireless patches.
Comment 3 Andy Gospodarek 2010-10-13 14:58:37 UTC 
Created attachment 453226 [details]
rhel5.6-driver-version-string-updates.patch

OK, I trolled through the driver changes for RHEL5.6 and have a patch ready.  

This should add a '-1' to the end of any driver version string if a patch was added to the driver that should resolve a specific bug.  Changes that were from a compatibility-layer change did not get version string updates.  If the driver maintainer already updated the string as part of a backport from RHEL5.5, no changes are needed to the driver version string.
Comment 6 Jarod Wilson 2010-10-28 20:08:40 UTC 
in kernel-2.6.18-229.el5
You can download this test kernel (or newer) from http://people.redhat.com/jwilson/el5

Detailed testing feedback is always welcomed.
Comment 8 chen yuwen 2010-11-29 06:42:27 UTC 
reviewed the patch and verified.
Comment 9 chen yuwen 2010-11-30 05:52:05 UTC 
verified on kernel 2.6.18-233.el5.

# modinfo igb
filename:       /lib/modules/2.6.18-233.el5/kernel/drivers/net/igb/igb.ko
version:        2.1.0-k2-1
...
Comment 11 errata-xmlrpc 2011-01-13 21:19:59 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0017.html