Bug 635197 - Cumin: Limits - Max Allowance, Unlimited
Summary: Cumin: Limits - Max Allowance, Unlimited
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise MRG
Classification: Red Hat
Component: cumin
Version: 1.3
Hardware: All
OS: Linux
medium
medium
Target Milestone: 2.0
: ---
Assignee: Trevor McKay
QA Contact: Jan Sarenik
URL:
Whiteboard:
Depends On:
Blocks: 693778
TreeView+ depends on / blocked
 
Reported: 2010-09-18 01:36 UTC by Matthew Farrellee
Modified: 2012-03-02 10:21 UTC (History)
5 users (show)

Fixed In Version: cumin-0.1.4654
Doc Type: Enhancement
Doc Text:
C: The Max Allowance limit value for a submission displayed as an integer even though the value is a float. Additionally, the default value for this limit intended to give "unlimited" behavior rendered as its explicit value. Consequently, the sense of "unlimited" was not communicated to the user. C: (see above). F: Changed the value to render as a float rather than an integer. Render values over 1000000 as "Unlimited". R: If the Max Allowance limit is set to a floating point value, that value will be accurately reflected in the table. Submissions with a default Max Allowance value or a very large Max Allowance value will display with a Max Allowance value of "Unlimited". Release Note Entry: Previously, the value for "Max Allowance" in Cumin was incorrectly displayed as an integer despite being a float value and "unlimited" was assigned as the default value instead of assigned to a specific limit. The "Max Allowance" value is correctly displayed as a float value and the "unlimited" value is now only assigned to values over 1,000,000.
Clone Of:
Environment:
Last Closed: 2011-06-23 15:40:04 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Max Allowance Screenshot (15.73 KB, image/png)
2010-09-18 01:36 UTC, Matthew Farrellee
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2011:0889 0 normal SHIPPED_LIVE Red Hat Enterprise MRG Grid 2.0 Release 2011-06-23 15:35:53 UTC

Description Matthew Farrellee 2010-09-18 01:36:00 UTC
Description of problem:

Limits that are not explicitly configured get a default value. That default value is designed to be "unlimited." In reality it is just a large integer value (2308032). These "Max Allowance"s should show up as "Unlimited." Maybe values over 1,000,000 should show up as "Unlimited."


Version-Release number of selected component (if applicable):

cumin-0.1.4279-1.el5.noarch

Comment 1 Matthew Farrellee 2010-09-18 01:36:30 UTC
Created attachment 448154 [details]
Max Allowance Screenshot

Comment 2 Trevor McKay 2011-03-21 13:39:33 UTC
Fixed in revision 4646.

Field now displays as float since Max Allowance limit in condor is a float.  Values above 1000000 render as "Unlimited"

Comment 3 Trevor McKay 2011-03-21 13:39:34 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause
    The Max Allowance limit value for a submission displayed as an integer even though the value is a float.  Additionally, the default value for this limit intended to give "unlimited" behavior rendered as its explicit value.  Consequently, the sense of "unlimited" was not communicated to the user.

Consequence
    (see above).

Fix
    Changed the value to render as a float rather than an integer.  Render values over 1000000 as "Unlimited".

Result
    If the Max Allowance limit is set to a floating point value, that value will be accurately reflected in the table. Submissions with a default Max Allowance value or a very large Max Allowance value will display with a Max Allowance value of "Unlimited".

Comment 4 Jan Sarenik 2011-03-22 11:40:26 UTC
Verified on cumin-0.1.4654-1.el5

CONCURRENCY_LIMIT_DEFAULT was unset during verification
and following shell script was run:
----------------------------------------------
getent passwd test || adduser test
echo Submitting a job
su - test -c "condor_submit $* << EOF
Executable     = /bin/sleep
Universe = vanilla
concurrency_limits = REALLYNOLIMIT
args    = 20m
queue 1
EOF"

Comment 5 Misha H. Ali 2011-05-27 07:32:23 UTC
    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1,11 +1,11 @@
-Cause
-    The Max Allowance limit value for a submission displayed as an integer even though the value is a float.  Additionally, the default value for this limit intended to give "unlimited" behavior rendered as its explicit value.  Consequently, the sense of "unlimited" was not communicated to the user.
+C: The Max Allowance limit value for a submission displayed as an integer even though the value is a float.  Additionally, the default value for this limit intended to give "unlimited" behavior rendered as its explicit value.  Consequently, the sense of "unlimited" was not communicated to the user.
 
-Consequence
-    (see above).
+C: (see above).
 
-Fix
-    Changed the value to render as a float rather than an integer.  Render values over 1000000 as "Unlimited".
+F: Changed the value to render as a float rather than an integer.  Render values over 1000000 as "Unlimited".
 
-Result
+R: If the Max Allowance limit is set to a floating point value, that value will be accurately reflected in the table. Submissions with a default Max Allowance value or a very large Max Allowance value will display with a Max Allowance value of "Unlimited".
-    If the Max Allowance limit is set to a floating point value, that value will be accurately reflected in the table. Submissions with a default Max Allowance value or a very large Max Allowance value will display with a Max Allowance value of "Unlimited".+
+Release Note Entry:
+
+Previously, the value for "Max Allowance" in Cumin was incorrectly displayed as an integer despite being a float value and "unlimited" was assigned as the default value instead of assigned to a specific limit. The "Max Allowance" value is correctly displayed as a float value and the "unlimited" value is now only assigned to values over 1,000,000.

Comment 7 errata-xmlrpc 2011-06-23 15:40:04 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHEA-2011-0889.html


Note You need to log in before you can comment on or make changes to this bug.