Bug 635238 - Ajaxterm wont work with firefox 3.6
Summary: Ajaxterm wont work with firefox 3.6
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Ajaxterm
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Ruben Kerkhof
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-09-18 10:38 UTC by Lakshmipathi
Modified: 2010-12-29 21:50 UTC (History)
2 users (show)

Fixed In Version: Ajaxterm-0.10-13.fc13
Clone Of:
Environment:
Last Closed: 2010-12-12 13:31:38 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Fix for sarissa.js and Firefox 3.6 (814 bytes, patch)
2010-10-11 10:34 UTC, Lakshmipathi
no flags Details | Diff
fix for severe security issue (5.06 KB, patch)
2010-10-11 10:35 UTC, Lakshmipathi
no flags Details | Diff
uft8 support (10.94 KB, patch)
2010-10-11 10:36 UTC, Lakshmipathi
no flags Details | Diff
bugfixes-tweaks-by-blt (5.73 KB, patch)
2010-10-11 10:40 UTC, Lakshmipathi
no flags Details | Diff

Description Lakshmipathi 2010-09-18 10:38:43 UTC
Description of problem:
I tested ajaxterm in fedora there it seems to working fine. i tested it from fedora13.from there i can't access the ajaxterm. I dropped a mail to ajaxterm debain maintainer (Julien). He replied with patch for firefox 3.6 version.

Could please check and apply some of the fixes enabled in the Debian package and missing fedora package ?

Version-Release number of selected component (if applicable):
Ajaxterm-0.10.9.fc12.noarch


How reproducible:
try with firefox 3.6 


Steps to Reproduce:
1.install ajaxterm
2.use firefox 3.5.10 - it works 
3.use firefox 3.6.3 - it won't work.
  
Actual results:
unable to view ajaxterm

Expected results:
accessing ajaxterm

Additional info:

Comment 1 Tom Stocker 2010-09-20 07:41:39 UTC
Hi there

had the same issue with Ajaxterm on Centos 5.5 (i guess). Unfortenately i've got no access to this sys from here to get the correct versions. As i remember ajaxterm was 0.10 from the repos.

But the solution was:

edit „sarissa.js“ line around 269, change

XMLDocument.prototype.readyState = 0;

to

// XMLDocument.prototype.readyState = 0

probably this will breake other things, but it worked for me as quick n dirty hack.

Comment 2 Tom Stocker 2010-09-20 07:44:40 UTC
oh and yes there was another issue if it wont start:

check the python version! and change the startstring.

/usr/bin/python >>>> 2.X <<<< /usr/share/ajaxterm/ajaxterm.py --port 8022 --log	

note also the --log option this will log some things to stdout.

cheers

Comment 3 Lakshmipathi 2010-09-20 08:00:56 UTC
thanks Tom.Here is the patch Julien sent me,instead of commenting out ,this patch uses try-catch.  Following patch worked for me.
------
This is a problem in sarissa, which can be fixed easily with this patch:
--- a/sarissa.js
+++ b/sarissa.js
@@ -265,7 +265,13 @@
            * <li>3 == INTERACTIVE,</li>
            * <li>4 == COMPLETED</li></ul>
            */
-            XMLDocument.prototype.readyState = 0;
+            try {
+                XMLDocument.prototype.readyState = 0;
+            } catch(e) {
+                // XXX on some browsers (Firefox 3.6 at least) this fails,
+                // however I think this is rarely a problem so we just
+                // ignore it here...
+            };
            /**
            * <p>Emulate IE's parseError attribute</p>
            */
------
You can get the list of other ajaxterm patches from here.
http://git.kirya.net/?p=ajaxterm.git

Comment 4 Lakshmipathi 2010-09-20 08:03:52 UTC
(In reply to comment #2)
> oh and yes there was another issue if it wont start:
> 
> check the python version! and change the startstring.
> 
> /usr/bin/python >>>> 2.X <<<< /usr/share/ajaxterm/ajaxterm.py --port 8022 --log 
> 
> note also the --log option this will log some things to stdout.
> 
> cheers

Sorry I can't understand this . Currently my python version is 2.6.2. Are you saying it won't version less than 2.6.2 or higher than 2.6.2? Just trying to understand ajaxterm issues little better. :)

Comment 5 Tom Stocker 2010-09-20 08:13:09 UTC
no but it may be possible that it tries to start a python interpreter which isn't available on the box (version mismatch). So just check /etc/init.d/ajaxterm if the given paython interpreter is really installed :)

Thanks for your patch, I'll try this tonight at home.

Comment 6 Tom Stocker 2010-09-21 12:23:18 UTC
forget about the python stuff above. I messed up some gentoo stuff with fedora stuff. all my fault. please ignore.

Ticket may be closed.

Comment 7 Lakshmipathi 2010-09-21 12:34:19 UTC
(In reply to comment #6)
> forget about the python stuff above. I messed up some gentoo stuff with fedora
> stuff. all my fault. please ignore.
> 
no problems 
> Ticket may be closed.
No :) though issue is fixed for me - Just awaiting response from Fedora Ajaxterm maintainers ,whether they will include,-if they already not included- patches available on debian,which will help other fedora users.

Comment 8 Ruben Kerkhof 2010-09-22 08:42:32 UTC
Thanks for your request. I'm willing to include the debian patches.
I'm a bit short on time though, so it can take a while. If you could help me a little by comparing the versions of Ajaxterm on Debian and Fedora and either attach the patches to this bz or check them into the fedora git repo that would be great.

Comment 9 Lakshmipathi 2010-09-22 08:48:57 UTC
sure,I'll checkout the difference between Debian and Ajaxterm version & submit the patches.where can i find ajaxterm fedora repo url  ?

Comment 11 Lakshmipathi 2010-10-11 10:34:32 UTC
Created attachment 452681 [details]
Fix for sarissa.js and Firefox  3.6

Comment 12 Lakshmipathi 2010-10-11 10:35:36 UTC
Created attachment 452682 [details]
fix for severe security issue

Comment 13 Lakshmipathi 2010-10-11 10:36:16 UTC
Created attachment 452683 [details]
uft8 support

Comment 14 Lakshmipathi 2010-10-11 10:40:45 UTC
Created attachment 452685 [details]
bugfixes-tweaks-by-blt

Comment 15 Lakshmipathi 2010-10-11 10:42:18 UTC
As i'm not sure about your git commit procedure.I addded them here.I found following patches from debian missing in fedora.Upload few (20,25,30,35) above. Let me know ,if you need the remaining patches ,if its applicable for fedora

> 05_ssh-port.diff
> 06_fix-IOError.diff
> 20_bugfixes-tweaks-by-blt.diff
> 25_CVE-2009-1629.diff
> 30_utf8-support.diff
> 35_fix-sarissa.diff
> 40_more-ctrl-catches.diff

Comment 16 Ruben Kerkhof 2010-10-11 12:42:37 UTC
Thanks for the patches!

I should have some spare time to create at least a package for rawhide this week.

Comment 17 Ruben Kerkhof 2010-10-17 17:19:38 UTC
Ok, I finally had some time today  to work on this, and did a major cleanup of the package.

I've added all Debian patches, and some documentation as well.

Please give it a try: http://koji.fedoraproject.org/koji/buildinfo?buildID=200804

Comment 18 Bug Zapper 2010-11-03 10:02:21 UTC
This message is a reminder that Fedora 12 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 12.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '12'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 12's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 12 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 19 Fedora Update System 2010-12-12 13:45:15 UTC
Ajaxterm-0.10-13.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/Ajaxterm-0.10-13.fc14

Comment 20 Fedora Update System 2010-12-12 13:54:32 UTC
Ajaxterm-0.10-13.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/Ajaxterm-0.10-13.fc13

Comment 21 Fedora Update System 2010-12-20 21:58:56 UTC
Ajaxterm-0.10-13.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 22 Fedora Update System 2010-12-29 21:50:26 UTC
Ajaxterm-0.10-13.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.