Bug 635379 - Review Request: perl-POSIX-strptime - Perl extension to the POSIX date parsing strptime(3) function
Summary: Review Request: perl-POSIX-strptime - Perl extension to the POSIX date parsin...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Emmanuel Seyman
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-09-19 10:31 UTC by Lubomir Rintel
Modified: 2010-11-03 10:17 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-11-03 10:17:51 UTC
Type: ---
Embargoed:
emmanuel: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Lubomir Rintel 2010-09-19 10:31:58 UTC
SPEC: http://v3.sk/~lkundrak/SPECS/perl-POSIX-strptime.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/perl-POSIX-strptime-0.10-1.el5_5.src.rpm

Description:

Perl interface to strptime(3).

Comment 1 Emmanuel Seyman 2010-10-27 19:11:28 UTC
Taking.

Comment 2 Emmanuel Seyman 2010-10-27 19:54:32 UTC
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the Packaging Guidelines including the Perl specific items
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2558476

 [!] Rpmlint output: 
perl-POSIX-strptime.x86_64: W: private-shared-object-provides /usr/lib64/perl5/vendor_perl/auto/POSIX/strptime/strptime.so strptime.so()(64bit)

 [x] Package is not relocatable.
 [x] Buildroot is correct
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: GPL+ or Artistic
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
74af1cf777bf20fba49e2d048171d966  POSIX-strptime-0.10.tar.gz

 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [-] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [-] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: rawhide-x86_64
 [x] Package should compile and build into binary rpms on all supported
architectures.
     Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2558476
 [x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT.
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [x] %check is present and the tests pass

Lubomir, filter out the provides with something like :
%filter_provides_in %{perl_vendorarch}/.*\.so$

and I'll approve the package.

Comment 4 Emmanuel Seyman 2010-10-30 09:22:11 UTC
Rpmlint output :
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Package builds and installs on F13.

APPROVED.

Comment 5 Lubomir Rintel 2010-11-02 18:56:22 UTC
Thanks!

New Package SCM Request
=======================
Package Name: perl-POSIX-strptime
Short Description: Perl extension to the POSIX date parsing strptime(3) function
Owners: lkundrak
Branches: f13 f14 el6

Comment 6 Kevin Fenzi 2010-11-03 03:57:55 UTC
Git done (by process-git-requests).

Comment 7 Lubomir Rintel 2010-11-03 10:17:51 UTC
Imported and built. Thanks!


Note You need to log in before you can comment on or make changes to this bug.