Bug 635383 - Review Request: perl-WWW-Salesforce - WWW::Salesforce Perl module
Summary: Review Request: perl-WWW-Salesforce - WWW::Salesforce Perl module
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-09-19 10:33 UTC by Lubomir Rintel
Modified: 2010-11-05 18:25 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-11-05 18:25:16 UTC
Type: ---
Embargoed:
mmaslano: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Lubomir Rintel 2010-09-19 10:33:40 UTC
SPEC: http://v3.sk/~lkundrak/SPECS/perl-WWW-Salesforce.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/perl-WWW-Salesforce-0.11-1.el5.src.rpm

Description:

This class provides a simple abstraction layer between SOAP::Lite and
Salesforce.com. Because SOAP::Lite does not support complexTypes, and
document/literal encoding is limited, this module works around those
limitations and provides a more intuitive interface a developer can
interact with.

Comment 1 Marcela Mašláňová 2010-10-27 15:57:50 UTC
koji build passed:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2557251

There's problem with license. I couldn't find it in source, it's only on web-page.

Also removing questions of Makefile.PL is unusual, but that's also this Makefile. So this is probably ok.

Comment 2 Lubomir Rintel 2010-10-27 17:30:32 UTC
(In reply to comment #1)
> There's problem with license. I couldn't find it in source, it's only on
> web-page.

Thank you for catching this. I notified upstream.

> Also removing questions of Makefile.PL is unusual, but that's also this
> Makefile. So this is probably ok.

I'm really not sure what you mean here.

Comment 3 Marcela Mašláňová 2010-11-02 16:46:29 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > There's problem with license. I couldn't find it in source, it's only on
> > web-page.
> 
> Thank you for catching this. I notified upstream.
> 
So what's now? Probably we should wait for license clarification.

> > Also removing questions of Makefile.PL is unusual, but that's also this
> > Makefile. So this is probably ok.
> 
> I'm really not sure what you mean here.

Nevermind.

Comment 4 Lubomir Rintel 2010-11-02 18:53:22 UTC
Licensing should be fixed here:

SPEC: http://v3.sk/~lkundrak/SPECS/perl-WWW-Salesforce.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/perl-WWW-Salesforce-0.13-1.fc13.src.rpm

Comment 6 Marcela Mašláňová 2010-11-03 10:15:03 UTC
GPL+ or Artistic is fine.

ACCEPT

Comment 7 Lubomir Rintel 2010-11-03 10:28:04 UTC
Thank you!

New Package SCM Request
=======================
Package Name: perl-WWW-Salesforce
Short Description: WWW::Salesforce perl module
Owners: lkundrak
Branches: f13 f14 el6

Comment 8 Jason Tibbitts 2010-11-05 17:30:26 UTC
Could we get a better Summary:/short description than just the name of the Perl module?

Comment 9 Lubomir Rintel 2010-11-05 17:51:13 UTC
Jason: Sure; I'll also modify that upon import of a package

New Package SCM Request
=======================
Package Name: perl-WWW-Salesforce
Short Description: Perl client bindings for Salesforce service
Owners: lkundrak
Branches: f13 f14 el6

Comment 10 Jason Tibbitts 2010-11-05 17:56:32 UTC
Git done (by process-git-requests).

Comment 11 Lubomir Rintel 2010-11-05 18:25:16 UTC
Thanks!
Imported and built.


Note You need to log in before you can comment on or make changes to this bug.