Bug 636107 - Review Request: perl-STD - The Standard Perl 6 Grammar
Summary: Review Request: perl-STD - The Standard Perl 6 Grammar
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 633750
TreeView+ depends on / blocked
 
Reported: 2010-09-21 14:22 UTC by Petr Pisar
Modified: 2010-09-22 17:46 UTC (History)
2 users (show)

Fixed In Version: perl-STD-32116-1.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-09-22 17:46:46 UTC
mmaslano: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Petr Pisar 2010-09-21 14:22:44 UTC
Spec URL: http://ppisar.fedorapeople.org/perl-STD/perl-STD.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-STD/perl-STD-32116-1.fc14.src.rpm
Description: The Standard Perl 6 Grammar.

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2479481

$ rpmlint perl-STD.spec ../SRPMS/perl-STD-32116-1.fc14.src.rpm ../RPMS/noarch/perl-STD-32116-1.fc14.noarch.rpm 
perl-STD.spec: W: no-cleaning-of-buildroot %clean
perl-STD.spec: W: no-buildroot-tag
perl-STD.spec: W: no-%clean-section
perl-STD.src: W: no-cleaning-of-buildroot %clean
perl-STD.src: W: no-buildroot-tag
perl-STD.src: W: no-%clean-section
2 packages and 1 specfiles checked; 0 errors, 6 warnings.

This is post-F12 spec file without BuildRoot. Rpmlint is not aware of it.

Some files contain private modules, thus they are filtered out. In contrast public perl(STD) Provides must be manually injected because rpmbuild cannot discover it.

$ rpm -pqlv ../RPMS/noarch/perl-STD-32116-1.fc14.noarch.rpm
-rwxr-xr-x    1 root    root                    97454 Sep 21 14:15 /usr/bin/viv
drwxr-xr-x    2 root    root                        0 Sep 21 14:15 /usr/share/doc/perl-STD-32116
-rw-r--r--    1 root    root                     9022 Aug 30 02:12 /usr/share/doc/perl-STD-32116/LICENSE
-rw-r--r--    1 root    root                     2232 Sep 21 14:15 /usr/share/man/man1/viv.1.gz
-rw-r--r--    1 root    root                    90098 Sep 21 14:15 /usr/share/perl5/CursorBase.pm
-rw-r--r--    1 root    root                      765 Sep 21 14:15 /usr/share/perl5/DEBUG.pm
-rw-r--r--    1 root    root                      580 Sep 21 14:15 /usr/share/perl5/NAME.pm
-rw-r--r--    1 root    root                    17163 Sep 21 14:15 /usr/share/perl5/RE_ast.pm
drwxr-xr-x    2 root    root                        0 Sep 21 14:15 /usr/share/perl5/STD
-rw-r--r--    1 root    root                  1506281 Sep 21 14:15 /usr/share/perl5/STD.pm
-rw-r--r--    1 root    root                     9390 Sep 21 14:15 /usr/share/perl5/STD/Actions.pm
-rw-r--r--    1 root    root                     3663 Sep 21 14:15 /usr/share/perl5/STD/Cursor.pm
-rw-r--r--    1 root    root                     6587 Sep 21 14:15 /usr/share/perl5/STD/LazyMap.pm
-rw-r--r--    1 root    root                   678233 Sep 21 14:15 /usr/share/perl5/STD_P5.pm
-rw-r--r--    1 root    root                      429 Sep 21 14:15 /usr/share/perl5/Stash.pm
drwxr-xr-x    2 root    root                        0 Sep 21 14:15 /usr/share/perl5/auto
drwxr-xr-x    2 root    root                        0 Sep 21 14:15 /usr/share/perl5/auto/share
drwxr-xr-x    2 root    root                        0 Sep 21 14:15 /usr/share/perl5/auto/share/dist
drwxr-xr-x    2 root    root                        0 Sep 21 14:15 /usr/share/perl5/auto/share/dist/STD
drwxr-xr-x    2 root    root                        0 Sep 21 14:15 /usr/share/perl5/auto/share/dist/STD/syml
-rw-r--r--    1 root    root                   424285 Sep 21 14:15 /usr/share/perl5/auto/share/dist/STD/syml/CORE.syml
-rw-r--r--    1 root    root                   144537 Sep 21 14:15 /usr/share/perl5/auto/share/dist/STD/syml/Cursor.syml
-rw-r--r--    1 root    root                   102676 Sep 21 14:15 /usr/share/perl5/auto/share/dist/STD/syml/CursorBase.syml
-rw-r--r--    1 root    root                     6412 Sep 21 14:15 /usr/share/perl5/auto/share/dist/STD/syml/DEBUG.syml
-rw-r--r--    1 root    root                    18660 Sep 21 14:15 /usr/share/perl5/auto/share/dist/STD/syml/NAME.syml
-rw-r--r--    1 root    root                  1911184 Sep 21 14:15 /usr/share/perl5/auto/share/dist/STD/syml/STD.syml
-rw-r--r--    1 root    root                    43979 Sep 21 14:15 /usr/share/perl5/auto/share/dist/STD/syml/Stash.syml
-rw-r--r--    1 root    root                    19283 Sep 21 14:15 /usr/share/perl5/auto/share/dist/STD/uniprops
-rw-r--r--    1 root    root                      630 Sep 21 14:15 /usr/share/perl5/mangle.pl

Comment 1 Marcela Mašláňová 2010-09-22 12:01:06 UTC
BR perl will make problems to RPM. Please remove or change to number.
installdirs s/vendor/perl/

Comment 2 Petr Pisar 2010-09-22 12:14:53 UTC
Oops. Old SRPM. The SPEC file has proper installdir. Actually installdir value should be `core'. Not `perl'. See `perldoc Module::Build'. Do you agree?

--- -   2010-09-22 12:13:41.855225992 +0200
+++ perl-STD.spec       2010-09-22 12:13:23.590425381 +0200
@@ -7,7 +7,7 @@
 URL:            http://search.cpan.org/dist/STD/
 Source0:        http://www.cpan.org/authors/id/S/SO/SOREAR/STD-%{version}.tar.gz
 BuildArch:      noarch
-BuildRequires:  perl >= 1:v5.10
+BuildRequires:  perl >= 4:5.10
 BuildRequires:  perl(File::ShareDir) >= 1.02
 BuildRequires:  perl(Module::Build) >= 0.3601
 BuildRequires:  perl(Moose)
@@ -33,7 +33,7 @@
 %setup -q -n STD-%{version}
 
 %build
-%{__perl} Build.PL installdirs=vendor
+%{__perl} Build.PL installdirs=core
 ./Build
 
 %install

Comment 3 Marcela Mašláňová 2010-09-22 13:45:58 UTC
Yes, core. Could you upload new srpm? I don't think there will be any other issues.

Comment 4 Petr Pisar 2010-09-22 13:55:56 UTC
Both files has been overwritten by new versions on the same location.

Comment 5 Petr Pisar 2010-09-22 16:35:41 UTC
New Package SCM Request
=======================
Package Name: perl-STD
Short Description: The Standard Perl 6 Grammar
Owners: ppisar mmaslano psabata
Branches: 
InitialCC: perl-sig

Comment 6 Kevin Fenzi 2010-09-22 16:59:45 UTC
Git done (by process-git-requests).

Comment 7 Petr Pisar 2010-09-22 17:46:46 UTC
Thank you for review and repository.


Note You need to log in before you can comment on or make changes to this bug.