Spec URL: http://sochotni.fedorapeople.org/packages/atinject.spec SRPM URL: http://sochotni.fedorapeople.org/packages/atinject-1-1.20100611svn86.fc15.src.rpm Description: This package specifies a means for obtaining objects in such a way as to maximize reusability, testability and maintainability compared to traditional approaches such as constructors, factories, and service locators (e.g., JNDI). This process, known as dependency injection, is beneficial to most nontrivial applications.
I'll take this one.
=== REQUIRED ITEMS === [!] Rpmlint output: atinject.noarch: W: spelling-error %description -l en_US reusability -> re usability, re-usability, usability atinject.noarch: W: spelling-error %description -l en_US locators -> allocators, allocator, locations Not a problem. atinject.noarch: W: incoherent-version-in-changelog 1-1.20101106svn86 ['1-1.20100611svn86.fc13', '1-1.20100611svn86'] Fix it. atinject.noarch: W: no-documentation atinject.noarch: W: non-conffile-in-etc /etc/maven/fragments/atinject Not a problem [X] Package is named according to the Package Naming Guidelines[1]. [X] Spec file name must match the base package name, in the format %{name}.spec. [X] Package meets the Packaging Guidelines[2]. [X] Package successfully compiles and builds into binary rpms. [X] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [X] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4]. [X] License field in the package spec file matches the actual license. License type: [_] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [_] All independent sub-packages have license of their own [X] Spec file is legible and written in American English. [_] Sources used to build the package matches the upstream source, as provided in the spec URL. [X ] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5]. [X] Package must own all directories that it creates. [X] Package requires other packages for directories it uses. [X] Package does not contain duplicates in %files. [X] Permissions on files are set properly. [X] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [X] Package consistently uses macros. [X] Package contains code, or permissable content. [_] Fully versioned dependency in subpackages, if present. [_] Package contains a properly installed %{name}.desktop file if it is a GUI application. [X] Package does not own files or directories owned by other packages. [X] Javadoc documentation files are generated and included in -javadoc subpackage [X] Javadoc subpackages have Require: jpackage-utils [X] Packages using maven have proper BuildRequires/Requires(post) on jpackage-utils [X] Packages using maven run %update_maven_depmap in %post/%postun [X] Package uses %global not %define [X] If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...) [X] If source tarball includes bundled jar/class files these need to be removed prior to building [X] All filenames in rpm packages must be valid UTF-8. === SUGGESTED ITEMS === [X] If possible use upstream build method (maven/ant/javac) [X] Use %{_mavenpomdir} macro for placing pom files instead of %{_datadir}/maven2/poms [X] Javadocs are placed in %{_javadocdir}/%{name} with %{_javadocdir}/%{name}-%{version} symlink [X] If package contains pom.xml files install it even when building with ant [_] If package uses "-Dmaven.test.skip=true" explain why it was needed in a comment [X] Avoid having BuildRequires on exact NVR unless necessary [X] Package has BuildArch: noarch (if possible) [X] Latest version is packaged. [X] Reviewer should test that the package builds in mock. === Issues === 1. Fix rpmlint issue.
Hmm, forgot to re-upload spec/srpm (I had that fixed locally) Spec URL: http://sochotni.fedorapeople.org/packages/atinject.spec SRPM URL: http://sochotni.fedorapeople.org/packages/atinject-1-1.20100611svn86.fc15.src.rpm
Thanks, this package is APPROVED.
Thanks for the review New Package CVS Request ======================= Package Name: atinject Short Description: Dependency injection specification for Java (JSR-330) Owners: sochotni Branches: InitialCC:
Git done (by process-git-requests).
Ah, forgot about that fedpkg bug 619979. Please create f14 branch to workaround this.
Can you add a Package Change Request here with that? http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure#Package_Change_Requests_for_existing_packages
Package Change Request ====================== Package Name: atinject Short Description: Dependency injection specification for Java (JSR-330) Owners: sochotni Branches: f14 devel InitialCC: Change requested due to fedpkg bug 619979
Ah, sorry...I got out of bed the wrong way I guess (disregard changes in description and initial CC) Package Change Request ====================== Package Name: atinject Owners: sochotni Branches: f14 devel Change requested due to fedpkg bug 619979
Git done
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2502910 Thanks again.