Spec URL: http://www.herr-schmitt.de/pub/gorm/gorm.spec SRPM URL: http://www.herr-schmitt.de/pub/gorm/gorm-1.2.12-1.fc13.src.rpm Description: Gorm is a acronym for GNUstep/Graphical Object Relationship Modeler, It is a clone of the NextStep 'Interface Builder' application for GNUstep With Gorm, a developer can build an interface very quickly and easily with no code.
Taking this; review to follow.
License field needs updating, a tiny spelling error, and the spec file needs to be untabified; after that this review can be approved * TODO Review [80%] ** DONE Names [2/2] *** DONE Package name *** DONE Spec name ** DONE Meets [[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]] ** DONE source files match upstream - md5sum: 7b068a369051f83d450d2a0dd464e8ee ** TODO License [2/3] *** DONE License is Fedora-approved *** FAIL License field accurate - Should be GPLv3+ not GPLv2+ *** DONE License included iff packaged by upstream ** TODO rpmlint [0/2] *** FAIL on src.rpm - gorm.src:12: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12) Minor problem, please untabify *** FAIL on x86_64.rpm - http://koji.fedoraproject.org/koji/taskinfo?taskID=2567020 - gorm.x86_64: W: no-manual-page-for-binary Gorm - can be ignored - gorm-devel.x86_64: W: no-documentation - can be ignored - gorm-doc.noarch: W: spelling-error %description -l en_US Thsi -> Thai, Th si, Th-si - this should be changed to "This" ** DONE Language & locale [3/3] *** DONE Spec in US English *** DONE Spec legible *** N/A Use %find_lang to handle locale files ** DONE Build [3/3] *** DONE Koji results *** DONE BRs complete *** DONE Directory ownership ** DONE Spec inspection [10/10] *** DONE ldconfig for libraries *** DONE No duplicate files *** DONE File permissions *** DONE Filenames must be UTF-8 *** DONE Has %clean section (except F-13+: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean) *** DONE %buildroot cleaned on %install *** DONE Macro usage consistent *** DONE Documentation [2/2] **** DONE If large docs, separate -doc **** DONE %doc files are non-essential *** DONE Development [5/5] **** DONE Headers in -devel **** DONE If versioned .so's, unversioned in -devel **** N/A Static only if necessary, put in -static **** DONE -devel, -static requires main **** DONE No .la *** N/A Other subpackages ** N/A Desktop file validation ** N/A [[http://fedoraproject.org/wiki/Packaging/ScriptletSnippets][Scriptlets]]
New release: SPEC URL: http://www.herr-schmitt.de/pub/gorm/gorm.spec SRPM URL: http://www.herr-schmitt.de/pub/gorm/gorm-1.2.12-2.fc13.src.rpm
Looks good; APPROVED
New Package SCM Request ======================= Package Name: gorm Short Description: The GNUstep graphical interface builder Owners: foo s4504kr Branches: f14 el6 InitialCC:
WARNING: "foo" is not a valid FAS account. WARNING: Requested package name gorm doesn't match bug summary Gorm Can you resubmit the request? If the package is 'gorm' can you change the bug summary to match?
New Package SCM Request ======================= Package Name: gorm Short Description: The GNUstep graphical interface builder Owners: s4504kr Branches: f14 el6 InitialCC:
Git done (by process-git-requests).
Not that it matters much, since it is soon going to go EOL, but this srpm fails in fc12: gcc GormFunctions.m -c \ -MMD -MP -DGNUSTEP -DGNUSTEP_BASE_LIBRARY=1 -DGNU_GUI_LIBRARY=1 -DGNU_RUNTIME=1 -DGNUSTEP_BASE_LIBRARY=1 -D_REENTRANT -fPIC -Wall -DGSWARN -DGSDIAGNOSE -Wno-import -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables -fno-strict-aliasing -fgnu-runtime -fconstant-string-class=NSConstantString -I.. -I. -I/home/kompoza/GNUstep/Library/Headers -I/usr/local/include -I/usr/include \ -o obj/GormCore.obj/GormFunctions.m.o GormFunctions.m: In function '_GSObjCMethodNamesForClass': GormFunctions.m:356: error: too many arguments to function 'GSObjCMethodNames' GormFunctions.m: In function '_GSObjCVariableNames': GormFunctions.m:371: error: too many arguments to function 'GSObjCVariableNames' make[4]: *** [obj/GormCore.obj/GormFunctions.m.o] Error 1 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [internal-library-all_] Error 2 make[2]: *** [GormCore.all.library.variables] Error 2 make[1]: *** [internal-all] Error 2 make[1]: Leaving directory `/home/kompoza/rpmbuild/BUILD/gorm-1.2.12/GormCore' make: *** [internal-all] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.ozzzDw (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.ozzzDw (%build)
Looks like the update in Bodhi fail to mention this ticket, and that's why the status has not changed: https://admin.fedoraproject.org/updates/gorm-1.2.12-2.fc14 Jochen, that update has been in testing for over 7 days; could you request it to be pushed to stable?