Bug 637092

+++ This bug was initially created as a clone of Bug #633498 +++

abrt version: 1.1.13
architecture: i686
Attached file: backtrace
cmdline: /usr/bin/readpst -o /home/diazfa/Inbox2/ -r /media/Preload/Folders/BackUpInbox.pst
comment: I have a windows partition in my laptop with a pst file that I wanted to be able to import into thunderbird.  I execute the readpst command to read a 1.5GB pst file
component: libpst
crash_function: pst_convert_utf8_null
executable: /usr/bin/readpst
kernel: 2.6.32.21-166.fc12.i686.PAE
package: libpst-0.6.47-2.fc12
rating: 4
reason: Process /usr/bin/readpst was killed by signal 11 (SIGSEGV)
release: Fedora release 12 (Constantine)
time: 1284409840
uid: 501

How to reproduce
-----
1.mount a windows partition
2.execute readpst 
3.

--- Additional comment from updates on 2010-09-13 22:29:55 GMT ---

libpst-0.6.49-1.fc12 has been submitted as an update for Fedora 12.
https://admin.fedoraproject.org/updates/libpst-0.6.49-1.fc12
---

This is fixed in libpst-0.6.49. No test-case exists (one would need to learn the pst format and to create the pst file with non-email objects manually).

The fix is trivial:

# HG changeset patch
# User Carl Byington <carl>
# Date 1284414429 25200
# Node ID ab87f9070ed280a36bee70172ece6980b3aa4a01
# Parent  fb66d428347d1c740fd614eedfd5c4c2ff7eb37e
fix to ignore embedded objects that are not email messages

--- a/src/readpst.c	Thu Sep 02 12:28:01 2010 -0700
+++ b/src/readpst.c	Mon Sep 13 14:47:09 2010 -0700
@@ -1012,9 +1012,13 @@
     if (!item) {
         DEBUG_WARN(("write_embedded_message: pst_parse_item was unable to parse the embedded message in attachment ID %llu", attach->i_id));
     } else {
-        fprintf(f_output, "\n--%s\n", boundary);
-        fprintf(f_output, "Content-Type: %s\n\n", attach->mimetype.str);
-        write_normal_email(f_output, "", item, MODE_NORMAL, 0, pf, 0, extra_mime_headers);
+        if (!item->email) {
+            DEBUG_WARN(("write_embedded_message: pst_parse_item returned type %d, not an email message", item->type));
+        } else {
+            fprintf(f_output, "\n--%s\n", boundary);
+            fprintf(f_output, "Content-Type: %s\n\n", attach->mimetype.str);
+            write_normal_email(f_output, "", item, MODE_NORMAL, 0, pf, 0, extra_mime_headers);
+        }
         pst_freeItem(item);
     }