Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 638052

Summary: online resize of LV/ext4 corrupts data
Product: Red Hat Enterprise Linux 6 Reporter: Afom T. Michael <tmichael>
Component: lvm2Assignee: Zdenek Kabelac <zkabelac>
Status: CLOSED ERRATA QA Contact: Corey Marthaler <cmarthal>
Severity: high Docs Contact:
Priority: urgent    
Version: 6.0CC: agk, benl, coughlan, ddumas, dwysocha, esandeen, heinzm, jbrassow, mbroz, plyons, prajnoha, prockai, rwheeler, syeghiay
Target Milestone: rcKeywords: ZStream
Target Release: ---   
Hardware: i386   
OS: Linux   
Whiteboard:
Fixed In Version: lvm2-2.02.82-1.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 643365 (view as bug list) Environment:
Last Closed: 2011-05-19 14:26:48 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 641461    
Attachments:
Description Flags
sosreport after a reboot none

Comment 6 Eric Sandeen 2010-09-28 13:41:54 UTC
This can be trivially reproduced:

# touch pvfile
# truncate --size 12g pvfile 
# losetup /dev/loop0 pvfile
# pvcreate /dev/loop0
# vgcreate testvg /dev/loop0
# lvcreate -L 4g testvg
# mkfs.ext4 /dev/mapper/testvg-lvol0 
# mkdir -p /mnt/test
# mount /dev/mapper/testvg-lvol0 /mnt/test

then:

# lvextend -L +10G -r /dev/mapper/testvg-lvol0 
fsck from util-linux-ng 2.17.2
e2fsck 1.41.10 (10-Feb-2009)
/dev/mapper/testvg-lvol0 is mounted.  

WARNING!!!  Running e2fsck on a mounted filesystem may cause
SEVERE filesystem damage.

Do you really want to continue (y/n)?

At this point the administrator is one character away from clobbering their filesystem.

The lvm tools should not be attempting to run fsck on a mounted device.

Comment 7 Ric Wheeler 2010-09-29 07:47:14 UTC
I think that we should also look at removing the check for fsck before resizing. Seems to be similar to the run fsck every X boots theory, but hard coded here.

Comment 8 Zdenek Kabelac 2010-09-29 09:41:55 UTC
This code has been developed in 'dark' history of online resizing of ext2 & ext3 filesystem where some strange combination of needed checks were necessary.

lvextend obviously does support online resize without fs check involved - with usage of the option '-n' - but the code to force fsck has been left in. 

I'll go through possible code paths and try to eliminate unwanted fsck calls and rather bailout whole command instead as some users may probably ignore those warning messages.

What would help a lot is that when fs is unmounted - check shouldn't be necessary.

Comment 9 Eric Sandeen 2010-09-29 14:06:59 UTC
(In reply to comment #8)

> What would help a lot is that when fs is unmounted - check shouldn't be
> necessary.

agreed, and for most filesystems it is not.

I'd just remove anything check-related at least for those filesystems that don't require it (xfs, I don't know about reiserfs...)

I can see about removing it for extN but upstream is paranoid.

The most pressing issue to fix here ASAP though, is not to bring the admin within an inch of corruption by starting a fsck on a -mounted- filesystem, that is hopefully something that can be fixed and pushed out right away.

-Eric

Comment 10 Zdenek Kabelac 2010-09-29 14:41:13 UTC
Well the problem is fsadm tool is not working properly udev  dev linkage and misdetects mounted system.

Working on fix...

Comment 15 Denise Dumas 2010-10-04 17:09:38 UTC
Based on comment 10, should this be assigned to component fsadm?  Or are there both fsadm and lvm changes needed?

Comment 16 Milan Broz 2010-10-04 17:14:46 UTC
fsadm is part of lvm2 package, there is no separate component for it.

Comment 18 Zdenek Kabelac 2010-10-08 15:05:53 UTC
This bug is being addressed in this upstream commit:

https://www.redhat.com/archives/lvm-devel/2010-October/msg00038.html

Comment 22 Corey Marthaler 2011-03-08 21:30:04 UTC
Fix verified in the latest rpms.

2.6.32-114.0.1.el6.x86_64

lvm2-2.02.83-2.el6    BUILT: Tue Feb  8 10:10:57 CST 2011
lvm2-libs-2.02.83-2.el6    BUILT: Tue Feb  8 10:10:57 CST 2011
lvm2-cluster-2.02.83-2.el6    BUILT: Tue Feb  8 10:10:57 CST 2011
udev-147-2.33.el6    BUILT: Wed Feb  9 09:56:24 CST 2011
device-mapper-1.02.62-2.el6    BUILT: Tue Feb  8 10:10:57 CST 2011
device-mapper-libs-1.02.62-2.el6    BUILT: Tue Feb  8 10:10:57 CST 2011
device-mapper-event-1.02.62-2.el6    BUILT: Tue Feb  8 10:10:57 CST 2011
device-mapper-event-libs-1.02.62-2.el6    BUILT: Tue Feb  8 10:10:57 CST 2011
cmirror-2.02.83-2.el6    BUILT: Tue Feb  8 10:10:57 CST 2011


SCENARIO - [fsadm_resize]
Create mirror, add fs, and then resize it while online
grant-01: lvcreate -m 1 -n fsadm_resize -L 200M --nosync mirror_sanity
  WARNING: New mirror won't be synchronised. Don't read what you didn't write!
Placing an ext on fsadm_resize volume
mke2fs 1.41.12 (17-May-2010)
Resize both the mirror and the fs with lvextend -r option on grant-01
resize2fs 1.41.12 (17-May-2010)
Deactivating mirror fsadm_resize... and removing

Comment 23 errata-xmlrpc 2011-05-19 14:26:48 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0772.html