Spec URL: http://jpanoramamaker.wz.cz/fedora/jpanoramamaker.spec SRPM URL: http://jpanoramamaker.wz.cz/fedora/jpanoramamaker-5.1.src.tar.gz (or https://koji.fedoraproject.org/koji/taskinfo?taskID=2496498) Description: Tool for stitching photos to panorama in linear curved space This is my first package and I'm looking for sponsor.
I'll take this one.
Can you provide the src.rpm file?
https://koji.fedoraproject.org/koji/getfile?taskID=2496498&name=jpanoramamaker-5-1.fc15.src.rpm
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [ ] Rpmlint output: jpanoramamaker.noarch: W: no-manual-page-for-binary jpanoramamaker jpanoramamaker-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Javanese Not a problem. [X] Package is named according to the Package Naming Guidelines. [X] Spec file name must match the base package name, in the format %{name}.spec. [X] Package meets the Packaging Guidelines. [X] Package successfully compiles and builds into binary rpms. [X] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [X] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4]. [X] License field in the package spec file matches the actual license. License type: [X] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [X] All independent sub-packages have license of their own [X] Spec file is legible and written in American English. [X] Sources used to build the package matches the upstream source, as provided in the spec URL. [X] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5]. [X] Package must own all directories that it creates. [X] Package requires other packages for directories it uses. [X] Package does not contain duplicates in %files. [X] Permissions on files are set properly. [X] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [X] Package consistently uses macros. [X] Package contains code, or permissable content. [X] Fully versioned dependency in subpackages, if present. [!] Package contains a properly installed %{name}.desktop file if it is a GUI application. [X] Package does not own files or directories owned by other packages. [X] Javadoc documentation files are generated and included in -javadoc subpackage [X] Packages have proper BuildRequires/Requires on jpackage-utils [X] Javadoc subpackages have Require: jpackage-utils [X] Package uses %global not %define [X] If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...) [X] If source tarball includes bundled jar/class files these need to be removed prior to building [X] All filenames in rpm packages must be valid UTF-8. === Other suggestions === [X] If possible use upstream build method (maven/ant/javac) [X] Javadocs are placed in %{_javadocdir}/%{name} with %{_javadocdir}/%{name}-%{version} symlink [X] If package contains pom.xml files install it (including depmaps) even when building with ant [X] Avoid having BuildRequires on exact NVR unless necessary [X] Package has BuildArch: noarch (if possible) [X] Latest version is packaged. [X] Reviewer should test that the package builds in mock. === Issues === 1. Missing desktop file for a GUI application.
updated SRPM http://koji.fedoraproject.org/koji/getfile?taskID=2496851&name=jpanoramamaker-5-1.fc15.src.rpm in http://koji.fedoraproject.org/koji/taskinfo?taskID=2496850
There are 2 problems: 1. You haven't added a changelog entry describing your change and haven't bump Release. You have to do that on every change. 2. desktop file and icon are installed as exectables which is wrong. Please use the default permissions
repaired SRPM: http://koji.fedoraproject.org/koji/getfile?taskID=2503154&name=jpanoramamaker-5-2.fc15.src.rpm for http://koji.fedoraproject.org/koji/taskinfo?taskID=2503153
Thanks, This package is APPROVED.
Sponsored.
New Package SCM Request ======================= Package Name: jpanoramamaker Short Description: Tool for stitching photos to panorama in linear curved space. Owners: jvanek Branches: f12 f13 f14 InitialCC: jvanek
Git done (by process-git-requests).
all builds on koji passed.
jpanoramamaker-5-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/jpanoramamaker-5-2.fc14
jpanoramamaker-5-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/jpanoramamaker-5-2.fc13
jpanoramamaker-5-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
jpanoramamaker-5-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.