... is there really a reason to have multiple alternatives here? Just pick one and ship one.

At first jwhois has been unusable in Red Hat corporate network because of bug #624608. Secondly, why do not enable competition of concurrent software? At third, jwhois misses some features (like requesting raw unfiltered data). And last but not least, I like Marco's client and I maintain its Czech translation.

Then either fix jwhois, or ship whois. Forcing people to compare and pick which sets of bugs they would prefer to deal with is just silly.

Yeah, one foo suits to all of them. Where did I heard it :)

Have you compared the two sets? Is jwhois with last release in year 2007 with 5 patches on top superior to Marco's whois released on August, 2010? (And I did not compare list of TLD whois servers which must be really out-dated.)

Poor user could be confused by selecting between two whois clients. Have you considered removing all web clients in favour to one implementation from Fedora? That would be great idea!

I'm saying if this new one is clearly better, we should just switch to it, and leave jwhois as jwhois if someone really wants to maintain it (no alternatives). It's a whois client, it's not a web browser.

I'd definitely opt for replacing jwhois with whois since jwhois seems to be dead upstream.
I'd also be willing to take the review in this case.

jwhois packager accepted my patch for package alternation in Fedora 15
(https://koji.fedoraproject.org/koji/buildinfo?buildID=204302).

Feel free to start reviewing.

Will do!

Package Review
==============

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[x]  Package is named according to the Package Naming Guidelines.
[x]  Spec file name must match the base package %{name}, in the format %{name}.spec.
[x]  Package meets the Packaging Guidelines.
[x]  Package successfully compiles and builds into binary rpms on at least one supported architecture.
Tested on: i686 x86_64
[x]  Rpmlint output:
	whois.src: W: no-cleaning-of-buildroot %install
	whois.src: W: no-cleaning-of-buildroot %clean
	whois.src: W: no-buildroot-tag
	whois.src: W: no-%clean-section
	Which is okay for F14
[x]  Package is not relocatable.
[-]  Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
[x]  Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines.
[x]  License field in the package spec file matches the actual license.
License type:
[x]  If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
[x]  Spec file is legible and written in American English.
[?]  Sources used to build the package matches the upstream source, as provided in the spec URL.
[x]  Package is not known to require ExcludeArch
[x]  All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines.
[x]  The spec file handles locales properly.
[-]  ldconfig called in %post and %postun if required.
[x]  Package must own all directories that it creates.
[-]  Package requires other packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  Permissions on files are set properly.
[-]  Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
[x]  Package consistently uses macros.
[x]  Package contains code, or permissable content.
[-]  Large documentation files are in a -doc subpackage, if required.
[x]  Package uses nothing in %doc for runtime.
[-]  Header files in -devel subpackage, if present.
[-]  Static libraries in -devel subpackage, if present.
[-]  Package requires pkgconfig, if .pc files are present.
[-]  Development .so files in -devel subpackage, if present.
[-]  Fully versioned dependency in subpackages, if present.
[-]  Package does not contain any libtool archives (.la).
[-]  Package contains a properly installed %{name}.desktop file if it is a GUI application.
[x]  Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
[!]  Latest version is packaged.
[x]  Package does not include license text files separate from upstream.
[-]  Description and summary sections in the package spec file contains translations for supported Non-English languages, if available.
[x]  Reviewer should test that the package builds in mock.
Tested on: F14 x86_64
[x]  Package should compile and build into binary rpms on all supported architectures.
Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2643314
[x]  Package functions as described.
[x]  Scriptlets must be sane, if used.
[-]  The placement of pkgconfig(.pc) files are correct.
[-]  File based requires are sane.


=== Issues ===
1. The version packaged is not the latest. For some reason the upstream tarball for the packaged version have vanished from the upstream mirror. Therefor I didn't check the sha1sums of the sources.

=== Final Notes ===
1. So far this package looks good but for a final statement on approval the packaged version needs to be updated.

Latest 5.0.10 version:

Spec URL: http://ppisar.fedorapeople.org/whois/whois.spec
SRPM URL: http://ppisar.fedorapeople.org/whois/whois-5.0.10-1.fc14.src.rpm

Spec file changes:
--- whois.spec.1	2010-09-29 17:18:21.000000000 +0200
+++ whois.spec	2010-12-06 12:55:23.102270950 +0100
@@ -1,5 +1,5 @@
 Name:       whois       
-Version:    5.0.7
+Version:    5.0.10
 Release:    1%{?dist}
 Summary:    Improved WHOIS client
 
@@ -76,6 +76,9 @@
 
 
 %changelog
+* Mon Dec 06 2010 Petr Pisar <ppisar@redhat.com> - 5.0.10-1
+- 5.0.10 bump
+
 * Wed Sep 29 2010 Petr Pisar <ppisar@redhat.com> - 5.0.7-1
 - 5.0.7 imported
 

Binary differences:
$ rpmdiff -i S -i 5 -i T whois-5.0.{7,10}-*
removed     REQUIRES config(whois) = 5.0.7-1.fc13
added       REQUIRES config(whois) = 5.0.10-1.fc14
removed     PROVIDES config(whois) = 5.0.7-1.fc13
removed     PROVIDES whois(x86-64) = 5.0.7-1.fc13
added       PROVIDES config(whois) = 5.0.10-1.fc14
added       PROVIDES whois(x86-64) = 5.0.10-1.fc14
added       /usr/share/doc/whois-5.0.10
added       /usr/share/doc/whois-5.0.10/COPYING
added       /usr/share/doc/whois-5.0.10/README
added       /usr/share/doc/whois-5.0.10/changelog
added       /usr/share/doc/whois-5.0.10/copyright
removed     /usr/share/doc/whois-5.0.7
removed     /usr/share/doc/whois-5.0.7/COPYING
removed     /usr/share/doc/whois-5.0.7/README
removed     /usr/share/doc/whois-5.0.7/changelog
removed     /usr/share/doc/whois-5.0.7/copyright

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2646576


Upstream changelog updates:

whois (5.0.10) unstable; urgency=medium

  * Added new IPv4 allocations.

 -- Marco d'Itri <md@linux.it>  Tue, 30 Nov 2010 23:51:59 +0100

whois (5.0.9) unstable; urgency=low

  * Added new IPv4 allocations.

 -- Marco d'Itri <md@linux.it>  Sun, 12 Nov 2010 22:24:42 +0100

whois (5.0.8) unstable; urgency=medium

  * Added the .xn--fzc2c9e2c (.ලංකා, Sri Lanka, Sinhala), .xn--mgbayh7gpa
    (.الاردن, Jordan) and .xn--pgbs0dh (.تونس, Tunisia) domains.
  * Added the .xn--o3cw4h (.ไทย, Thailand) and .xn--ygbi2ammx (.فلسطين,
    Palestinian Territory) TLD servers.
  * Updated the .bd and .ps TLD servers.
  * Removed the .lk TLD server.


Thank you for the review.

Any interest in finishing this review?

Sorry, I totally missed it.

I just did a short check if there is anything that changed between my review and the update and everything is still fine.

In the meantime a new version (5.11) of whois was released. I checked it locally by just bumping the version and it did not introduce anything that would block an approval. So before importing just update to this version.

This package is APPROVED!

New Package SCM Request
=======================
Package Name: whois
Short Description: Improved WHOIS client
Owners: ppisar
Branches: f15
InitialCC:

Git done (by process-git-requests).

Thanks to all of you for getting this package into Fedora.

whois-5.0.11-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/whois-5.0.11-1.fc15

whois-5.0.11-1.fc15 has been pushed to the Fedora 15 stable repository.