Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
For bugs related to Red Hat Enterprise Linux 5 product line. The current stable release is 5.10. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 639028

Summary: [Emulex 5.6 feat] Update lpfc driver to version 8.2.0.85
Product: Red Hat Enterprise Linux 5 Reporter: Vaios Papadimitriou <vaios.papadimitriou>
Component: kernelAssignee: Rob Evers <revers>
Status: CLOSED ERRATA QA Contact: Red Hat Kernel QE team <kernel-qe>
Severity: high Docs Contact:
Priority: high    
Version: 5.6CC: andriusb, bdonahue, bzeranski, cvantuin, cward, dhoward, joseph.mann, jwest, laurie.barry, marting, revers
Target Milestone: rcKeywords: FutureFeature, OtherQA, ZStream
Target Release: 5.6   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-01-13 21:56:01 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 557597, 624394, 633231, 658378    
Attachments:
Description Flags
Patchset to update Emulex LPFC driver to 8.2.0.85 (applies on top of 8.2.0.80) none

Description Vaios Papadimitriou 2010-09-30 16:27:07 UTC
Created attachment 450805 [details]
Patchset to update Emulex LPFC driver to 8.2.0.85 (applies on top of 8.2.0.80)

Patchset to update Emulex LPFC driver to 8.2.0.85 (applies on top of 8.2.0.80. See BZ 619917).

The attached tarball contains:

1. The set of patches; each patch corresponds to an individual fix as per agreement.

2. A README file that describes the patch naming scheme, and directions and instructions on how to apply the patches.

3. The ChangeLog of the fixes included in this patchset.


The corresponding patches have been submitted upstream. Note that this is here for comment purposes only as to indicate the corresponding upstream submission:
 
-----Original Message-----
From: linux-scsi-owner.org [linux-scsi-owner.org] On Behalf Of Smart, James
Sent: Wednesday, September 29, 2010 11:19 AM
To: linux-scsi.org
Subject: [PATCH 0/6] lpfc 8.3.17: Update lpfc to revision 8.3.17


This patch set updates the lpfc driver to revision 8.3.17

The patches for 8.3.17 contain:
- Code Cleanup and Locking fixes
- SLI Additions and Fixes
- BSG fixes
- SCSI fixes
- Replace function reset methodology
- Update lpfc driver version to 8.3.17

The bugfixes were cut against scsi-misc-2.6

-- james s

Comment 3 Rob Evers 2010-10-25 15:49:01 UTC
While testing this version of the lpfc driver using dt over the weekend, 2/4 dt processes stopped without any indication why.  The log files were simply truncated in the middle of messages being written to them.  There was nothing in /var/log/messages at the time the dt log files stopped getting updated.

Host is a dl585-g5

Emulex adapter is Emulex Corporation Saturn-X: LightPulse Fibre Channel Host Adapter (rev 03)

[root@cornucopia host0]# cat fwrev
2.00N9 (U3D2.00N9), sli-3

Vaios,

Should I update the firmware image?

Thanks, Rob

Comment 4 Vaios Papadimitriou 2010-10-25 18:15:03 UTC
I would think you are using the LPe1205 mezz cards, is that correct?

For the Saturn HBAs you should be using the latest released 2.00a3 version.  Version 2.00N9 was an OEM early evaluation build.

-Vaios-

Comment 5 Rob Evers 2010-10-26 15:43:06 UTC
(In reply to comment #4)
> I would think you are using the LPe1205 mezz cards, is that correct?
> 
> For the Saturn HBAs you should be using the latest released 2.00a3 version. 
> Version 2.00N9 was an OEM early evaluation build.
> 
> -Vaios-

I changed the firmware as you suggested, changed lpfc_use_msi=2, and restarted the test yesterday.  Similar result occurred.  I don't know if this occurs with the previous rev of the driver but can try that today.

[root@cornucopia ~]# cat /sys/class/scsi_host/host0/modeldesc 
Emulex LPe12002-M8 8Gb 2-port PCIe Fibre Channel Adapter

[root@cornucopia ~]# cat /sys/class/scsi_host/host0/fwrev 
2.00A3 (U3D2.00A3), sli-3

[root@cornucopia ~]# cat /sys/class/scsi_host/host0/lpfc_use_msi
2

[root@cornucopia ~]# cat /sys/class/scsi_host/host0/lpfc_drvr_version 
Emulex LightPulse Fibre Channel SCSI driver 8.2.0.85

Comment 6 Rob Evers 2010-10-26 21:39:12 UTC
(In reply to comment #5)
> I don't know if this occurs with
> the previous rev of the driver but can try that today.
> 

Cleared out some leftover disk state that was tripping up selinux.  Previous problem is unrelated to lpfc driver update.

Comment 7 Rob Evers 2010-10-27 15:12:32 UTC
After comparing this patchset to lpfc w/ posted updates on linux-scsi 8.3.17, I noticed some differences between this patch set and upstream driver.

Please ensure that all applicable bug fixes are posted upstream as well if they haven't been already.  I haven't had a chance to see if any of the missing functionality is in the latest lpfc posting on linux-scsi (8.3.18).

I will be posting this internally assuming Emulex has or will synchronize this patchset w/ upstream.

Missing upstream:

r8801_r8800_CR106902.patch
r8832_r8828.patch, r8847_r8846.patch- does something like this apply upstream?
r8889_r8875.patch
r8956_r8934_CR109954.patch
r8957_r8935_CR110048.patch
r8958_r8955_CR110237.patch
r9021.patch - mostly there, upstream has spin_lock vs. spin_lock_irq
r9022_r9005.patch missing upstream
r9036.patch beginning is missing upstream, stopped checking
r9102_CR110251.patch // ioctl code doesn't apply upstream.
r9178_r9176_CR110521.patch - Contents below missing upstream:
@@ -7443,10 +7325,14 @@ lpfc_sli4_unset_hba(struct lpfc_hba *phb 

        phba->pport->work_port_events = 0; 

-       lpfc_sli4_hba_down(phba); 
+       /* Stop the SLI4 device port */ 
+       lpfc_stop_port(phba); 

        lpfc_sli4_disable_intr(phba); 

+       /* Reset SLI4 HBA FCoE function */ 
+       lpfc_pci_function_reset(phba); 
+

Comment 36 Jarod Wilson 2010-11-01 21:00:14 UTC
in kernel-2.6.18-230.el5
You can download this test kernel (or newer) from http://people.redhat.com/jwilson/el5

Detailed testing feedback is always welcomed.

Comment 38 Andrius Benokraitis 2010-11-15 19:02:07 UTC
*** Bug 624394 has been marked as a duplicate of this bug. ***

Comment 44 Chris Ward 2010-12-02 15:27:10 UTC
Reminder! There should be a fix present for this BZ in snapshot 3 -- unless otherwise noted in a previous comment.

Please test and update this BZ with test results as soon as possible.

Comment 46 errata-xmlrpc 2011-01-13 21:56:01 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0017.html