Red Hat Bugzilla – Bug 63911
CVS crash if .cvspass not accessible
Last modified: 2007-04-18 12:42:14 EDT
Description of Problem:
Cvs (client side when using pserver) is crashing if the .cvspass
file is not accessible.
Version-Release number of selected component (if applicable):
The easy way is to change the HOME environment variable to a
non-existent or unreadable directory. Then try any cvs
command that tries to access a pserver.
Same thing has happened when I tried a cvs command from
sudo (it does not change $HOME, so the target user cannot
Segmentation fault (core dumped)
The problem is in cvs-1.11.1p1-cvspass.patch (fromn the RedHat SRPM):
+ fp = CVS_FOPEN (passfile, "w");
+ fclose (fp);
If the fopen failed then the fclose will segfault.
Created attachment 54804 [details]
Suggested patch (apply after cvs-1.11.1p1-cvspass.patch)
cvs-1.11.17-cvspass.patch contains this fix.