Spec URL: http://peter.fedorapeople.org/erlang-lfe.spec SRPM URL: http://peter.fedorapeople.org/erlang-lfe-0.6.1-1.fc12.src.rpm Description: Lisp Flavoured Erlang, is a lisp syntax front-end to the Erlang compiler. Code produced with it is compatible with "normal" Erlang code. An LFE evaluator and shell is also included. One of the requirements ("soft-dependency") for erlang-rebar koji scratch build for F-14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2505856 rpmlint: Sulaco ~/rpmbuild/SPECS: rpmlint ../RPMS/ppc/erlang-lfe-0.6.1-1.fc12.ppc.rpm erlang-lfe.ppc: E: explicit-lib-dependency erlang-stdlib erlang-lfe.ppc: E: no-binary erlang-lfe.ppc: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 2 errors, 1 warnings. Sulaco ~/rpmbuild/SPECS All these messages may be omitted (first one is a false positive due to "lib" substring in the name of one of the runtime dependency, the rest are due to fact that arch-independent data is installed into arch-dependent directory)
Some prereview comments: 1,) A better explanation of how you have generate the upstram archive may be helpful 2.) It may be nice, if you can create emacs-* subpackages.
Item 1 has been clarified for me.
(In reply to comment #1) > 2.) It may be nice, if you can create emacs-* subpackages. Yes, indeed. I'll try to provide them (unfortunately I'm not an emacs user, so I can't test them).
(In reply to comment #3) > (In reply to comment #1) > > > 2.) It may be nice, if you can create emacs-* subpackages. > > Yes, indeed. I'll try to provide them (unfortunately I'm not an emacs user, so > I can't test them). Unfortunately that was harder that I thought initially. So I'd rather to postpone the creation of (x)emacs sub-packages until someone well-familiar with (x)emacs will step in and help me with it.
I'll take it. I'm using emacs daily, and though I'm not profound in writing code for it, I'll have a look anyway. Maybe I can help out with some experience from emacs-lua.
Created attachment 456769 [details] Patch to create emacs packages This patch adds sub-packages for the Emacs major mode that is included in the package. From a short test the mode seems to work fine in Emacs. The patch also includes inconsistent macro usage. Please apply and try and upload the new version then somewhere for the final review. From a first glance looks good so far.
Thanks, Tim - your patch was applied: http://peter.fedorapeople.org/erlang-lfe.spec http://peter.fedorapeople.org/erlang-lfe-0.6.1-2.fc12.src.rpm Koji build for F-14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2586465 rpmlint output: work ~: rpmlint Desktop/erlang-lfe-0.6.1-2.fc14.i686.rpm Desktop/emacs-erlang-lfe-* erlang-lfe.i686: E: explicit-lib-dependency erlang-stdlib erlang-lfe.i686: E: no-binary erlang-lfe.i686: W: only-non-binary-in-usr-lib emacs-erlang-lfe.noarch: W: no-documentation emacs-erlang-lfe-el.noarch: W: spelling-error Summary(en_US) Elisp -> Elis, Lisp, Elise emacs-erlang-lfe-el.noarch: W: spelling-error %description -l en_US elisp -> lisp, e lisp, Elise emacs-erlang-lfe-el.noarch: W: no-documentation 3 packages and 0 specfiles checked; 2 errors, 5 warnings. work ~: All these messages should be ignored.
Ping, Tim!
I'll review it this weekend.
REVIEW: Legend: + = PASSED, - = FAILED, 0 = Not Applicable (+) rpmlint is not silent, some messages can be ignored: - spelling errors are false positives - only-non-binary-in-usr-lib and no-binary: general Erlang packaging problem which cannot be avoided in the package - Explicit lib dependency is required, as no shared lib that can be auto-detected - no-documentation: I suggest adding README and COPYRIGHT file (see below), there is also documentation in doc/, why is it not included? You might also want to include the examples as doc. + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license (BSD). - The file, containing the text of the license(s) for the package, is included in %doc. - There is a COPYRIGHT file containing the license, it must be included in the %doc section + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL. package# sha256sum rvirding-lfe-v0.6.1-0-g1bcf461.tar.gz e84a8c8e743badcae9438b66897210c6266f79d580fa9d67fa0dfcd0eff0d976 rvirding-lfe-v0.6.1-0-g1bcf461.tar.gz downloaded# sha256sum ~/download/rvirding-lfe-v0.6.1-0-g1bcf461.tar.gz e84a8c8e743badcae9438b66897210c6266f79d580fa9d67fa0dfcd0eff0d976 ~/download/rvirding-lfe-v0.6.1-0-g1bcf461.tar.gz + The package successfully compiles and builds into binary rpms on at least one primary architecture. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files. + The package does NOT bundle copies of system libraries. + The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissible content. + No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1). 0 No devel sub-package. + The package does NOT contain any .la libtool archives. 0 Not a GUI application. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8. The documentation should be fixed, the inclusion of the COPYRIGHT file must be fixed.
Made several docs fixes: http://peter.fedorapeople.org/erlang-lfe.spec http://peter.fedorapeople.org/erlang-lfe-0.6.1-4.fc12.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2600681
Looks good to me now. You should document all changes in the changelog. APPROVED.
Thanks! New Package SCM Request ======================= Package Name: erlang-lfe Short Description: Lisp Flavoured Erlang Owners: peter Branches: f13 f14 el5 el6 InitialCC:
Git done (by process-git-requests).
erlang-lfe-0.6.1-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/erlang-lfe-0.6.1-4.fc14
erlang-lfe-0.6.1-4.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/erlang-lfe-0.6.1-4.fc13
erlang-lfe-0.6.1-4.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update erlang-lfe'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/erlang-lfe-0.6.1-4.fc13
Ok, the package is available in Rawhide so I'm closing this.
erlang-lfe-0.6.1-5.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/erlang-lfe-0.6.1-5.el5
erlang-lfe-0.6.1-4.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
erlang-lfe-0.6.1-4.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
erlang-lfe-0.6.1-5.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.