Bug 639605 - fedpkg update command ignores bugs field
Summary: fedpkg update command ignores bugs field
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: bodhi
Version: 17
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Luke Macken
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-10-02 14:01 UTC by Richard W.M. Jones
Modified: 2016-09-20 02:41 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-12-01 09:49:05 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Collect bug lookup errors and keep going (2.94 KB, text/plain)
2012-06-19 16:16 UTC, Cole Robinson
no flags Details

Description Richard W.M. Jones 2010-10-02 14:01:12 UTC
Description of problem:

I created an update just now, and carefully filled in the bugs
fields with a list of several bugs (comma-separated, no spaces).

However fedpkg update (or something) has just ignored all these
bugs and the update appears to have no bugs attached, nor has
anything been posted to the relevant bugzillas.

Version-Release number of selected component (if applicable):

fedora-packager-0.5.1.4-1.fc14.noarch

How reproducible:

?

Steps to Reproduce:
1. Do 'fedpkg update'
2. Fill in bugs=123456,654321
3.
  
Actual results:

No bugs associated with the update.

Expected results:

Expect that bugs would be associated with the update.

Additional info:

Update that I filed is here:
https://admin.fedoraproject.org/updates/libguestfs-1.5.21-1.fc14.3

Comment 1 Jesse Keating 2010-10-04 22:11:40 UTC
Kicking this over to bodhi-client, I think that's where the issue is.

Comment 2 Luke Macken 2010-10-04 23:33:28 UTC
This is probably the same issue as https://fedorahosted.org/bodhi/ticket/484 (Bodhi drops all bug numbers from an update if you mistype one of them).

Comment 3 Cole Robinson 2012-06-19 15:49:56 UTC
Possibly a similar issue, I just tried to update the buglist from the web UI, one of the bugs in the middle of the list is marked 'private' in bugzilla, every bug id in the list _after_ the private one is dropped. So list was 

X Y Z

bug Y was private, list was updated as only X

Comment 4 Cole Robinson 2012-06-19 16:16:19 UTC
Created attachment 593002 [details]
Collect bug lookup errors and keep going

Completely untested patch that should collect bug lookup errors and keep going, reporting the concatenated errors in an exception at the end of the process.

Comment 5 Cole Robinson 2012-06-19 16:33:13 UTC
diff --git a/bodhi/controllers.py b/bodhi/controllers.py
index 674c9ae..9d483a9 100644
--- a/bodhi/controllers.py
+++ b/bodhi/controllers.py
@@ -1024,11 +1024,10 @@ class Root(controllers.RootController):
             try:
                 original_bugs = [bug.bz_id for bug in update.bugs]
                 update.update_bugs(bugs)
-            except xmlrpclib.Fault, f:
-                log.exception(f)
+            except ValueError:
                 note.insert(0, "Unable to access one or more bugs: %s" % f.faultString)

s/f.faultString/f/g  (still untested, just realized this tho)

Comment 6 Luke Macken 2012-07-31 15:58:41 UTC
Thanks for the patch, Cole. I applied a modified version of it upstream, and will be pushing it into staging shortly.

Comment 7 Fedora Update System 2012-11-13 21:57:24 UTC
bodhi-0.9.3-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/bodhi-0.9.3-1.fc18

Comment 8 Fedora Update System 2012-11-14 01:31:16 UTC
Package bodhi-0.9.3-1.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing bodhi-0.9.3-1.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-18150/bodhi-0.9.3-1.fc18
then log in and leave karma (feedback).

Comment 9 Fedora Update System 2012-12-01 09:49:08 UTC
bodhi-0.9.3-1.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.