Bug 639619 - Review Request: rubygem-simple-navigation - Ruby library for creating navigation for your Rails2 or Sinatra application
Summary: Review Request: rubygem-simple-navigation - Ruby library for creating navigat...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-10-02 16:26 UTC by Michal Fojtik
Modified: 2010-11-15 22:16 UTC (History)
2 users (show)

Fixed In Version: rubygem-simple-navigation-3.0.0-3.fc14
Clone Of:
Environment:
Last Closed: 2010-10-20 17:10:23 UTC
Type: ---
Embargoed:
mtasaka: fedora-review+
tcallawa: fedora-cvs+


Attachments (Terms of Use)

Description Michal Fojtik 2010-10-02 16:26:26 UTC
Spec URL: http://mifo.sk/RPMS/rubygem-simple-navigation.spec
SRPM URL: http://mifo.sk/RPMS/rubygem-simple-navigation-3.0.0-2.fc13.src.rpm

Description:
With the simple-navigation gem installed you can easily create multilevel
navigation for your Rails, Sinatra or Padrino applications. The navigation is
global in a single configuration file. It supports automatic as well as
explicit highlighting of the currently active navigation through regular
expressions.

Comment 1 Michal Fojtik 2010-10-02 16:27:08 UTC
Additional informations:

Koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2508224

rpmlint output:
$ rpmlint rubygem-simple-navigation-3.0.0-2.fc13.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings

Comment 2 Mamoru TASAKA 2010-10-09 17:33:08 UTC
Some notes

* Undefined macro
  - Defined macro %ruby_sitelib is used nowhere.

* (Build)Requires
  - ">= 0" is redundant

* %files
  - The directory %geminstdir itself is not owned by
    any packages.

  - Please consider to create -doc subpackage and move document
    files into -doc like:
----------------------------------------------------------
%{geminstdir}/spec
%{geminstdir}/Rakefile
%{gemdir}/doc/%{gemname}-%{version}
----------------------------------------------------------

Comment 3 Michal Fojtik 2010-10-11 12:06:32 UTC
* Mon Oct 11 2010 Michal Fojtik <mfojtik> - 3.0.0-3
- Created -doc subpackage
- Fixed version dependencies
- Removed unused macros

Spec URL: http://mifo.sk/RPMS/rubygem-simple-navigation.spec
SRPM URL: http://mifo.sk/RPMS/rubygem-simple-navigation-3.0.0-3.fc13.src.rpm

Comment 4 Mamoru TASAKA 2010-10-11 18:38:32 UTC
Please set %defattr(-,root,root,-) on -doc subpackage.

-----------------------------------------------
  This package (rubygem-simple-navigation)
  is APPROVED by mtasaka
-----------------------------------------------

By the way I would appreciate it if you would review
my review request (bug 639098)

Comment 5 Michal Fojtik 2010-10-12 10:39:01 UTC
Thank you!

New Package SCM Request
=======================
Package Name:      rubygem-simple-navigation
Short Description: Ruby library for creating navigation for your Rails2 
Owners:            mfojtik
Branches:          f12 f13 f14

Comment 6 Tom "spot" Callaway 2010-10-13 15:15:45 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2010-10-14 10:04:42 UTC
rubygem-simple-navigation-3.0.0-3.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/rubygem-simple-navigation-3.0.0-3.fc13

Comment 8 Fedora Update System 2010-10-14 10:09:45 UTC
rubygem-simple-navigation-3.0.0-3.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/rubygem-simple-navigation-3.0.0-3.fc14

Comment 9 Fedora Update System 2010-10-14 10:15:07 UTC
rubygem-simple-navigation-3.0.0-3.fc12 has been submitted as an update for Fedora 12.
https://admin.fedoraproject.org/updates/rubygem-simple-navigation-3.0.0-3.fc12

Comment 11 Fedora Update System 2010-10-14 10:28:45 UTC
rubygem-rb-inotify-0.8.1-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/rubygem-rb-inotify-0.8.1-2.fc14

Comment 12 Michal Fojtik 2010-10-14 10:30:00 UTC
Dammit, sorry I enter a wrong bugzilla ID in Bodhi for rb-inotify. I'm apologize for that.

Comment 13 Fedora Update System 2010-10-14 10:33:44 UTC
rubygem-rb-inotify-0.8.1-2.fc12 has been submitted as an update for Fedora 12.
https://admin.fedoraproject.org/updates/rubygem-rb-inotify-0.8.1-2.fc12

Comment 14 Fedora Update System 2010-10-14 13:52:25 UTC
rubygem-simple-navigation-3.0.0-3.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update rubygem-simple-navigation'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-simple-navigation-3.0.0-3.fc14

Comment 15 Mamoru TASAKA 2010-10-20 17:10:23 UTC
Closing.

Comment 16 Fedora Update System 2010-11-08 22:32:25 UTC
rubygem-simple-navigation-3.0.0-3.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2010-11-08 22:32:36 UTC
rubygem-simple-navigation-3.0.0-3.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 18 Fedora Update System 2010-11-15 22:16:03 UTC
rubygem-simple-navigation-3.0.0-3.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.