Bug 639727 - Review Request: dia-optics - Dia Optics shapes
Summary: Review Request: dia-optics - Dia Optics shapes
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Chitlesh GOORAH
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-10-03 16:26 UTC by Thibault North
Modified: 2010-10-07 13:31 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-10-07 13:31:28 UTC
Type: ---
Embargoed:
chitlesh: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Thibault North 2010-10-03 16:26:25 UTC
Spec URL: http://tnorth.fedorapeople.org/dia-optics/dia-optics.spec
SRPM URL: http://tnorth.fedorapeople.org/dia-optics/dia-optics-0.1-1.fc12.src.rpm
Description: 
The following shapes are included in the package:
 * Polarisation Controller
 * Directional Coupler
 * Tuneable Coupler
 * DFB Laser
 * Long Fibre
 * Detector
 * Osilloscope
 * Spectrum Analyser
 * Optical Isolator
 * EDFA
 * Variable Attenuator
 * MZ Modulator
 * Phase Modulator
 * Sine Wave Source
 * Square Wave Source
 * Long Period Grating
 * Light Beam
 * Wave

Comment 1 Chitlesh GOORAH 2010-10-05 18:42:50 UTC
- MUST: The package is named according to the Package Naming Guidelines.
- MUST: The spec file name matches the base package %{name}
- MUST: The package meets the Packaging Guidelines.
- MUST: The package is licensed with an open-source compatible license and
meet other legal requirements as defined in the legal section of Packaging
Guidelines.
- MUST: The License field in the package spec file matches the actual license.
- MUST: the source package includes the text of the license(s) in its own file,
then that file, containing the text of the license(s) for the package is
included in %doc.
- MUST: The spec file must be written in American English.
- MUST: The spec file for the package is be legible. 
- MUST: The sources used to build the package must matches the upstream source,
as provided in the spec URL.
- MUST: The package successfully compiles and builds into binary rpms on at
least i386.
- MUST: All build dependencies is listed in BuildRequires.
- MUST: The spec file handles locales properly.
- MUST: If the package does not contain shared library files located in the
dynamic linker's default paths
- MUST: the package is not designed to be relocatable
- MUST: the package owns all directories that it creates.
- MUST: the package does not contain any duplicate files in the %files listing.
- MUST: Permissions on files are set properly.
- MUST: The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
- MUST: The package consistently uses macros, as described in the macros section
of Packaging Guidelines.
- MUST: The package contains code, or permissable content. This is described in
detail in the code vs. content section of Packaging Guidelines.
- MUST: There are no Large documentation files
- MUST: %doc does not affect the runtime of the application. To summarize: If it
is in %doc, the program must run properly if it is not present.
- MUST: There are no Header files or static libraries 
- MUST: The package does not contain library files with a suffix 
- MUST: Package does NOT contain any .la libtool archives
- MUST: Package containing GUI applications includes a %{name}.desktop file, and
that file must be properly installed with desktop-file-install in the %install
section.
- MUST: Package does not own files or directories already owned by other packages. 

SHOULD Items:

 - SHOULD: The source package does include license text(s) as COPYING
 - SHOULD: mock builds succcessfully in i386.
 - SHOULD: The reviewer tested that the package functions as described. A
package should not segfault instead of running, for example.
 - SHOULD: No scriptlets were used, those scriptlets must be sane. 
 - SHOULD: No subpackages present.

APPROVED

Comment 2 Thibault North 2010-10-05 19:27:19 UTC
New Package SCM Request
=======================
Package Name: dia-optics
Short Description: Dia Optics shapes
Owners: tnorth
Branches: f12 f13 f14 el6
InitialCC:

Comment 3 Kevin Fenzi 2010-10-06 23:27:23 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.