Bug 639991 - Review Request: rubygem-rb-inotify - A Ruby wrapper for Linux's inotify, using FFI
Summary: Review Request: rubygem-rb-inotify - A Ruby wrapper for Linux's inotify, usin...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-10-04 13:56 UTC by Michal Fojtik
Modified: 2015-02-17 13:44 UTC (History)
3 users (show)

Fixed In Version: rubygem-rb-inotify-0.8.1-2.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-10-20 17:08:24 UTC
Type: ---
Embargoed:
mtasaka: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Michal Fojtik 2010-10-04 13:56:35 UTC
Spec URL: http://mifo.sk/RPMS/rubygem-rb-inotify.spec
SRPM URL: http://mifo.sk/RPMS/rubygem-rb-inotify-0.8.1-1.fc13.src.rpm
Description: 

This is a simple wrapper over the inotify Linux kernel subsystem for monitoring changes to files and directories. It uses the FFI gem to avoid having to compile a C extension.

Comment 1 Michal Fojtik 2010-10-04 13:57:26 UTC
Additional info:

Koji build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2510775

rpmlint:

$ rpmlint rubygem-rb-inotify-0.8.1-1.fc13.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings

Comment 2 Mamoru TASAKA 2010-10-10 18:18:15 UTC
Some notes:

* Unused macro
  - Please remove unused macro defined in the spec file

* Explicit dependency
  - ">= 0.5.0" part on "Requires: rubygem(ffi)" is not needed
    because rubygem-ffi packages on currently supported branches
    on Fedora all satisfy this version dependency.

* %files
  - The directory %geminstdir itself is not owned by any
    packages.

  - The following files should also be %doc
-------------------------------------------------------
%{geminstdir}/Rakefile
%{geminstdir}/rb-inotify.gemspec
-------------------------------------------------------

Comment 3 Michal Fojtik 2010-10-11 12:02:52 UTC
(In reply to comment #2)
> Some notes:
> 
> * Unused macro
>   - Please remove unused macro defined in the spec file
> 
> * Explicit dependency
>   - ">= 0.5.0" part on "Requires: rubygem(ffi)" is not needed
>     because rubygem-ffi packages on currently supported branches
>     on Fedora all satisfy this version dependency.
> 
> * %files
>   - The directory %geminstdir itself is not owned by any
>     packages.
> 
>   - The following files should also be %doc
> -------------------------------------------------------
> %{geminstdir}/Rakefile
> %{geminstdir}/rb-inotify.gemspec
> -------------------------------------------------------

* Mon Oct 11 2010 Michal Fojtik <mfojtik@patashnik> - 0.8.1-2
- Removed unused macros
- Moved Rakefile into doc

Spec URL: http://mifo.sk/RPMS/rubygem-rb-inotify.spec
SRPM URL: http://mifo.sk/RPMS/rubygem-rb-inotify-0.8.1-2.fc13.src.rpm

Comment 4 Mamoru TASAKA 2010-10-11 16:56:04 UTC
Please fix (revert) the URL (not rb-notify but rb-inotify)

------------------------------------------------------------
  This package (rubygem-rb-inotify) is APPROVED by mtasaka
------------------------------------------------------------

Comment 5 Michal Fojtik 2010-10-12 10:38:09 UTC
Thank you!

New Package SCM Request
=======================
Package Name:      rubygem-rb-inotify
Short Description: A Ruby wrapper for Linux's inotify, using FFI
Owners:            mfojtik
Branches:          f12 f13 f14

Comment 6 Tom "spot" Callaway 2010-10-13 15:16:09 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2010-10-14 10:31:26 UTC
rubygem-rb-inotify-0.8.1-2.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/rubygem-rb-inotify-0.8.1-2.fc13

Comment 8 Fedora Update System 2010-10-14 10:32:03 UTC
rubygem-rb-inotify-0.8.1-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/rubygem-rb-inotify-0.8.1-2.fc14

Comment 9 Fedora Update System 2010-10-14 10:35:06 UTC
rubygem-rb-inotify-0.8.1-2.fc12 has been submitted as an update for Fedora 12.
https://admin.fedoraproject.org/updates/rubygem-rb-inotify-0.8.1-2.fc12

Comment 10 Fedora Update System 2010-10-14 10:35:06 UTC
rubygem-rb-inotify-0.8.1-2.fc12 has been submitted as an update for Fedora 12.
https://admin.fedoraproject.org/updates/rubygem-rb-inotify-0.8.1-2.fc12

Comment 11 Fedora Update System 2010-10-14 13:51:32 UTC
rubygem-rb-inotify-0.8.1-2.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update rubygem-rb-inotify'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-rb-inotify-0.8.1-2.fc14

Comment 12 Mamoru TASAKA 2010-10-20 17:08:24 UTC
Closing.

Comment 13 Fedora Update System 2010-11-04 23:44:19 UTC
rubygem-rb-inotify-0.8.1-2.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2010-11-08 22:33:28 UTC
rubygem-rb-inotify-0.8.1-2.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2010-11-08 22:36:10 UTC
rubygem-rb-inotify-0.8.1-2.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Tomas Hrcka 2015-02-17 08:31:41 UTC
Package Change Request
======================
Package Name: rubygem-rb-inotify
New Branches: epel7
Owners: mfojtik humaton

FAS user name: humaton

Comment 17 Gwyn Ciesla 2015-02-17 13:44:52 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.