Bug 640282 - cgconfig service always fails
Summary: cgconfig service always fails
Keywords:
Status: CLOSED INSUFFICIENT_DATA
Alias: None
Product: Fedora
Classification: Fedora
Component: libcgroup
Version: 14
Hardware: All
OS: Linux
high
high
Target Milestone: ---
Assignee: Jan Safranek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-10-05 13:05 UTC by Jan Safranek
Modified: 2011-04-29 08:35 UTC (History)
4 users (show)

Fixed In Version: libcgroup-0.36.2-5.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-04-29 08:35:11 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Jan Safranek 2010-10-05 13:05:56 UTC
Version-Release number of selected component (if applicable):
libcgroup-0.36.2-4

How reproducible:
always

Steps to Reproduce:
1. service cgconfig start
  
Actual results:
Starting cgconfig service: Failed to parse /etc/cgconfig.co[FAILED]

Expected results:
[OK]

Additional info:
default /etc/cgconfig.conf expects systemd mounts tmpfs to /sys/fs/cgroup, but since systemd has been kicked of the F14 release, nothing mounts it.

Comment 1 Jan Safranek 2010-10-05 13:12:20 UTC
As quick solution, let's move control groups back to /cgroup (= Fedora 13 style). Proper solution will be in F15, I don't want to mess F14 in this part of release cycle.

Comment 2 Dhaval Giani 2010-10-05 17:11:48 UTC
Or setup cgconfig to mount tmpfs at /sys/fs/cgroup if it is not mounted there already. That is the position recommended by the kernel and we should be mounting there.

Comment 3 Jan Safranek 2010-10-06 07:55:33 UTC
This is certainly valid option, patches are welcome. The init script must be super-reliable, not mounting additional tmpfs when not needed, not unmounting it when it is still needed and there are lot of corner cases when things may go wrong. I will be out of office for most of the next two weeks (i.e. till F14 deadline 2010-10-18). While I am able to implement it, I am afraid someone else must test it and fix possible bugs. In addition, three weeks before release is really not good time to experiment in F14! We should have caught this earlier.

Comment 4 Dhaval Giani 2010-10-06 11:32:37 UTC
so how about we rollback the systemd changse, since its tested well without them and push the systemd specific changes in F15?

Comment 5 Jan Safranek 2010-10-06 11:35:58 UTC
I agree with the rollback to F13 behavior.

Comment 6 Fedora Update System 2010-10-06 11:45:29 UTC
libcgroup-0.36.2-5.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/libcgroup-0.36.2-5.fc14

Comment 7 Fedora Update System 2010-10-07 19:51:46 UTC
libcgroup-0.36.2-5.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update libcgroup'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/libcgroup-0.36.2-5.fc14

Comment 8 Fedora Update System 2010-10-12 03:12:37 UTC
libcgroup-0.36.2-5.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Osier Yang 2011-03-02 09:01:23 UTC
# rpm -qa | grep cgroup
libcgroup-0.36.2-5.fc14.x86_64
[root@Osier ~]# service cgconfig start
Starting cgconfig service: Failed to parse /etc/cgconfig.co[FAILED]

cat /etc/cgconfig.conf 
#
#  Copyright IBM Corporation. 2007
#
#  Authors:	Balbir Singh <balbir.ibm.com>
#  This program is free software; you can redistribute it and/or modify it
#  under the terms of version 2.1 of the GNU Lesser General Public License
#  as published by the Free Software Foundation.
#
#  This program is distributed in the hope that it would be useful, but
#  WITHOUT ANY WARRANTY; without even the implied warranty of
#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
#
# See man cgconfig.conf for further details.
#
# By default, mount all separately controllers
# to /cgroup/<controller name>

mount {
	cpuset	= /cgroup/cpuset;
	cpu	= /cgroup/cpu;
	cpuacct	= /cgroup/cpuacct;
	memory	= /cgroup/memory;
	devices	= /cgroup/devices;
	freezer	= /cgroup/freezer;
	net_cls	= /cgroup/net_cls;
	ns	= /cgroup/ns;
	blkio	= /cgroup/blkio;
}


Problem still exists

Comment 10 Ivana Varekova 2011-03-02 11:38:48 UTC
Hello,
please can you attach here the output of:
$ cat /proc/cgroups

Comment 11 Osier Yang 2011-03-02 15:18:32 UTC
sure, quick response, :-)

#cat /proc/cgroups 
#subsys_name	hierarchy	num_cgroups	enabled
cpuset	1	1	1
ns	8	3	1
cpu	2	1	1
cpuacct	3	1	1
memory	4	1	1
devices	5	1	1
freezer	6	1	1
net_cls	7	1	1
blkio	9	1	1

Comment 12 Ivana Varekova 2011-03-02 15:31:29 UTC
You have already mounted cgroups thus the start failed, if you remove the existing hierarchies (stop the service or use cgclear), then it will works ok. Please try this method and write ere the result.

Comment 13 Dhaval Giani 2011-03-02 15:33:01 UTC
Can you do the following,

cgclear
cgconfigparser -l /etc/cgconfig.conf

If it fails, please run cgclear followed by the strace of cgconfigparser and share the same please.

Comment 14 Dhaval Giani 2011-03-02 15:33:31 UTC
Are you using systemd by any chance?

Comment 15 Osier Yang 2011-03-03 03:08:04 UTC
(In reply to comment #13)
> Can you do the following,
> 
> cgclear
> cgconfigparser -l /etc/cgconfig.conf
> 
> If it fails, please run cgclear followed by the strace of cgconfigparser and
> share the same please.

Thanks

yes, it works, what I have on my system is only: systemd-units.x86_64, still curious why it failed when starting.

Comment 16 Ivana Varekova 2011-04-29 08:35:11 UTC
Hello Osier,
please repopen this bug and attach here strace wanted in comment 13, if the problem appears again. Now I'm closing this bug because of insufficient data.


Note You need to log in before you can comment on or make changes to this bug.