Spec URL: http://fedorapeople.org/~iarnell/review/perl-MooseX-NonMoose.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-MooseX-NonMoose-0.15-1.fc13.src.rpm Description: MooseX::NonMoose allows for easily subclassing non-Moose classes with Moose, taking care of the annoying details connected with doing this, such as setting up proper inheritance from Moose::Object and installing (and inlining, at make_immutable time) a constructor that makes sure things like BUILD methods are called. It tries to be as non-intrusive as possible - when this module is used, inheriting from non-Moose classes and inheriting from Moose classes should work identically, aside from the few caveats mentioned below. One of the goals of this module is that including it in a Moose::Exporter-based package used across an entire application should be possible, without interfering with classes that only inherit from Moose modules, or even classes that don't inherit from anything at all. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2514532 *rt-0.10_01
(my first package comment) The dependency on perl-Moose >= 1.08 is broken for fc13 (I think). The following shows that perl-Moose is only up to 0.99 for fc13: http://koji.fedoraproject.org/koji/packageinfo?packageID=3119
Yes, you're right. But I don't intend to push this to f13 at the minute (if at all). perl-Moose-1.08 is already available in f14, and 1.14 is in rawhide (coming soon to f14).
And typically, as soon as I post the review request, there's an updated package available. But MooseX-NonMoose 0.16 requires Moose >= 1.15 which enables a bunch of deprecation warnings. Since I do want to get this into f14, we need to stick with MooseX-NonMoose 0.15 for the time being.
Ok, then I believe the name of the spec and srpm should be changed from *.fc13.* to *.fc14.* Besides that, here's my stab: OK: * The name/version match http://fedoraproject.org/wiki/Packaging:NamingGuidelines * License: OK * No inclusion of pre-built binaries * Spec is legible * RPMLINT: * perl-MooseX-NonMoose.src: W: no-cleaning-of-buildroot %clean * but this is okay >= fc10 * perl-MooseX-NonMoose.src: W: no-buildroot-tag * but this is okay >= fc10 * perl-MooseX-NonMoose.src: W: no-%clean-section * but this is okay >= fc13 * Description is good * BuildRequires and Requires are all good * Documentation from upstream is good * Good default file permissions * The source is the same as upstream * Perl specific stuff looks in-line with * http://fedoraproject.org/wiki/Packaging:Perl * mock runs fine for fc14 Needs Work: Only the .fc13. -> .fc14. name change.
(Just to be clear: I do not have creds to officially review or approve packages; just trying to learn)
There is one problem with this package: http://koji.fedoraproject.org/koji/getfile?taskID=2557181&name=build.log Can't locate object method "_meta_instance" via package "Class::MOP::Class::__ANON__::SERIAL::2" at /builddir/build/BUILD/MooseX-NonMoose-0.15/blib/lib/MooseX/NonMoose/Meta/Role/Constructor.pm line 71. # Tests were run but no plan was declared and done_testing() was not seen. t/04-multi-level.t ................. and the same message for almost all tests.
Fixed with latest upstream version. New Spec: http://fedorapeople.org/~iarnell/review/perl-MooseX-NonMoose.spec New SRPM: http://fedorapeople.org/~iarnell/review/perl-MooseX-NonMoose-0.16-1.fc14.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2557240
New Package CVS Request ======================= Package Name: perl-MooseX-NonMoose Short Description: Easy subclassing of non-Moose classes Owners: iarnell Branches: f14 InitialCC: perl-sig
Git done (by process-git-requests).
perl-MooseX-NonMoose-0.15-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-MooseX-NonMoose-0.15-1.fc14
perl-MooseX-NonMoose-0.15-1.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-MooseX-NonMoose'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/perl-MooseX-NonMoose-0.15-1.fc14
perl-MooseX-NonMoose-0.15-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.