Bug 640586 - sata_sil24 - add support for Adaptec 1225SA RAID eSATA controller
Summary: sata_sil24 - add support for Adaptec 1225SA RAID eSATA controller
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel
Version: 5.5
Hardware: All
OS: Linux
low
medium
Target Milestone: rc
: ---
Assignee: David Milburn
QA Contact: Storage QE
URL:
Whiteboard:
Depends On:
Blocks: 677384
TreeView+ depends on / blocked
 
Reported: 2010-10-06 11:59 UTC by Bryn M. Reeves
Modified: 2018-11-14 17:31 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-01-13 21:56:23 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2011:0017 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 5.6 kernel security and bug fix update 2011-01-13 10:37:42 UTC

Description Bryn M. Reeves 2010-10-06 11:59:50 UTC
Description of problem:
The Adaptec 1225SA uses the Silicon Image BID_SIL3131 board but the current RHEL5 sata_sil24 does not have the PCI ID for this variant.

Version-Release number of selected component (if applicable):
2.6.18-*.el5

How reproducible:
100%

Steps to Reproduce:
1. $ modinfo sata_sil24 | grep v00001095d00000244

Actual results:
< no output >

Expected results:
$ modinfo sata_sil24 | grep v00001095d00000244
alias:          pci:v00001095d00000244sv*sd*bc*sc*i*


Additional info:
Merged upstream here:

commit 464b3286b4aa459059c6fda85ba55185fd21d9fc
Author: Tejun Heo <tj>
Date:   Wed Jul 2 17:50:23 2008 +0900

    sata_sil24: add DID for another adaptec flavor
    
    There's another DID used for Adaptec card.  Add it.
    
    Reported by Travis Read.
    
    Signed-off-by: Tejun Heo <tj>
    Cc: Travis Read <ics.au>
    Signed-off-by: Jeff Garzik <jgarzik>

diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c
index 8ee6b5b..84ffcc2 100644
--- a/drivers/ata/sata_sil24.c
+++ b/drivers/ata/sata_sil24.c
@@ -370,6 +370,7 @@ static const struct pci_device_id sil24_pci_tbl[] = {
        { PCI_VDEVICE(INTEL, 0x3124), BID_SIL3124 },
        { PCI_VDEVICE(CMD, 0x3132), BID_SIL3132 },
        { PCI_VDEVICE(CMD, 0x0242), BID_SIL3132 },
+       { PCI_VDEVICE(CMD, 0x0244), BID_SIL3132 },
        { PCI_VDEVICE(CMD, 0x3131), BID_SIL3131 },
        { PCI_VDEVICE(CMD, 0x3531), BID_SIL3131 },

Comment 1 Bryn M. Reeves 2010-10-06 12:01:38 UTC
lspci for device:

07:00.0 RAID bus controller: Silicon Image, Inc. Unknown device 0244 (rev 01)

07:00.0 0104: 1095:0244 (rev 01) (prog-if 01)
        Subsystem: 9005:0244
        Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
        Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
        Latency: 0, Cache Line Size: 64 bytes
        Interrupt: pin A routed to IRQ 15
        Region 0: Memory at df1fbf80 (64-bit, non-prefetchable) [size=128]
        Region 2: Memory at df1fc000 (64-bit, non-prefetchable) [size=16K]
        Region 4: I/O ports at ec80 [size=128]
        Expansion ROM at df100000 [disabled] [size=512K]
        Capabilities: [54] Power Management version 2
                Flags: PMEClk- DSI+ D1+ D2+ AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
                Status: D0 PME-Enable- DSel=0 DScale=1 PME-
        Capabilities: [5c] Message Signalled Interrupts: 64bit+ Queue=0/0 Enable-
                Address: 0000000000000000  Data: 0000
        Capabilities: [70] Express Legacy Endpoint IRQ 0
                Device: Supported: MaxPayload 1024 bytes, PhantFunc 0, ExtTag-
                Device: Latency L0s <64ns, L1 <1us
                Device: AtnBtn- AtnInd- PwrInd-
                Device: Errors: Correctable- Non-Fatal+ Fatal+ Unsupported-
                Device: RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop-
                Device: MaxPayload 256 bytes, MaxReadReq 1024 bytes
                Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s, Port 0
                Link: Latency L0s unlimited, L1 unlimited
                Link: ASPM Disabled RCB 64 bytes CommClk+ ExtSynch-
                Link: Speed 2.5Gb/s, Width x1
        Capabilities: [100] Advanced Error Reporting

Comment 2 David Milburn 2010-10-06 13:33:31 UTC
Bryn, should be no problem to add this device ID, I will need to build a kernel
thru brew. Can you do a boot test for me? Thanks.

Comment 3 Bryn M. Reeves 2010-10-06 13:35:32 UTC
Hi David, thanks although I'm more than happy to build the kernel here if it takes that off your plate. I can't test myself (beyond a smoke test) as I don't have the hardware here but I can relay a test package to the reporter and hopefully get their feedback.

Comment 4 David Milburn 2010-10-06 13:58:31 UTC
Hi Bryn, I have a test kernel brewing, even though it is a simple patch,
it would be nice to have reporter boot on their hardware. I will let you know
when test kernel(s) are ready.

Comment 5 Bryn M. Reeves 2010-10-06 14:20:04 UTC
Thanks David, have added a comment to the case to get an ack from the reporter with the hardware.

Comment 6 David Milburn 2010-10-06 20:53:40 UTC
Here you go Bryn, please let me know if you need a diff arch

http://people.redhat.com/dmilburn/.bz640586/

Comment 7 Bryn M. Reeves 2010-11-02 14:36:23 UTC
Reporter confirms that the kernels linked in comment #6 detect the Adaptec board & appears to work correctly.

Thanks David!

Comment 9 RHEL Program Management 2010-11-08 22:19:45 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 11 Jarod Wilson 2010-11-09 17:12:59 UTC
in kernel-2.6.18-231.el5
You can download this test kernel (or newer) from http://people.redhat.com/jwilson/el5

Detailed testing feedback is always welcomed.

Comment 13 Gris Ge 2010-12-23 01:41:17 UTC
No hardware to test the function of driver.
Only checked the modinfo:
[root@VMC2 ~]# modinfo  /lib/modules/2.6.18-194.el5/kernel/drivers/ata/sata_sil24.ko 
filename:       /lib/modules/2.6.18-194.el5/kernel/drivers/ata/sata_sil24.ko
license:        GPL
description:    Silicon Image 3124/3132 SATA low-level driver
author:         Tejun Heo
srcversion:     7C6CD9FC42E5397C7F92DB4
alias:          pci:v00001095d00003531sv*sd*bc*sc*i*
alias:          pci:v00001095d00003131sv*sd*bc*sc*i*
alias:          pci:v00001095d00000242sv*sd*bc*sc*i*
alias:          pci:v00001095d00003132sv*sd*bc*sc*i*
alias:          pci:v00008086d00003124sv*sd*bc*sc*i*
alias:          pci:v00001095d00003124sv*sd*bc*sc*i*
depends:        libata
vermagic:       2.6.18-194.el5 SMP mod_unload gcc-4.1
module_sig:     883f3504ba0377c78ccfeaa942826a112b28f0a09dd7cc5637945eaf81998dca61b86e2ba015bb0a0c3428380389be5964c7fc55dc0bc9a56876ad4c9
=============================================
[root@VMC2 ~]# modinfo /lib/modules/2.6.18-236.el5/kernel/drivers/ata/sata_sil24.ko | grep v00001095d00000244

alias:          pci:v00001095d00000244sv*sd*bc*sc*i*
=====================

Change this bug's status into SanityOnly.

Comment 15 errata-xmlrpc 2011-01-13 21:56:23 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0017.html


Note You need to log in before you can comment on or make changes to this bug.