Spec URL: http://www.cora.nwra.com/~orion/fedora/drupal-ckeditor.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/drupal-ckeditor-6.x.1.2-1.fc13.src.rpm Description: This module will allow Drupal to replace textarea fields with the CKEditor - a visual HTML editor, sometimes called WYSIWYG editor. This HTML text editor brings many of the powerful WYSIWYG editing functions of known desktop editors like Word to the web. It's very fast and doesn't require any kind of installation on the client computer.
After some discussion on the fedora-logistics list, we've come to the conclusion that having the possibility to install multiple concurrent versions of drupal is desirable. The drupal-package is going to be renamed to drupal6 (rename review is pending). Additionally, the guidelines don't allow letters in the version (so no 6.x) - so please rename the package to drupal6-ckeditor-1.2.
http://www.cora.nwra.com/~orion/fedora/drupal6-ckeditor.spec http://www.cora.nwra.com/~orion/fedora/drupal6-ckeditor-1.2-1.fc14.src.rpm
http://www.cora.nwra.com/~orion/fedora/drupal6-ckeditor-1.5-1.fc15.src.rpm * Wed Aug 3 2011 Orion Poplawski <orion.com> - 1.5-1 - Update to 1.5
http://www.cora.nwra.com/~orion/fedora/drupal6-ckeditor-1.6-1.fc16.src.rpm * Tue Oct 25 2011 Orion Poplawski <orion.com> - 1.6-1 - Update to 1.6
http://www.cora.nwra.com/~orion/fedora/drupal7-ckeditor-1.7-1.fc16.src.rpm http://www.cora.nwra.com/~orion/fedora/drupal7-ckeditor.spec * Wed Mar 14 2012 Orion Poplawski <orion.com> - 1.7-1 - Update to 7.x-1.7
This builds fine and seems pretty clean given all of the drupal macros and the RHEL5 stuff that I assume you need to include. It is a bit confusing that the changelog appears to go backwards 1.5->1.6->1.8->1.6->1.7. I guess that's what upstream did, though. It looks like upstream did another update as recently as a week ago. I don't think it's substantially different so I'll just look at what's here. You don't need %defattr in %files on any supported Fedora or EPEL release. rpmlint says: drupal7-ckeditor.noarch: W: dangling-relative-symlink /usr/share/drupal7/modules/ckeditor/ckeditor ../../../ckeditor This is OK; that link is satisfied by a dependency. drupal7-ckeditor.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/drupal7-ckeditor-1.7/CHANGELOG.txt Pretty triviaal to fix this. * source files match upstream. sha256sum: 2cfe66881123f12f7c44204c25b24a37a6053c11c1b2e1a9e5bed88f4e91918b ckeditor-7.x-1.7.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * license field matches the actual license. * license is open source-compatible. * license text included in package (or at least one of the texts; no idea why upstream includes the GPL text but not the other two). X latest version is being packaged. * BuildRequires are proper (none). * package builds in mock (rawhide, x86_64). * package installs properly. X rpmlint has a valid complaint. * final provides and requires are sane: drupal7-ckeditor = 1.7-1.fc18 = ckeditor drupal7 * no bundled libraries (except for javascript ones, which are permitted). * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one.
http://www.cora.nwra.com/~orion/fedora/drupal7-ckeditor-1.9-1.fc16.src.rpm http://www.cora.nwra.com/~orion/fedora/drupal7-ckeditor.spec * Wed Apr 25 2012 Orion Poplawski <orion.com> - 1.9-1 - Update to 7.x-1.9 - Fix line endings in CHANGELOG.txt - Drop %%defattr I also dropped the drupal6 versions from the changelog.
Awesome, thanks. APPROVED
New Package SCM Request ======================= Package Name: drupal7-ckeditor Short Description: Replace textarea fields with the CKEditor - a visual HTML editor Owners: orion Branches: f17 f16 el6 InitialCC:
Git done (by process-git-requests).
Checked in and built. Thanks all!