Spec URL: http://sochotni.fedorapeople.org/packages/google-guice.spec SRPM URL: http://sochotni.fedorapeople.org/packages/google-guice-2.0-1.1219svn.fc13.src.rpm Description: Lightweight dependency injection framework
I'm taking this one.
=== REQUIRED ITEMS === [!] Rpmlint output: W: invalid-url Source0: http://google-guice.googlecode.com/files/guice-2.0-1219.tar.xz HTTP Error 404: Not Found Please remove the http part because this is autogenerated. [X] Package is named according to the Package Naming Guidelines. [X] Spec file name must match the base package name, in the format %{name}.spec. [X] Package meets the Packaging Guidelines[2]. [X] Package successfully compiles and builds into binary rpms. [X] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [X] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X] License field in the package spec file matches the actual license. License type: [X] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [X] All independent sub-packages have license of their own [X] Spec file is legible and written in American English. [-] Sources used to build the package matches the upstream source, as provided in the spec URL. [X] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5]. [X] Package must own all directories that it creates. [X] Package requires other packages for directories it uses. [X] Package does not contain duplicates in %files. [X] Permissions on files are set properly. [X] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [X] Package consistently uses macros. [X] Package contains code, or permissable content. [X] Fully versioned dependency in subpackages, if present. [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [X] Package does not own files or directories owned by other packages. [X] Javadoc documentation files are generated and included in -javadoc subpackage [X] Packages have proper BuildRequires/Requires on jpackage-utils [X] Javadoc subpackages have Require: jpackage-utils [X] Package uses %global not %define [X] If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...) [!] If source tarball includes bundled jar/class files these need to be removed prior to building Munge repacking should be done in prep. [X] All filenames in rpm packages must be valid UTF-8. === Maven === [X] Use %{_mavenpomdir} macro for placing pom files instead of %{_datadir}/maven2/poms [-] If package uses "-Dmaven.test.skip=true" explain why it was needed in a comment [-] If package uses custom depmap "-Dmaven2.jpp.depmap.file=*" explain why it's needed in a comment [X] Package uses %update_maven_depmap in %post/%postun [X] Packages have Requires(post) and Requires(postun) on jpackage-utils (for %update_maven_depmap macro) === Other suggestions === [X] If possible use upstream build method (maven/ant/javac) [X] Javadocs are placed in %{_javadocdir}/%{name}-%{version} with %{_javadocdir}/%{name} symlink [X] Jar files are installed to %{_javadir}/%{name}-%{version}.jar with %{_javadir}/%{name}.jar (unversioned) symlink [X] If package contains pom.xml files install it (including depmaps) even when building with ant [X] Avoid having BuildRequires on exact NVR unless necessary [X] Package has BuildArch: noarch (if possible) [X] Latest version is packaged. [X] Reviewer should test that the package builds in mock. Problems: 1. invalid url 2. repacking munge should be done in prep 3. Fix Bundle-Version in Manifest.mf to have proper version
(In reply to comment #2) > Problems: > 1. invalid url > 2. repacking munge should be done in prep > 3. Fix Bundle-Version in Manifest.mf to have proper version All fixed. * Wed Oct 13 2010 Stanislav Ochotnicky <sochotnicky> - 2.0-2.1219svn - Moved munge repacking to prep - Added -Dversion to change generated manifest version - Removed http part of URL Spec URL: http://sochotni.fedorapeople.org/packages/google-guice.spec SRPM URL: http://sochotni.fedorapeople.org/packages/google-guice-2.0-2.1219svn.fc13.src.rpm
Thanks, This package is APPROVED.
Thanks for the review. Requesting repo New Package CVS Request ======================= Package Name: google-guice Short Description: Lightweight dependency injection framework Owners: sochotni Branches: f14 InitialCC:
Git done (by process-git-requests).
Thanks for the fast repos. Package built, closing. http://koji.fedoraproject.org/koji/taskinfo?taskID=2534238